From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D6E9F39A86AD for ; Thu, 6 Jun 2024 20:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6E9F39A86AD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6E9F39A86AD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717707467; cv=none; b=jnat10U+NDqPognZY5hEg4D1IvpOtCbuVMMpvvGOYSQ+NfTdFYFNg5Rrxv6DJwiSy/AE6rtebtJyGg8YdHhYOxY7hkrAh5Bsx+bwiCOnLeuaWi3hL1IdirFF7GxfaqqyMCwrXuPtvL9L7grrq86FxYRyxwcgcrSbZNkCNXiaiZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717707467; c=relaxed/simple; bh=dAZUWHkj0qr/oKy1FXNkNj0e8PQiV1961mSa5MgHJao=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=up23WYCXiDTz3eETMmXB93RY2BHTYrViZRYVzuMNDp/wDcLMOV7jWGlg7+OX9Cqv7ka5BQiTp7oxN6TYudr5C3fWg8vmqbuua4wS9pqMTfcOP5cGlREvaglcPdJn74gxtv+Dug0NMx3pQH4QhUTXkME5HFyVpn8U2xvJJeOOao4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717707465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BlyN1M2iJWbxzM4UclpuPPY4spyNc6G2ORTbTYjnJlQ=; b=W7zQhm50u90V69Q/HhB3RMb2+/i9HEfQPGi4sBkajA9PGktWcdjJzBgwEHpBLc5jTSsbSA qZKfdIxswHIcWlXGWIRIv3GJSNrJ38NKsEFlKZxDyOzAvC4+skW4cbZ+HMWPviqtYU9eUv figC0pxdFeorSM8G4M8wSO8B3CxnJZs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-M0vhI9RaNXq1swcyFX9HRA-1; Thu, 06 Jun 2024 16:57:44 -0400 X-MC-Unique: M0vhI9RaNXq1swcyFX9HRA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42158c90cafso10497585e9.0 for ; Thu, 06 Jun 2024 13:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717707463; x=1718312263; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BlyN1M2iJWbxzM4UclpuPPY4spyNc6G2ORTbTYjnJlQ=; b=FBBgWdm3PcjuDsbA43hhVkyXGPKj3VBRiL6nHw8I0Od4vWfTIJuCeohxns+W0tL2jB Lt/haG5ZsjkKfoQS9RNXshdjExO3OVgZHATZ7I396UFcgJOg3kOuvwmo+/eq0lQbwzBg a0R7rAPIGNPLXdewHZCDb8Wm9d6P+3OWJQoDl4FHrcjRrXscU6keyivyQIZdUfQzI8ip S+VGNUWdEoy8mvwnk1lIgxarwUJT8c/OPTsIcJgq4VB3l9rt8UfD4PaP59a95zGPY/I1 pQhpt2/kBcXheYiTwooyhfcicqDc6isCDWyuomBS2a5rdDhysn8VYdripv99BKGukPWC S4gg== X-Gm-Message-State: AOJu0YyvCrzhQLfl2QAj6dq/Ss9ytpOs6gBWQgt4lioDWSI7kchAGB9q zwH/zI73jM2ZFnG+9SjodaNth0PoxfjpkEP0ouCP5502QlasGhwxNfO65I208ayVaZvi+cL7WWK ySmIgR7hXa2s2Y/ihmk1+8L2zHRz7bdSyV4GBYj7nF42S4FiKhlR56h0= X-Received: by 2002:a05:600c:310e:b0:418:f991:8ad4 with SMTP id 5b1f17b1804b1-421649eb580mr6580425e9.6.1717707463197; Thu, 06 Jun 2024 13:57:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCtTiNGcsIhX/PGDANbNx1K2r/ekUBNqjSW/ewUuGgWqMjIer3FJLLVVRC8SzZl7cbyzrNwQ== X-Received: by 2002:a05:600c:310e:b0:418:f991:8ad4 with SMTP id 5b1f17b1804b1-421649eb580mr6580265e9.6.1717707462799; Thu, 06 Jun 2024 13:57:42 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215811cfc1sm64448255e9.22.2024.06.06.13.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 13:57:42 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1sFKAo-0009hm-EP; Thu, 06 Jun 2024 20:57:26 +0000 Date: Thu, 6 Jun 2024 20:57:26 +0000 (UTC) From: Joseph Myers To: "Luke T. Shumaker" cc: binutils@sourceware.org, gdb-patches@sourceware.org, "Alfred M. Szmidt" , Ralf Wildenhues , Tom Tromey Subject: Re: [PATCH 4/4] Add a ./bootstrap script to automate bundling and generating files In-Reply-To: <20240606201145.1747021-5-lukeshu@lukeshu.com> Message-ID: <5e24a41-524a-da55-bd5e-b8a0c23d360@redhat.com> References: <20240606201145.1747021-1-lukeshu@lukeshu.com> <20240606201145.1747021-5-lukeshu@lukeshu.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 6 Jun 2024, Luke T. Shumaker wrote: > * config/patches/ > * libdecnumber/patches/ > * libiberty/patches/ In my view, rather than maintaining binutils-local patches to these directories, we should treat GCC and binutils as equally canonical for them; any change approved and applied in one tree but not the other should be treated as thereby approved for the other tree as well, and get committed there (post to the relevant patches list and commit, without seeking separate approval). That way, the only differences between the two trees should be in the ChangeLog files (reflecting when changes were applied to the two trees). The same applies to files at top-level present in both trees, except for ChangeLogs, README, MAINTAINERS and SECURITY.txt which are genuinely meant to be different: any difference between other top-level files in the two trees is a bug that should be reconciled by ensuring all patches have been applied to both places. Also to files (other than ChangeLogs) in include/ that are present in both trees (but some files in include/ are legitimately present only in one of the two trees). Effectively, rather than treating GCC as the upstream for any files, treat it as indicating a bug if GCC and binutils-gdb differ for various files - including toplevel ones that actually come from other sources such as libtool - but with neither tree as upstream of the other. (Special-case exception: if one of binutils-gdb and GCC has updated autoconf/automake/libtool and the other one hasn't updated yet, there may temporarily be differences in such files - though if a change to work with newer versions of autoconf/automake doesn't break older versions, it should be applied to both trees. This exception is because such updates can be complicated, so are more likely to happen if only one tree needs updating at a time.) -- Joseph S. Myers josmyers@redhat.com