From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by sourceware.org (Postfix) with ESMTPS id 18F3B3858D1E for ; Wed, 9 Nov 2022 07:21:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18F3B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKjmYrxaY2ccqf7NfSI21yZJ67oT/S7Y9NEYDZrjL49QZr7bgJzgYsHKt5ff3U6hCZCUGEvfC046/xK6hY1jp+XFNH7uYsTPs3SuG1OcZwZ6fF1euOEYFasnfwBpIPkeBEBRJPCnNKrgYcXtoZkpc5Ss/SSnA9yEBxwRxcVofzU2BI62A/s0iAPh60mnqYIi+XStjEGbLIBq90etOsMWQtTW1mFT0X9BbvQXFjbbjFQg+e2mFbtByXiO3qnhzCMOIcOD5JaoP0qdBqTubDS1lJ3LbZoZulZQy4jpAW/dHTUNlw0zOwgCEXsv0KVHnz3+/hKCb2s6C/6LtXzS54BEKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hGmjFFrfK1LMYisnX52/bD/wqaE73KbIknxnlej9QIg=; b=PoR/Oky0YfDDKG/Q+PwpaGpR3jiD5NO2XCAtBLuQEDBTBWhLsHpnYqWcQH6lAshrYWRFD5XSdxCx5lwWga0/l3wmrVfmEKnVlwThU8juzajIZo/UVP1rwK0w+h20T/Ws23J7w+2oR2/3hep6+jgwMk+/AaTcKYawFNU4l3aLNUtMg7lB1JAbYhT3Ab2SWL7K+h7i42r3KSg7hK/6yNOslaSGhVpfMmXY6j7/OilnTYNTWZLqhUD9T4+1a+Fcnw5v2lz9dZLSJTh+Y7gID9fMSndbdzqUaqqVGJmZcHw88vMM2t5FQx+hgieW2qCwFiGQ6h66I6NJvfvbtOksEtNeZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hGmjFFrfK1LMYisnX52/bD/wqaE73KbIknxnlej9QIg=; b=oV3QlGkyRIYW8mxHl9q+bROWh1vapaXfZf49RTy0AUSP2clWwT3HxXqZ+MGKWd4n8CGz7R7QMyrlDM62ICotXV8Wjg51Stnuaz50kVHUtdSdsbGNfavH0GD3sMcKIWU1OpWTBGLzILBdNS5I06dYBT13tigTj5+9e83/wf4b48gO9gAZCa/G5M7xHHUXDBeJgIRvbvk5aLhks9M06+XKRErc59bMFtt0L+GCZ6YtaF2x/XDWj1IfdLsa77N0jbLh+OPQgUBJb+Ld+G1gAKdngoITY528irftacfdacegiMfRB2vQB1k1WBFDJSJAZ8DNljZo0v6xNIOQw+hUqz6Grg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7185.eurprd04.prod.outlook.com (2603:10a6:208:19d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Wed, 9 Nov 2022 07:21:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 07:21:17 +0000 Message-ID: <5e2a1d31-546f-23bd-bd2d-2de39af81ce8@suse.com> Date: Wed, 9 Nov 2022 08:21:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] i386: Check invalid (%dx) usage Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org References: <20221104205547.3728827-1-hjl.tools@gmail.com> <781ed098-079c-212e-7e46-a375c27f5486@suse.com> <73b15165-8615-282a-560f-30049b1963a1@suse.com> <6c7794ee-49fa-68d0-e659-435512da64fe@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7185:EE_ X-MS-Office365-Filtering-Correlation-Id: 6db728dc-45f9-4116-dd6e-08dac222fdee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XMZJyKoEaRrjDOpzAJE4CpsudWP1cTaMOenFhSSyBG0Gx7XJwwdoPg4e4SnrynGnwu3vZaaEF2M3A8B2bBeuIomTAwKXD13wJD1VKNMNmkOktbX4ghqWZtYNA+HnqZuaWD2QdKsxstL6oR9aVvo13n6sNVZSKmvnsOS7YjbmLLiq446W2KtcL6xbb5pVWO2BwhUpGAeqD90ij8MMmiZPZMdu3gSkL2oxYpOIN8gap5Z0yf8a6Q+8fbzPasKVoMA+2V76e1burDbe+E7VDEREex3CAWWNC8hYbUTlM/D1IhFT6Y1GXWgcsrjsepIP6jFBDb832k57pPnzj50cEe3lk/qNQNu3GOWoUy+iFBjP/ubqJWEDTxwYFfiyEm7quIdItffND5tn+OLsdVfHzqnXfaVnr/EoiMXMfaruc4ILcMMqkOOZuCwzT4/0Epxi8YCDOuB8W9ikF9nUSiPx3j08swLkKJ94qEXkoc9xOK2ZiL/DtLBEnqfBjY3AHnryqZDlFtWZMCiMWL6A38GtLCb7s4k3dF7pjHVM22TXnHqtWXDyJGs43NAGLnP81YmjhYBTCsI5xddzjP+6da5xtCy2alrWEQaFtCxSVpx8mpICSe07FLU9UkG6smj0Jherr5zVF0z0SEYIvvWCOhUa6ryWw/gCTEO8Au42PhMqCJBb8E4ZAZ3nVulSqvEVD0p1TMBNDPg4nEdk4n38vTzBViNPrdn+Ku2AZ2wTwyC/9x7oomDTgOrlG03QCZFyHc9QI8OeULBnwc80kxsrnuYfqQqI3cNpdsqjCCiGGCnAXVf9nJw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199015)(6506007)(83380400001)(6512007)(5660300002)(38100700002)(26005)(53546011)(186003)(2616005)(2906002)(6486002)(6916009)(478600001)(8676002)(41300700001)(8936002)(4326008)(66556008)(66476007)(66946007)(316002)(31686004)(36756003)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkdIemU1V0V3aXpva2U2ZFJtQzZyaHJ6cnJBajJqbitFRzhmWDlqOG1HaTVt?= =?utf-8?B?RGZFSW5LUk1mb0dhcHYzeUZFQ3dCa3dYYmtYZ2c1YVNTanU3d3VyWUVRclJV?= =?utf-8?B?d2pYc3NaUmU2em91VEN6TFh4eDFDcklqemJwRlNEQUd5N3JwMU9NUGY5cW5M?= =?utf-8?B?OW9ydlZ0bVZWYkRKcENqdmhXK2JSQzBKOTBxVW5aNUtsSHViRkxneWZsVzBH?= =?utf-8?B?SXlJSFFzeWlsRFQ4L0c0bEZSRzZiMGRkWTloVkFvUFJGdkZTemM3UTFHZkF6?= =?utf-8?B?Vy91UDlWYVFDMFJHbFlRY1lNZjgzWHhWRzZSM2JRajVudHRsOVViMElYaEZW?= =?utf-8?B?UVhTVXFXVDlQZDJPWVplWktKcmRFVlRkT0hZblNmT2JvSmRpbzV1V0t4alFB?= =?utf-8?B?NFg5c0ZXVHFORXhhaFRsQXZOcGlnT00xUFdSV2NGb2hSS1VUL0hibmhxQVFH?= =?utf-8?B?RWtkS3lyNDBiWUlkeUl3czdIczJVMWZTeS9Pd1ovUXE2bHJmazhDY1MvYUVG?= =?utf-8?B?VStsTVp3SEg1dzdpYTNaQ280eWpJSHdjd2kzYXlWSlVGN3NtWHpTd01VNDR4?= =?utf-8?B?R3NHNzBnTmRHTFdocVZSd0xIN2RWd2VPVUwwbHZVTHJLNmF2UWVLQVNYVE5h?= =?utf-8?B?d2RVWW5XNG84MCswU2VzNnJkeTBsSlNOam5LMEphNnRIcG1PcEc3VWxocVBt?= =?utf-8?B?bW1lbU1ZWmxrOGMvQWlBT0pRWU5COEc5c3Q5VUZ0c25oZm5uMzFqR3FyM2pL?= =?utf-8?B?NU9UNnUxM2dKZC9lZERFZy9QRVI4TDFPeEt4akZRS053eWZlaUh4Z3NDOFdR?= =?utf-8?B?akFzenNwNHBmc0xoWWNoQmx2RFAzOGMySFRSeHRhdnF2dFZFUDFqWkEzdTZl?= =?utf-8?B?WkJ2UDlFM2V4RmZMbVZWWFBpQi9pWnE3c0NtMzk4SUYxWk5FSE9MclgvV2NO?= =?utf-8?B?MjljaG5qZ3Y4bHBURDNtQ3BHT3EvY0k2NXR3UjhlRlBUQVVlRnBLY1ZBUUhC?= =?utf-8?B?OEhoVmtiSnBDMElGd1F3VFVYcis0dUR3ZkdPYnJQNjdxbDNyNzdmK2d6dzBl?= =?utf-8?B?ODI5Q2x2VVRGNzkrbm5pYjJGTmRIUnFKQ1ZpVGViVzcwaS9tY2ZmaHJaVURJ?= =?utf-8?B?THNGL3hBTU1NdHJmL3dWRVBaek50L1Zsek9FWEoySnpmU3ZiQ1NGVDB5aHFG?= =?utf-8?B?NlUreG8xM056QnNvejFrcGVSY2ZHZnNoRUQreHdSNk5ncG1xQ1RzN1FEOFpa?= =?utf-8?B?SnNlVFovNWk1VzVlanBEWGxQbU51ZHlOam9aL20wTzRmRmVHUXFIUmVlMDlo?= =?utf-8?B?TzlaVW82MVJmUFg3T0dHZFNSWGR0aXozaWJVZldBRkllbytSalV2SjRrQkVW?= =?utf-8?B?VVV6R2JZalZjZU9iVC9pbjdDVmtWTjlQUlM3OXYrV0gvT2NYQUJPWjdVOHg2?= =?utf-8?B?ZjdKVVFrWTM4djVDWEd4Yjg0YnVsZ3oveEpGZFVVbEp0d3VOaEhpQ096TjIr?= =?utf-8?B?dkdhc2VOZ2dzd2REK2UvLy94U2Rrcm9sWDZZYkR2WUdTWTVrbUU2Q0kzUTJY?= =?utf-8?B?MjZRSTkxakZNQkEvWHRoNFV1ckEreTJoa0d6ZE9CQklLdUk4Y05aN0NaS2ZF?= =?utf-8?B?cHhXbmN0YlZ6RGtTWFI4SkxEMWR5R3RRM1dqTTdMUkpMaGxyWXB2b0xLaGFl?= =?utf-8?B?eHJ6SC9mb1l4cnFDaXQrWGFIa2pDcEw5YXo3QzZ3cVFGclBwV3VsaUxhcjdE?= =?utf-8?B?S1JZMzh0NldaSmpybHU0eG5acmRoZXNYVG95dE42SllQWVRKUEFSRGcvd1Qw?= =?utf-8?B?T2lKUDNLeURRSStDcCsrdERRbS8vczRYd21TVjd3VWc0MGVxSFR0RlVrTzdm?= =?utf-8?B?ZmtjUjI5eW0xRGJsQlNUSEJSQTlITGFUQnZYaDJMSWw4Qk9XNXgrRFJqeU9Q?= =?utf-8?B?YmFYZ05nbUJEb29ISjU2ZDNnWGNxZjN3bUowVTdtV3VxUmh4eDkydTBoZ1ZQ?= =?utf-8?B?SGptMFVqeW9SZ2Y4ei94Z2ErazFNNkVXRGF2dnJ1N2M4UjQvalQ1Q2xqN1pR?= =?utf-8?B?WUNNOGhsbWJPT1NZTXhJaGpBcTVIQThpNURvOWgxU3pxb1VJOGtoSUZ2WDRa?= =?utf-8?Q?3VZf/u3nbHTkVjNh+Da3/8Rmv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6db728dc-45f9-4116-dd6e-08dac222fdee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:21:17.8812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JebeVX2jhgDDsYclR8kJwNa1IiHE+T8ra3VadPPvq1zy64QXr0FJzlSGTqvQMbQryvSh4idzQksQvWdiWTKjJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7185 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.11.2022 22:06, H.J. Lu wrote: > On Mon, Nov 7, 2022 at 11:34 PM Jan Beulich wrote: >> On 07.11.2022 20:58, H.J. Lu wrote: >>> On Mon, Nov 7, 2022 at 3:44 AM Jan Beulich wrote: >>>> x86: restrict use of (%dx) >>>> >>>> PR gas/29751 >>>> The AT&T mode special case operand (%dx) is valid to use only with >>>> instructions nominally expecting %dx to specify an I/O port address. >>>> Prefix the respective checking with an opcode check. Keep that as >>>> simple as possible by recognizing that opcodes 0x64 and 0x66 (which >>> >>> Since current_templates doesn't point to the matched instruction, >>> checking current_templates looks like abuse. I don't think error >>> messages should be a concern here. >> >> We use current_templates in similar ways in quite a number of places, >> when match_templates() hasn't run yet. > > Since the first template isn't the selected one, your check allows > the invalid opcodes. I guess I don't understand, but I guess I'll also give up. Which template the check is done against doesn't really matter here, as long as it's one with the correct mnemonic. We could of course also re-order templates to have ones allowing for %dx first, but I view any such ordering dependencies as fragile. Jan