From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2056.outbound.protection.outlook.com [40.107.104.56]) by sourceware.org (Postfix) with ESMTPS id 2FE8B385771D for ; Thu, 20 Apr 2023 09:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FE8B385771D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rm8wZ2+dP7g+9/6ZFJoLZkUTTUgeEk7Y2mT8Y+9hZVsl3tsgyx/wjQRNpUi1yy47QNFyqbeRf20qT8E5hnIozwhwz4c7eYLy513BjQGGAzUzMDpIGWxq3uiFXBjLQ2tXjqUf4IqL0ALIbnXiHW/thz+dGayJNxD/xVDU7TDYUd8rrNM0ZmzkrMTvC2oIAFePdDwnjFCrDBsFCaGXFpNeRdKzQ9J2Y0z7Jc3mUWQfysLD42We7C67JF73D2wVu7Af7hLSxq/WT/eqdzWpCXsWaHyzjUdVe8spaJ1U6ovOD5oQGTAh9h1nwHicFVPocSiRkB5JcvG5sLUEc0mriGlDpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BubMvaXGvHi+86hXCvZHNQeSlITuh9ePTbGNZzw+dR0=; b=i8WS3Zj8Pzvb6dobQlbf713oPZMdoVsb9bOnYX4AwJN4XVw2IVYLvSEbwNG4FXVkI5Wbqjorr3jad0ihmd55JI1ShVWRdjTLXy/ZLU9x2ixxGuLJinF/l98GbXaPfCg97+SpDe1E2y9RS6S0sf9N4/QbCnH1yG1C5HKr3K7s/UsljmP1hZI2R23bGJb1z+eSsOapE6dj3GMo6V+FknJOJnYhxJkXDd0dguor6H4DAWRmScJGx88OWD8M5eYc8F+9qAqi4/nyB0TuDrYDMdSbooCk889kZby7nr/UzuMaWWG8pnJQr0mqh0mmRRMT51DZHRhCtjOTT23p9lHc8RfGyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BubMvaXGvHi+86hXCvZHNQeSlITuh9ePTbGNZzw+dR0=; b=Ko46S9RY6sEh/QcrsoTcGKCT7+08V5NTQ7z3ZMXYeUPs+PZ2AzHyG7hv8LoscUrAyK1b6uuJrv3AYTUe8fvj45wsCSHlVojbf+JumU2fLsWkZ+k3OOAvkRkHqIdaRfeIY+c14bo1HkI/IbUMlr7mt/sgj5yjmfXf9VWnLcStNj0cPKyt6I6GhzjOJP3S93L4VbUDKBPXNwFgNnBVnfb3PSMoBAkIUkhmJDw3SZJ7xfrzLPnENsjHgM2yr9IINNMfOgDmoTk4VnXp5Y5wrNq2SKZvsDiyP8cPfjm+9C1v+V/lZLvIEDCA+nT6K8QwlxKfuZswtrfrL98GFJgDMi25ug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7885.eurprd04.prod.outlook.com (2603:10a6:102:ce::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 09:19:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6319.022; Thu, 20 Apr 2023 09:19:30 +0000 Message-ID: <5e80c8bc-07da-fe6a-c162-ba830f56aa49@suse.com> Date: Thu, 20 Apr 2023 11:19:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 13/14] x86: convert testcases to use .insn Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: Binutils , "H.J. Lu" , "Jiang, Haochen" References: <2b0ca132-9d85-86a8-8b91-828fa66881b8@suse.com> <15454510-ffe4-7afa-6151-f918983769a5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7885:EE_ X-MS-Office365-Filtering-Correlation-Id: a11d1c79-0c58-4b4d-e619-08db418058c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 691VDcIdbKYkfuJ6n7MWj0sboIC5cXTgS+PA2BFIcy3SKdkWbMj/8JRcvWwkdzDWKt8JhQDXBNjxHHarc86JNSw+Rjy81uxR7FcAaVktx+7QXHPTvJakVdV5Gcjz7yN6QAgIDrnaK+Ns4n2p6vnOMlrD76cMfQ/n2kw4/gjMJmegTBpK5Lx6SAxL4wFkmm9viW8PyI1s0dLp5y0anvswzSODYncem92UtEaLvwE47RveitV8pALeuN1Pph6ZzDvmMoL24tC8UK2etau1dNUnernTlTHKS8UtRlR/cbUwMy62hatntcGB6HyZFIbANqa6w0L7e93xgPo68o4AdUT65NZ+40X6MWYJRa+hPitanj/yJtDgJ5v82KzRktCgbYXJwDYzuETKwsKbL8JV/cIM9smoUWlbfDxnoa+vguv1B9ZDNDJaYhYfxWZWLgsPiVhP+dCpatJI1APWFLCFNIgYnZWUnoCPBrZwbRryjKLFhr4VFz1ATPqN7jMz15W113bVLT5u/F0P7qXu2xpPrMjQDCTNP2ZXSSj+ZxkpxgTFSIksMdQ9dxCrNisSE2uyihVBzkBLNA6zsipZsmEd4i1ztVuTPib+CJz9+TJ9sEJZDP+X7MSvmLCXpCLLfU7Miz9cJL4ZE+VxIX1wU1ct/LsZbhAU6zHcE7FGDV6IL+KXevw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(36756003)(6916009)(4326008)(54906003)(316002)(66946007)(66556008)(66476007)(186003)(478600001)(6486002)(8936002)(5660300002)(41300700001)(8676002)(2906002)(86362001)(31696002)(38100700002)(6512007)(2616005)(26005)(53546011)(6506007)(66574015)(83380400001)(31686004)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUlPb0tYS3lHM1Y4eE5IWm8vN0Zsc1dadWlrSzlHd2tiOEdSTEh2a2tqVGJz?= =?utf-8?B?MVJMM0V6N2tJZm5CQWZpZFNLRDZVYXUrQlFpYjRRaFdYU3BNdnZqYjJXaDAw?= =?utf-8?B?VzIzMi9pcG5FaDBoaktieEFxeWFta0lFSWlMMGZwY3RhZUF0aEpFa2dtMXN6?= =?utf-8?B?YnhlTFJ4YXhLMHdxZWVGdjZ1Uy80TXpqNTJPbFNYWFJyYjVQVFRveDdHTW1x?= =?utf-8?B?em5mZFdXZXdpRjRIMWRrRkt6Nk5YWi9oVGpubzBoRjkyb294MTh6SnFyT082?= =?utf-8?B?c2taQ3BJSWVISDNUN0J0V2NmY1BEWDNuVnZPdm5JWEZPTE8yZUZUVHZua0dX?= =?utf-8?B?RzJHSDFQdWppVC9VWGpmSTFJYkZhMFcvck5qck8vVnU5L3NOM0dCaUVzOUZV?= =?utf-8?B?ZjFtMUVmRU9YZ212TlVHUHZFanNsRm9heXhXNCtrTXNGM2syTk9ETjhmY285?= =?utf-8?B?YmlPR3JkT1VFWkV2RnRkVHQrays2cS8rbU1KRWg0Z0NhNEQ2aTVqVDd1QmMr?= =?utf-8?B?akRxYVVzanNwczB4bzd4UjVveXl4VzRYK3AvVGRFenZ0QTdGUC9Hd2M4Z3VH?= =?utf-8?B?WUJ5TTFHWUMrZXBheUJldUU4Q0RYQVNMekMvSFA0UGVvcW0rZnNFc2NNSGlF?= =?utf-8?B?amViZmJwWitaakZMeHluZVUzV2VmMHkrMk9pcWhDd3R1eUg5b0lhYzJpZkxk?= =?utf-8?B?enZPY1gzaHQxbUx1ZE9hbzFUTkRCMjU1Q0piaFZtWGgxOWh3OS9HSmNJVFVp?= =?utf-8?B?OTNTaVpOOGhGZGZWVjJKMS9DYW5iV055OG5yb0tFMWplUWhQUW4zYzBMOVJh?= =?utf-8?B?YWpON1BXYlk2SFBHZWoya0pOT0lFRnlGL0hQaWVXLzdSaVphbVJlamlva3ZM?= =?utf-8?B?YWRjMGFBWVkwenJzeEFhNW83SVE3cHdCUE5PUlE5b0o0d0NQUnFWRHhqU3Fr?= =?utf-8?B?YWJPRjZBaG9heno4WmU2ZTNFS1NGNGhMeFdNNUJpS2N0UGdTalZjS01HaDBj?= =?utf-8?B?Q3BmWElOc2Y3OUp4b3R4NnNtWk5veEhONk54R25iaXpRbGRid0RmeUs4ZGNY?= =?utf-8?B?OExNNHIzTUx0c3Uvd3U4bWhYamg4S1ZYR1pQbnNjaE9FNVlNbE1iY2tQQmpJ?= =?utf-8?B?SlFaajYzN0RMcWhoSm5tN0lWeTRxMWNkUVVrYkhrNG1GNENXbExkVmNueDlu?= =?utf-8?B?Q3hyOWtPK0lpUi82cHh0bkdqTDJZYm1hNHdUdEJxOU1VY25NQjhKV3IzVXc0?= =?utf-8?B?bW5xUWVibjlnZVAxQlZtWjJzLzhDN05YTy8vVWZHVk1EL1FvaW1vZHpFcGNi?= =?utf-8?B?aDhzMldBSk1QODUra0VwOTExUFU0YTRqMlFMcW9jOEExbVZpNGZBdUhYTEhz?= =?utf-8?B?a2RMUHUwTGYwZ0wrK0o0di9Fa2t3SUwzOVhTZHU4MHdaYlJQU3pLbWc1b3Y0?= =?utf-8?B?NjZtZlowSG0xYjhkeWUzMWJUQ2tBcThKblplTi9yVjRiS0pZamJZcEhBZWVr?= =?utf-8?B?czFmTFNBQmlxY3A2dGg0RDEzQ3hDOHNMNlcxdFZyS2R0aktMN2dQdEtvanQ4?= =?utf-8?B?aWRzSjdhR0ZDRlVXMTdqRHdWZTFpN2Q2bWFDcTVMbmhkbFhCNDBDOGdtUi93?= =?utf-8?B?MmRkMEQ1U2tNOElDaDN0ZVNVektxdUVNckFPTjk5aUFoOFNzcnB0RlZqaEx5?= =?utf-8?B?dTdtYkNrMVhBcy9aMTF5eWVmenFHSDVCRVVMN3RvQUxDZlN3YklkV2xkWDJJ?= =?utf-8?B?VDBLRjl4SisyL2ROWWc1OFZacTBiSVZCM1FZeVJOSllEMWNmUkFxc2NJNzdD?= =?utf-8?B?ZUxFZS8xR1ZCN2ptTm4xTmR6OWxaYzFXZWcwdkxpVkhUUE44bmV5U1Z1ZE1X?= =?utf-8?B?VUhyZzJvbmViUXNHMDh6clhiYjRYM0J5S2VTdXEySVI5enQ1T2swNHh5Ykd1?= =?utf-8?B?Q3FqQ00yTEM2M1E1a1NPbEhCa1Zaa3BrZ3g3bk9MeHo4SVpjeXlJdEpmcld6?= =?utf-8?B?TTB1bkNJTnlVeGsyajNLZTZCZndoN1N5MENJWHVaTkRuaXQyNVFkbnVFdy9J?= =?utf-8?B?QmtOMVNudEVQeVl0K09OY08zUGE3RmUxZ3krNng0K3N1N25rMXI0L3U3ZURl?= =?utf-8?Q?w3PZuEg1daIIcEFyfSGsrN2UZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a11d1c79-0c58-4b4d-e619-08db418058c0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 09:19:30.5353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gzccp7S7fnK44If1rtBx5bH5jQb1fAx8yRj3eY4yWWi7GbH7FLZJ43LNdZwHqQiTEGGIGWYgMXQ6cL1RWw/2kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7885 X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.04.2023 11:09, Clément Chigot wrote: > On Thu, Apr 20, 2023 at 11:01 AM Jan Beulich wrote: >> >> On 20.04.2023 10:56, Clément Chigot wrote: >>>> --- a/gas/testsuite/gas/i386/x86-64-opcode.s >>>> +++ b/gas/testsuite/gas/i386/x86-64-opcode.s >>>> @@ -458,16 +458,16 @@ >>>> int3 >>>> int $0x90 >>>> >>>> - .byte 0xf6, 0xc9, 0x01 >>>> - .byte 0x66, 0xf7, 0xc9, 0x02, 0x00 >>>> - .byte 0xf7, 0xc9, 0x04, 0x00, 0x00, 0x00 >>>> - .byte 0x48, 0xf7, 0xc9, 0x08, 0x00, 0x00, 0x00 >>>> - .byte 0xc0, 0xf0, 0x02 >>>> - .byte 0xc1, 0xf0, 0x01 >>>> - .byte 0x48, 0xc1, 0xf0, 0x01 >>>> - .byte 0xd0, 0xf0 >>>> - .byte 0xd1, 0xf0 >>>> - .byte 0x48, 0xd1, 0xf0 >>>> - .byte 0xd2, 0xf0 >>>> - .byte 0xd3, 0xf0 >>>> - .byte 0x48, 0xd3, 0xf0 >>>> + .insn 0xf6/1, $1, %cl >>>> + .insn 0xf7/1, $2{:u16}, %cx >>>> + .insn 0xf7/1, $4{:u32}, %ecx >>>> + .insn 0xf7/1, $8{:s32}, %rcx >>>> + .insn 0xc0/6, $2, %al >>>> + .insn 0xc1/6, $1, %eax >>>> + .insn 0xc1/6, $1, %rax >>>> + .insn 0xd0/6, %al >>>> + .insn 0xd1/6, %eax >>>> + .insn 0xd1/6, %rax >>>> + .insn 0xd2/6, %al >>>> + .insn 0xd3/6, %eax >>>> + .insn 0xd3/6, %rax >>> >>> The test is failing on my side when building with --target=x86_64-elf. >>> I'm not sure what's wrong yet but gas seems to ignore everything after "/": >>> | $ ../../binutils/objdump -drw tmpdir/x86-64-opcode.o >>> | ... >>> | 4ea: f6 f7 div %bh >>> | 4ec: f7 f7 div %edi >>> | 4ee: c0 c1 c1 rol $0xc1,%cl >>> | 4f1: d0 d1 rcl %cl >>> | 4f3: d1 d2 rcl %edx >>> | 4f5: d3 d3 rcl %cl,%ebx >> >> Right, and I think I did address all of these issues (there were more than >> just here) in what was committed (and in fact already in v2), by passing >> --divide to as. Can you confirm --divide does not take the intended effect >> in that case? > > --divide is not passed to x86_64-opcode test. Well, you continue to supply ambiguous information up to here; it only becomes clear ... > But adding it resolves the issue: > | $ ../as-new --x32 --divide -J -o tmpdir/x86-64-opcode.o ... here that what you mean is the ilp32/x86-64-opcode test (which is a clone of the x86-64-opcode one). So yes, I did overlook the need to add --divide there as well. Jan > .../x86-64-opcode.s > | $ ../../binutils/objdump -drw tmpdir/x86-64-opcode.o > | 4ea: f6 c9 01 test $0x1,%cl > | 4ed: 66 f7 c9 02 00 test $0x2,%cx > | 4f2: f7 c9 04 00 00 00 test $0x4,%ecx > | 4f8: 48 f7 c9 08 00 00 00 test $0x8,%rcx > | 4ff: c0 f0 02 shl $0x2,%al > | 502: c1 f0 01 shl $0x1,%eax > | 505: 48 c1 f0 01 shl $0x1,%rax > | 509: d0 f0 shl %al > | 50b: d1 f0 shl %eax > | 50d: 48 d1 f0 shl %rax > | 510: d2 f0 shl %cl,%al > | 512: d3 f0 shl %cl,%eax > | 514: 48 d3 f0 shl %cl,%rax