From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 85E563855587 for ; Fri, 21 Jul 2023 22:34:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85E563855587 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36LMObIA016762; Fri, 21 Jul 2023 22:34:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=VV5CF/bRnfDxlsUFfGUxZOg2kVTihDqRQxFwx40RSng=; b=cvzM/NqNwJLgRA/X/LmMRB6adPqNUdOqHLdvaSTm+YLVWqeMIorb4W2nJanadCm2Eix+ BlfWcaoWffV4wawloNLEpTnyTYOGqyyf3c9EqU/4SSSdVuSIxatweNoNbS7YJiV5EUz4 u5uThWzyb7EJD156PX+Z57u+r6r6g5zbP7odlLT41GTG0sNq8fZBV66NblDb8AkIiUmy 03wZyv9qCrI8hb49y7wl6P4KLTtDY9HsgLPTOZjnXtoycHHMOHi26pggdxW0F3Qz4OzS iXDSBi3iJdAALIkd0sr7PUKESdL3RAD53iHNHShiHBWn4+iyddW1fpcUOEIbWY/IN6Qd WQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3run8acwt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jul 2023 22:34:57 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36LKGhwn007843; Fri, 21 Jul 2023 22:34:56 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ruhwab6pa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jul 2023 22:34:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jY2iOTeu17Juf17MDHtoT5hFpbe6thJgVY/tDeDD242PE15vGJbbNV9Whk3fZnxYQ4h0vHJ4vnPQVpi17C8adpDuTwDbXE2Kr3UFtetl86TKjaM7rUfJi5r1QUH0FzjZPzM6teQ68wnqeiVL/UtxN6XPQzeEsOStwKHby9EIS60Fi6hoC8bteAl3VrQ6HIqwq+U+m6s4NsnxQMgIgJygc/SVTgNEfL9KV28GZnw01CpsluGKwJLeCxotYqJjVZNP0jHsRGzZgRbsibCkRO3n0KwxIeIRgSKzUuzKQai1EwVG/SboR9djkg+Sa7L8YktTRyzg6y70U88VtlJrxgXmWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VV5CF/bRnfDxlsUFfGUxZOg2kVTihDqRQxFwx40RSng=; b=es94ARwvHH3K0wKAazElozs4WepZpmZ2gN+p8WVQrC0LAkSdhkkPbj4UK/H/ddE2uKndrvXVylnFnkLmZB/GJCXlWqi2XejW1zTdTqzRW04PDgCSxQCSj8Adb2y/Y9WMUhQ+mf/MfK9zwNBfJdAO4ISyb+l+d+3eRU6O7+y2UEq6XF0uY+koa/XzHXjSP0zt9vYGI1qo/SEXz3LblnRj5IW3CygHk2JE7Acyy9Yu9qVb7H7dqfICsPQVQzLCJ0o0Gtx8CkMHUvdvvTsESlAmzFE0lLofkBVdN11SLUJLin5S0GAhKsP8kVJd2XR20LJsGhTHU116mf6JQQfG8JDCYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VV5CF/bRnfDxlsUFfGUxZOg2kVTihDqRQxFwx40RSng=; b=pLbJ46dAQl9E+PVz5X0/bnxizulrpoKn2JNgVB7W52hAhWbVcnSrskHuboldZC2+rR60tRZU70XE5FzgN4VSvorEabA9WDuU27FhZMIhuwSobsSNb5cWQW24+i75wQLnf4xnYoLFSugEKcbmU9WounE3qeys0I8r69GyHireOGg= Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by MW5PR10MB5828.namprd10.prod.outlook.com (2603:10b6:303:190::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Fri, 21 Jul 2023 22:34:54 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::827f:8665:2052:16c5]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::827f:8665:2052:16c5%4]) with mapi id 15.20.6609.026; Fri, 21 Jul 2023 22:34:54 +0000 Message-ID: <5f2744d4-11a7-fc07-a0d4-0b360e72b7c1@oracle.com> Date: Fri, 21 Jul 2023 15:34:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/4] opcodes: use CGEN_INSN_LGUINT for base instructions Content-Language: en-US To: "Jose E. Marchesi" Cc: binutils@sourceware.org, Jan Beulich , Nick Clifton References: <20230511141351.18886-1-jose.marchesi@oracle.com> <20230511141351.18886-2-jose.marchesi@oracle.com> <874jobm4x6.fsf@oracle.com> From: David Faust In-Reply-To: <874jobm4x6.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1P222CA0181.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::28) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|MW5PR10MB5828:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a66134a-6ed5-4993-4731-08db8a3ab479 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +vtQbxKkbsqPHeG5b0innlDiKMxoX76UAIP683AxDkS1aQpU91NC0k8FA2dmccHd9AbjASa09f+47p5fYJrn/dSXTaT3OzSqkJRkaB+yslHRwyjCJckP91cbxp5UF6pfEc1uM/aR4J9feNQ9dnvwbFYxOrGEUgcJK3K/6glMQ3kvMyV2mSAUv1G0WvTShCfAJBmJu4XoLJ/zbHQI7rCmmt2vQB6KdLnzoJsBKog50nKBvQIygnzWT9f9M6cZWGozvOjBlwxr7U/b2RVFt2lTN0W8+/rX2djB2VOK0SZOWH1I4kD5pBGZy457PST4jMcJ5lX23drJjxi6OkpBaVf4CWDy5BHj95qbqst3E6DCiLeCZTySezpzZThmPzr2pklAenqBT35awqsY8TmIoj88qKuLcOtfUoDRgVqZeDPwC5IyySNy3X6EkvrBDAdYev06aNPO3YuucdfGgJbicDYs+qFL04pQ1dX66bV2NBQnD7UjlzqUtHW6PHJenoBwh9YkxhibNqm5lu2aGj/3YYmKC4W7DTru4kB/hHMQCyWmYERsDmNEX8eK+JcbMNq/IDpEynSrOCQQbhiLFjeuIlRAsPxMtV/MnGxHKaAl08ypHlIEQiUYS0ZpSbxQURU+LtOR83tiWtG/E51p3gevr+MG2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3213.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(136003)(396003)(366004)(346002)(451199021)(31686004)(37006003)(6486002)(478600001)(6666004)(54906003)(2906002)(86362001)(2616005)(31696002)(83380400001)(36756003)(5660300002)(66476007)(66556008)(6506007)(26005)(44832011)(53546011)(6512007)(186003)(38100700002)(41300700001)(8936002)(6636002)(6862004)(4326008)(66946007)(8676002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlJRam14QlRRNHJ2dHQvNVNUcWxWUEkrVGR6Tm9OMHNOZDBYV05zaVVycWpS?= =?utf-8?B?c3gweGw0dzB5UTZwbmVzZ0N2K2t5VjJFRWc3cjBmNW5PdXRPYkFaRCs5T2pY?= =?utf-8?B?QmtEUlpMdWNrYkl4RWJFK2ZkdkV2K0d1UHMxNWZSaTJ2STBFSzYvbVpSS1Bz?= =?utf-8?B?NkZWc215Yzk3M29lL0JMT1d4MzNZeXZibkNMY1NhdnRLRCtSNUFUTVpnZzl1?= =?utf-8?B?R1Y3OEVldHRTaSs4SGJtaDJhbE1zVXVvd245TVJhZi9DVjRCNE5lbmNaeHFI?= =?utf-8?B?bFJTOFFDc01namNxWWx2akJNVzRuc1ZsMlZHL0Znc2cvQ3dldFk1N0gydnhw?= =?utf-8?B?c0RQaitaYkZuSFBqRG81cHhuc0p4U2tCeU8zZnBSM05QcjR4SlZkMXVpQXM3?= =?utf-8?B?QXpCdTlockNFb0VEUlBVbTRnNEQrREkxdG5UYVROcVRRRk12YnJESDJ2djVm?= =?utf-8?B?V2s3a3RTMFplenZ6N1M0UERnTHBZT1Rad2FtSHpDWVl2SnJCVUloMGNRTys4?= =?utf-8?B?SU9xNGlKbDlVR3FxMmFpYW9GNGltNEcxNVdhd1RpdGFZallWUnBIVys4NUpE?= =?utf-8?B?OTNMTi90bDlkV2VqWFdSeWJCR2JNeEMxeHhPSEdFcUJzcGRTNXZLUC9idTZY?= =?utf-8?B?YWJoUUZ1OW9EN0wwL2VOZjV1QU1mQkQwNVdWQ0ROTVNMOFpmejNia04xUGlr?= =?utf-8?B?VnUvZFc4SmV5bHdCZlVuV1llb3VFcy9zdjlwNUY2M0RSbTdIdGdjMXloalZo?= =?utf-8?B?V3hOUFBRUHF2aGV3ZHlEUXI2Sks5Mmt1dFhGdks5WVljV1kvc2J2aGZacHpB?= =?utf-8?B?MXBhK3lZS0p4U3hrMXFRRmxQdE5yV3FOL0hCVG9GcmthNU5GbDdjR1IxaTZ6?= =?utf-8?B?Y0F3V21qT1VDallML2NvMFZiZ080QkhWeVZnc1pmWmxiL0ZIdFJhNm1sU1lS?= =?utf-8?B?dngxaTFIMmVURUZNYkR5OTFQeXVJVzVVcHVTdXlmdnN0ejljS2ZYNnlEMnhz?= =?utf-8?B?RHVPSyt1cnhUZ0FYUDZtNGEwdmZMeGdTajkzY2JwNU5OaUsxZkxLOVJpaVB0?= =?utf-8?B?UWVDNHNLZStOSVFYS3h5STVlUVVHZzdvWHZXeE1BQnJ5QUtpbkozZnVnVmVF?= =?utf-8?B?eGNqN04zemZ1SXpjbElHTHJ5SVlUZFhTSDZDSkkyd21OaXJwRUlqdDkwVkNx?= =?utf-8?B?LzMraENtNEg0Wm9oQmZJRTg1bDd5bjd6UnpVQWJsUlVjRmptWmQyRUVkRSs1?= =?utf-8?B?SzlUaTRHMGdOUzgyeU5LQXRMMzJaQWFnOUpyTkhZS0pScGVrODhibHdFZzcz?= =?utf-8?B?TmY2TGlvMk9PbTRoeUUvZlNLZnhzbGFBci9MSDRMMnlta245Z0tJczdSQ3dE?= =?utf-8?B?YnRzYUFwNkpCWTYra0s4dENoR1VQZ0RNT1RNTlQ3MGV2UlVidHo3RDlrem5q?= =?utf-8?B?YS81ZjU2WUR6cVFkNGk4RTliVmNadDFrVDArc2IwWXp6bUJ0N0w4NjVqMlE4?= =?utf-8?B?Vk1jN2NOSUNOcmhhU01UaDZMRkV2aUJ2MXZRWDdNMXQ4c2tYNGVwcnlwWmla?= =?utf-8?B?NllQUk9KQ1FZa205R0NrOHZmajNFV3Q0OGpkNE1nL09qREVMbEFiUFptNCt4?= =?utf-8?B?S0hUNG1EY1ZocnhiMU9LS3h0dWVXbERZMG9tZ25ybTdycUEyc0s1VGxMc1dj?= =?utf-8?B?SHZsMmFUY1V5bHVRaHB5SC9tVWtLbEFCNVRpMU0vbEtwbGZwT24zOGMzaU0z?= =?utf-8?B?S00va1BSWXUyNGRpT2R4QXhnd1lvRkZTd25RQ2FKZkJyekQ1RmRtbDdvV1B4?= =?utf-8?B?UHFJM2lsODVvVXBPdzV1ZmFDRnlBQUZZZGRKUUtqQWZURXBHbzhzOE05bHJ4?= =?utf-8?B?TEJKWi94L1ZNM3NJUXBUSDVZZWNiWnpZOVk0WHJjMTE2WjFFcVJ1TkVwRzBy?= =?utf-8?B?OUo5UW0xQUJLcVphQk9WVk9sYjgxbmpnY3hhZHBTWFB0ZjJXUUlYeDBQTG1m?= =?utf-8?B?OTJFelh4WG0xZVZiZU5IU1hncHV4dHQ1UGZvdS9vdTd3TjFGR3N2RTF2R3RD?= =?utf-8?B?M3Z1UjcwWUZBcTkzdmxKdWZ0S3ZzZVE2bVpHY20zQ1BoRXhVNmRHcC9RWXlJ?= =?utf-8?Q?M6GT1SpnEXYb7dpHKdhriN62A?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: h+OcfWyNik3Zoo2pi8qfuv8f6teD46fyrBt7e5MD2y7zKy+7gJF2oDuhIrkitUO2Ni93NiKOXQKqNpZc/6blqXnnYtuHt7MpOJYNR2vIwyYD2TCdWQIl/b+UKW5vdhjtyxuhFJEgMlunsgfc1r94EpNX+U6NAfSSoTg9ylpZPSiIE3ss45CGwCkzK/UpvszVFR8NCnNJiIzSyoCVyOXzcxj5XOmETyNx8FuQgaLmx/Axq+RYpCyDOflhRKxlXcaU4iv6acjSSp08Fke01HNxW7xRuQFxYwGM0AxXYKpHmqBJpOKMRO4SohMCYcavKK/VQ87Mh9JdnMhsP0jrW3IDtAihu5kkT7go2bbaNtGiHNJLcehzQowXtEoG95TDbXCv0Gcv+a7yZ6Mrd4dqXr129+3czvTm7b8PpsHunvWKfd53eIMTg3LFhOo2U4WuvRK0jXhgPPkGTO4wUd0tvFCSTWgqrmU1u5cRlBiXsR5ViY17I38QiP1+ebj4gjYJW8geq4qrPeBBZ9QDtfLd/UcSeD7oJS1lDUO0cmNcl+bPz4m14npQ+0uKKT1mspgPrEZ0HZ4KmhnX3jPk+QPS7moKGIZfQzi8NQFmJqLVgrX2rk+jVs9RHUKHHe40thonkP0QfnLJ5qnlF6kuOKa/a4PNWfYSJKl+d07aYbQ2tG1vikNTvtSicaqoQa097i5sEeP3kwKtjemeD1OGorO2VZlzXJsjlCvry1Kgqb1c44Hq3k0NQA92DZJxmE7oKjL9IHo44FlFvzohw5SimUtQF7GayKPK92L4CYtZi/ceSPN3AVBizNw+DqqTU1ZvjzMWjL+5 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a66134a-6ed5-4993-4731-08db8a3ab479 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 22:34:54.5894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nQUa7N159+cFYGyJUI4EKYDpBu/0MUWZbqWNQBuXRAESDSqZY+B6KHgMQ3cjhZjmfDWvUS/T7upLe9EfVT5zUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5828 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-21_12,2023-07-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=313 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307210199 X-Proofpoint-ORIG-GUID: 4FIxzK87-PO405nZNNtLCecX0pcs0i3j X-Proofpoint-GUID: 4FIxzK87-PO405nZNNtLCecX0pcs0i3j X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/17/23 07:03, Jose E. Marchesi via Binutils wrote: > > Hi Nick. > >> Hi Jose, >> >>> This patch changes the opcodes CGEN support code in order to allow >>> base instructions with opcodes past the least significative 32 bits. >>> Note that the masks have been adapted in a previous patch. >>> This patch has been regtested for all the current targets in >>> binutils >>> that are based on CGEN, namely: >>> - bpf-unknown-none >>> - lm32-elf >>> - fr30-elf >>> - ip2k-elf >>> - iq2000-elf >>> - m32c-elf >>> - m32r-elf >>> - mep-elf >>> - mt-elf >>> - or1k-elf >>> - stormy16-elf" >>> Also with --enable-cgen-maint and --enable-targets=all. >>> No regressions observed. >> >> Patch approved - please apply. > > Thanks. > > Before pushing I am looking at the CGEN_INSN_BYTES point raised by Jan, > which made me realize that, even when I am pretty sure the path > introduces no regressions, it may be incomplete because it won't cover > targets that would have opcodes past the lowest 32-bits of the base > instruction and that also define CGEN_INT_INSN_P (even if we currently > don't have such targets.) With the recent changes to the BPF port to not use CGEN, this patch is no longer needed, right Jose?