public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] aarch64: Fix --no-apply-dynamic-relocs for RELR
@ 2024-07-02 16:30 Szabolcs Nagy
  2024-07-15  9:07 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Nagy @ 2024-07-02 16:30 UTC (permalink / raw)
  To: binutils; +Cc: Nick Clifton

The option only makes sense for RELA relative relocs where the
addend is present, not for RELR relative relocs.

Fixes bug 31924.
---
 bfd/elfnn-aarch64.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 000564672df..94c9a01069b 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -5990,8 +5990,6 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
 	    {
 	      /* Don't emit a relative relocation that is packed, only
 		 apply the addend.  */
-	      if (globals->no_apply_dynamic_relocs)
-		return bfd_reloc_ok;
 	      return _bfd_final_link_relocate (howto, input_bfd, input_section,
 					       contents, rel->r_offset, value,
 					       signed_addend);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] aarch64: Fix --no-apply-dynamic-relocs for RELR
  2024-07-02 16:30 [PATCH] aarch64: Fix --no-apply-dynamic-relocs for RELR Szabolcs Nagy
@ 2024-07-15  9:07 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2024-07-15  9:07 UTC (permalink / raw)
  To: Szabolcs Nagy, binutils

Hi Szabolcs,

> The option only makes sense for RELA relative relocs where the
> addend is present, not for RELR relative relocs.
> 
> Fixes bug 31924.
> ---
>   bfd/elfnn-aarch64.c | 2 --
>   1 file changed, 2 deletions(-)
> 

Approved - please apply.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-15  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-02 16:30 [PATCH] aarch64: Fix --no-apply-dynamic-relocs for RELR Szabolcs Nagy
2024-07-15  9:07 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).