From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cross.elm.relay.mailchannels.net (cross.elm.relay.mailchannels.net [23.83.212.46]) by sourceware.org (Postfix) with ESMTPS id 7D4293857712 for ; Sat, 7 Oct 2023 22:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D4293857712 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 65CA35406C2; Sat, 7 Oct 2023 22:53:34 +0000 (UTC) Received: from pdx1-sub0-mail-a246.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E3105540BF3; Sat, 7 Oct 2023 22:53:33 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696719214; a=rsa-sha256; cv=none; b=cq0fRyoK6XMc4ZO6ScOY4uO17IZaTOOTPVCvrNdv8pV0WYJxh7ZUDDYe2OqgDvyliSGBnf ch2xDQO6Q+o1CMiTQFtduzp8nfqcPNbWB49Jz7yuLAjND9on8s0vwnhQ0JIo7A8tKnjWgH ZPyLmYtDvrjyQ/ubZdHUm/rs2VZPvj4JX53FJ6JbE+fqMA7ArQJAv2/6OTG1vZ4l692lIe s4BFeNH4c/XaQMxFlTCzJ1PI2qM6W/xCMDt6KRu7E6LAmL4cCJ1qoUFvuQ9kzGeDu0TmRV UGG5sXa5IuRx200sgxe8UEw+Hbt28bbplJKfK8NGtMjU533vHxzCwwzC7+rl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696719214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ml43xtPbKFa9wC/7VXbXGiuAU7nN7DYofFoVHkjiSCY=; b=Ce0iRNJHxif2rhhBLCsh7r41v+fNueypXFa9CKE0mbExgEW5BXx36k+AOdsNshBbWawOVA wokd94rgcIzo4HEpXgtaj26Cv/QY95DInj9PgtEdH9AsoH4yDbBiEPEV/vRWeGrnSS1kiH dnCvRrjhwdaq+veKxEhbY9PExRpdkcFwuPah3DpViIm/MimwvvALBsnNyJosrb1G8+QD2+ TNI1NAsSKQ+k7S/zESeDhuCyE5N5JrwlPfCAjilRTGvibKn3JGHwrOEeSkzOBKUk2qa9X7 3NUOZmlDyVHDI7NzTmvWAx2kZDt1TaPucCElwcd5m4A83pLVLp7pTnIxXDahww== ARC-Authentication-Results: i=1; rspamd-7c449d4847-65wjp; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Eight-Share: 10c999bf608e8687_1696719214244_3228845843 X-MC-Loop-Signature: 1696719214244:2980906850 X-MC-Ingress-Time: 1696719214244 Received: from pdx1-sub0-mail-a246.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.113.180.165 (trex/6.9.1); Sat, 07 Oct 2023 22:53:34 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a246.dreamhost.com (Postfix) with ESMTPSA id 4S30vd2JW6z54; Sat, 7 Oct 2023 15:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1696719213; bh=Ml43xtPbKFa9wC/7VXbXGiuAU7nN7DYofFoVHkjiSCY=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=chnQuUU4xbbtC0z5h+V/A30IWA8eiZ65L2hbeqXm4qxwnSXN0X+qjV7oP3oSxptSy HpRn7HYMphhS74gnSLPr3VsuqGhZnAbU5eSBEQvls0r5EDD16CmFxmEnjNGgPoSeZd 2O4xv18o/121A2ccCtGMSb2Gl1TmnQj+9aSQngd+6IYC8L36YCX/QtxtKh0Vsu+MsS g0MsQF54GmqWheITpukoDSq9pn6Wb9QdpWa5Z6krWgkBnWqECCR9nzDnP5EGsm7CNX hbxew9UlCv4UzXPKE29wzTpJuiK+xI4zEo1gUdzWVvWVBDR9ugftUVFHfV0Xnof818 yBZtRipZsd9jw== Message-ID: <609d027a-0671-4416-ea0f-6d59b32f94f1@eagercon.com> Date: Sat, 7 Oct 2023 15:53:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] microblaze: fix build error on 32-bit hosts Content-Language: en-US To: Mark Wielaard Cc: appa.rao.nali@amd.com, binutils@sourceware.org, ibai.erkiaga-elorza@amd.com, luca.ceresoli@bootlin.com, mark.hatle@amd.com, nagaraju.mekala@amd.com, neal.frager@amd.com, nickc@redhat.com, sadanand.mutyala@amd.com, vidhumouli.hunsigida@amd.com References: <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> <20231007220105.818599-1-mark@klomp.org> From: Michael Eager In-Reply-To: <20231007220105.818599-1-mark@klomp.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/7/23 15:01, Mark Wielaard wrote: > commit 6bbf24955 opcodes: microblaze: Add new bit-field instructions > introduced a build error on 32-bit hosts: > > elf32-microblaze.c: In function ‘microblaze_elf_relax_section’: > elf32-microblaze.c:1989:53: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘bfd_vma’ {aka ‘unsigned int’} [-Werror=format=] > 1989 | fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", __LINE__, val, irel->r_addend); > | ~~^ ~~~~~~~~~~~~~~ > | | | > | long unsigned int bfd_vma {aka unsigned int} > | %x > elf32-microblaze.c:2074:51: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘bfd_vma’ {aka ‘unsigned int’} [-Werror=format=] > 2074 | fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", __LINE__, val, irelscan->r_addend); > | ~~^ ~~~~~~~~~~~~~~~~~~ > | | | > | long unsigned int bfd_vma {aka unsigned int} > | %x > > Fix by explicitly casting the r_addend to long. > --- > bfd/elf32-microblaze.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bfd/elf32-microblaze.c b/bfd/elf32-microblaze.c > index a8ced43c08a..2c584f91a4e 100644 > --- a/bfd/elf32-microblaze.c > +++ b/bfd/elf32-microblaze.c > @@ -1986,7 +1986,7 @@ microblaze_elf_relax_section (bfd *abfd, > /* Validate the in-band val. */ > val = bfd_get_32 (abfd, contents + irel->r_offset); > if (val != irel->r_addend && ELF32_R_TYPE (irel->r_info) == R_MICROBLAZE_32_NONE) { > - fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", __LINE__, val, irel->r_addend); > + fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", __LINE__, val, (long) irel->r_addend); > } > irel->r_addend -= (efix - sfix); > /* Should use HOWTO. */ > @@ -2071,7 +2071,7 @@ microblaze_elf_relax_section (bfd *abfd, > > val = bfd_get_32 (abfd, ocontents + irelscan->r_offset); > if (val != irelscan->r_addend) { > - fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", __LINE__, val, irelscan->r_addend); > + fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", __LINE__, val, (long) irelscan->r_addend); > } > > irelscan->r_addend -= calc_fixup (irelscan->r_addend, 0, sec); I didn't see any build errors, building with GCC-12.3.1. Which version of GCC are you using? (Patch was reverted.) -- Michael Eager