From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1F16138582B4 for ; Thu, 30 Jun 2022 11:10:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F16138582B4 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-FC5FR6ZrO7q5lC3XWVO42w-1; Thu, 30 Jun 2022 07:10:05 -0400 X-MC-Unique: FC5FR6ZrO7q5lC3XWVO42w-1 Received: by mail-wm1-f70.google.com with SMTP id h125-20020a1c2183000000b003a0374f1eb8so1238700wmh.8 for ; Thu, 30 Jun 2022 04:10:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=gHGGNY15JkCALF+9Ek3kRrxDYa3GtJsgse7wshlwPpE=; b=7PXV//Dk3jI/Mf/oPIiI7h0FhGFBJgxD2mJ4um4ybj2sQ34ShCxB6ZSGzVLn1oHyuy 6Xsj/4ZZDolK/6D38qBi1vHCrfzUDCUtw5LAGA610NrBYN1lrxBVfddSJ6edmMxjsXjF r70UG/PQmGoMOhYpvOABFFrg4nbf5fgp21SAmhCp2in+znWZ7dZzPuKLjY5DrnyDqw8l 5UNASHirZdU6nNyI/5qavQV4oue6h4oBzywVYT5VMjWQz9pIYfuA2P4lGOmyrgUjB7d9 LDRPGwne1ANEZE42nEhFFhHGtx2vz0l5At60lmCGdVg1TqIOOX9aVc9TVLWiEgxqvwiv EBTQ== X-Gm-Message-State: AJIora98n8zRHQe7TYR3xKV6xbEBKXWrFhn6m+zQXdibHDyLXZK0T4w3 nsAZXMGDY3dzIjLgcYw6OxiHSZusrT+wuz2d0aVj112taAKP6UMX+k9jQBhNsgHePE01tehsrw0 LQN+XhbJrIN5IuUVsFw== X-Received: by 2002:a5d:64aa:0:b0:21b:c3b2:eecc with SMTP id m10-20020a5d64aa000000b0021bc3b2eeccmr7738215wrp.181.1656587403953; Thu, 30 Jun 2022 04:10:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v2gfC30KgYoxiWiSj6ULbAf++A6h1KZ9Cl4j92EGCKZdvBzLQFxzbLnndXytph2Avq6NwaDA== X-Received: by 2002:a5d:64aa:0:b0:21b:c3b2:eecc with SMTP id m10-20020a5d64aa000000b0021bc3b2eeccmr7738197wrp.181.1656587403759; Thu, 30 Jun 2022 04:10:03 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id t8-20020adfdc08000000b0021350f7b22esm19310027wri.109.2022.06.30.04.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 04:10:03 -0700 (PDT) Message-ID: <611ef378-6839-698e-2cea-3e8bb6e416a5@redhat.com> Date: Thu, 30 Jun 2022 12:10:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PING][PATCH] opcodes/avr: Implement style support in the disassembler To: Marcus Nilsson , binutils@sourceware.org References: <20220606191118.550423-1-brainbomb@gmail.com> From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 11:10:08 -0000 Hi Marcus, > One more ping for this one Sorry for the silence. :-( >> opcodes/ChangeLog: >> * disassemble.c: (disassemble_init_for_target): Set >> created_styled_output for AVR based targets. >> * avr-dis.c: (print_insn_avr): Use fprintf_styled_ftype >> instead of fprintf_ftype throughout. >> (avr_operand): Pass in and fill disassembler_style when >> parsing operands. Patch approved = please apply. Cheers Nick