From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2042.outbound.protection.outlook.com [40.107.14.42]) by sourceware.org (Postfix) with ESMTPS id 85D62385840D for ; Tue, 31 Jan 2023 08:52:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85D62385840D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtaLAcEKDG77UYyUYsv+mDuZ18ZI214aGWlnWNAoKlpfWtQ0jaWOh9PFmwTW2nS/pCcN5MB0e0zeATjeb7vAqUDziUFyF/K0Yg5OxgyHhdFsWDafPgCd38MRf+QGRnOrSa3KYmBMpS7nL1w+SGDawMU8hEpiJlVphWyZOn9Dxr3RJM2pPIkIw+eykSTvO1fAnD7jpgqHlzTXLb3K2AmuFIsssiE5XZs55LCz/1KmFVVMyCoQATanu8T3IZ4h1AUA5b6DxEvAmqgpD9fsOIlQ5qfXouI1/TL25gC/jt7NWBLlowTOGK6OhyRhiD2af8BBHg5upltqavYF/o3i52FwqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8LuRbYFAl1JIVHISTRPmuf8rfXaY3O7E9uU+ZQgTytk=; b=FfbiDP0/9WJd/hhM7YE92H1zElS2tpm2hBgIosESkDDOacN8wRPPu38OU+J99zLJ+dGTZRrzSH+mAHPGmI/ET4HF+jNwAzBaHmqFPLIQ24MWfuGxEq4TajxQeo3VSj2SNTYrjU2kgvGyiUTeiVJL4CcjX7ve+0YaOiPu7AbPjXb7VvCmDSchEwemzOMzMuM8RoIjHas07iJltnCkA+pu9QVdkIcxPvxTbxMf2riGKhcmbn6uzuHKo1knED86o/VqCGs7+6KDw1mo2tKS/NpU9XRokbkEVyUsYUtvhDpA97SB9gi0QNPDDRbcrKgFWRbcBg/yhphJvBsXHXGc265zKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8LuRbYFAl1JIVHISTRPmuf8rfXaY3O7E9uU+ZQgTytk=; b=ZGDtzoEIrUtTLZeucOASIKrL4+0vdfEKI7BwaCOj6IZvOi4+J+JUDZXzw6/Q4MXdF0ubINVNxbONp/nNJxopaqrp+9pasDSBI6YDuN2NXMeMU2KVHGCNGZN54rauocjkj2WfyNF1o/lmv8wILisVYRvautQyi/d1ztuDnH4eCC4Y/bMEETZaiSWOF+HiFTJFB6CZHzLb/P1GTXvY35Qm7n8uVUoqU+JYTkM0OeW8r1KyMlh4nZdlVcKVxrT7bDIYWPaH/S7VAc8hQoFH5qD8PEYdFbvQUAk31oLotbTgJqrfmE/kraUORumhXCPj/u6kcIzxqFzmia59T0ONA6rjuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7603.eurprd04.prod.outlook.com (2603:10a6:20b:2d6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 31 Jan 2023 08:52:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 08:52:23 +0000 Message-ID: <612c50e2-9dcd-6ad3-bfc3-a1b51f59dc20@suse.com> Date: Tue, 31 Jan 2023 09:52:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] RISC-V: make C-extension JAL available again for (32-bit) assembly Content-Language: en-US To: Nelson Chu Cc: Binutils , Palmer Dabbelt , Andrew Waterman , Jim Wilson References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7603:EE_ X-MS-Office365-Filtering-Correlation-Id: 352578d1-24cf-4cc4-3036-08db03687845 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kPbDc++Jl6T/ZK0ULjG/lP+Rh3GY7mJWGL0DzCXR9Z8sgKGrfTOrFWhijef3pk/JaEVUiDsxYyr4Ri/HVeFWubkJyWU5GFNkWZsQbv69OoB6N1lYcI0OjuDPbJ7fReQlZBCvBRDR3OqVrJ7YkKjWHBrNx3dWxmT8RQfc6KPEZjJC/aH0BstDz7wSh5RwDP2ZAzc3MkpOxw5AL2V9XAjPGDZlrf8LNoZ29l/MLHvjf7IkixNuY7lM5xvT/m9cELF1gpaFHJL6RKju8LojVC4mfeUGs/KfAuTiqNUzZrhbaFfTUKzRYYYEBvb0sDXutwQTcJEjD8Q8pYzBb0FvqDCC7fCC/S6ZahNz2D3qriJjob67NVj0DM/22YVQ2gsPnyrqLuLxRN8WQ7CkmQmLiyybdiB65VtlcFwUjDMFbbH8uIM/0HNed0pk27PB8s4xhY+mdcGiWX0OoFeD05larki2SWZd29nyOzh+Vi7UVbNRr4GxcZY39N+JvcVm04VjLwcoEhinBUKACGZrAEL85C7VP8He9EZDJ5oNkcgpNc7Hpc/Dx+uACRBimlKNWdKEsXGfHodp7qQXwxPr43GHo16iFRyVh5lp2guh4R2oAY9H4gr3J9+/lXxMuxlS1K0NKtOP6pWpVEVAp2ycfrVgYAtU2e+BOAz5q+qBbv69wGn9zx99cK3LuGGSnhzx/8G+k7kqnIqIUpTKdxlXtzdv0pxvlE3wREucwGdnuSL5T3U1QAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199018)(31686004)(36756003)(54906003)(66476007)(4326008)(8676002)(6916009)(8936002)(66946007)(5660300002)(316002)(38100700002)(31696002)(86362001)(66556008)(53546011)(6506007)(26005)(6512007)(186003)(2906002)(6486002)(478600001)(2616005)(41300700001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkJZTnE0RnR4aFh4QXRhdjNhQmd2ek1JU3pOdkREU1Nnb3kxcE03dU43YWZF?= =?utf-8?B?TnBYbFJPSmZ6azR2bDJ1RVY2aUtrS0ZYVlBGbllsVU44VW1KTmQxdE0zNnUv?= =?utf-8?B?bEFleTMxa1p3MnJySUdYNGdlb0J3amJzM2FyZ1R3aFlLcjVQSjNQTnFteXhR?= =?utf-8?B?dzd0RHlMdHlsdHdkTmZId2FtcUc0S1dzV25NTk9peTk0K3BJN2VYd0lVRmJY?= =?utf-8?B?TUlJZTNXeDZnVmg0L2pOd3docGRMSDJMZU9SdUVsR05Dcjl3WTJsVWNRc3NO?= =?utf-8?B?dmM5T2pWQ0lFbnRKcUMvd0FuTmFaTVVFc1dWK1Y4RktlZ3AyUFh3QmpPa0Nn?= =?utf-8?B?WUpXd1Vobm9wc1lsZzJlN1FvWExEbElwTEpBQ2cwL3M5QlYvQUExZytvWmdh?= =?utf-8?B?WWNnVHlQZFB5WEZ1N2pNTW5tdWxwbTFjUytsL3BUa2FxR2VsdWlKOWFrQVRK?= =?utf-8?B?eFN3ME1lQnNabWd0b3VENkZYODQvVTBpRGRsRkFrdWliUkV6S2pnZUVsT1Vq?= =?utf-8?B?eTdHbnUzdU1pTm52ZW5TVzE4dzFDL1dCd2dYV2NmYjVaM2NaK1BhZHl5M2tE?= =?utf-8?B?THNLK2RoY2J2ZTZPME5oSkZlYkU5bVB5aVBRMHVRWTlsZzV3MjFFSHhGdTVD?= =?utf-8?B?bjlHcEs3N3p3OEVlMmZXRDJDdFlzSlpHYS9aenlnaDZEdjA3OVQ2Yld6bTg4?= =?utf-8?B?emJVZXQ1SW04Z2lTMXorSW42R3JHR2Fkc3FPVGxUdjFvYlJiMkRNVHF0Titx?= =?utf-8?B?MkZ5eEx6eEFMd24vQUdXalFyaHJKOC91ckRBcHhKTE91MXgyZkt6dmVydnZk?= =?utf-8?B?SlBzYWNMOWV3VlBqbk9HQlZuTWdjS0Q0SzVWc0hxay9xL1pTSFBNWmNQTjlj?= =?utf-8?B?NFhEMzJMVUpmWVRiODZ4NkpXK1RFTVdyamNNZ2RUN0M2M0xOMFJuK2F0bzNX?= =?utf-8?B?MXpldW9SMlZkMHNROFowMS9uQ0hJQnBJT3pIejZQTEs3WVBrR2RkVXRDT21a?= =?utf-8?B?ZDhxdzM4YUZYRElpeHd5Y2lxenliU21uck1wWWV5cTczV1oxZVltYkQ1aS9W?= =?utf-8?B?TE40dElyM2ovdWkyaWErVEsyb1JlRy8veUFKOWJDYWJLTU5ROWNmRTF4eVh0?= =?utf-8?B?Y0x3a0RnZ2srbE4yMFJFdDVzdXpXMHRsZmhQSWllbys5R0xTUTZWejM1Mkxl?= =?utf-8?B?dmhSSzlYRWVMdHBWK21oUEwwTDUyRTVNYTk1bnFuUm5Qa2pYRVkzc2MrR0FD?= =?utf-8?B?dFYzZlVFL1V6N3BkWGVpc1FHZ2hBQWpHZUh2Vmd4VzQ5WmtoU00yOE9wdmJO?= =?utf-8?B?TE5sQlFVUFNRbitwaFhGdGp3N0R0U3dxeWRkOEdrVG5TU0Z5NnBFN0pqRy82?= =?utf-8?B?MDdKQ2RrRjdYaDNNUzdLb0RpcVNCQmpUcEgrTmEwUUxnUjVLZDUrMWVsTUc0?= =?utf-8?B?WDF6TndybytzV09tWlNHSUtERDFHOG9vNXNrVEZ5bzgyNC9CcGFoMDkwVS8v?= =?utf-8?B?V1dtUk1vc2ZFL0xoM1ZKc2dMUHY3eERJUFJ4UTJXbHRqRjdFTitaUmNpU3pi?= =?utf-8?B?dER3Wk5FdUYyK3M3aTJBRWtKVGI3dlU3cXNiSkxrTlFiT1NHYURxOFE4QUQy?= =?utf-8?B?TStNWUNXNmhsNmljM3B1RXdtTnRITE95cExjMXg0bC95NGdUZGlTZ1l2TURo?= =?utf-8?B?ZnJuWUtvWExaU0tjd0hJaEpXU2xmZEJiVS94VXlGUEJQVUxqYlFLMm5wTWhj?= =?utf-8?B?SVBKeGc0VzVOWTA0eU5YY3plZUtvSkQ2c0JxQWQ3a0NCbitmZHVDRFdiOWVp?= =?utf-8?B?dzBlSlhxMm5FN1ZmUk9nTVlJbWlSRnc0Z0c1OEVUaEUyYnM2R1RSYnlCWU5D?= =?utf-8?B?Vk1zTERQdDFPVUpWNFlSN0FTUWxKL0J2Z1gxajFuZEV6YWdTTUdBTnU5Y05y?= =?utf-8?B?L2wzQ1VmQS8rc2ExYjk1Vkt0Q0VabWl0NlNUaUI1UjNHUFU4SnQ0NytFdFRi?= =?utf-8?B?MXVwQU9iZm44aSt3N3dMZXpzWjVaVGhJa2t3MjlPZGVZbVMvSERFek42c2x5?= =?utf-8?B?UjFRellWcjhGdDh5WnBKdEM3ZGh5RXdmNlpqZFlLOUFsUk5lbmE0WDFpcHYy?= =?utf-8?Q?x74ub3yk63X66LqEuVTj/rcXf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 352578d1-24cf-4cc4-3036-08db03687845 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 08:52:23.4526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 17jMMzT146TzNhwtY+cvvovZT2dK3J5dvTk413cYzDKVgaUDiL24oLPag4EDQ1MDBCuvnmdtBdLckpGZA3IMig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7603 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.01.2023 02:11, Nelson Chu wrote: > Thanks for helping to follow these. Well, it was my fault. > Looks reasonable, so please commit. Done, also .. > On Mon, Jan 30, 2023 at 10:07 PM Jan Beulich wrote: >> >> Along with the normal JAL alias, the C-extension one should have been >> moved as well by 839189bc932e ("RISC-V: re-arrange opcode table for >> consistent alias handling"), for the assembler to actually be able to >> use it where/when possible. >> >> Since neither this nor any other compressed branch insn was being tested >> so far, take the opportunity and introduce a new testcase covering those. >> --- >> Pretty clearly this should also go on the 2.40 branch. ... on to the branch. >> --- a/gas/config/tc-riscv.c >> +++ b/gas/config/tc-riscv.c >> @@ -2764,6 +2764,8 @@ riscv_ip (char *str, struct riscv_cl_ins >> case 'p': >> goto branch; >> case 'a': >> + if (oparg == insn->args + 1) >> + goto jump_check_gpr; >> goto jump; >> case 'S': /* Floating-point RS1 x8-x15. */ >> if (!reg_lookup (&asarg, RCLASS_FPR, ®no) >> @@ -3273,6 +3275,7 @@ riscv_ip (char *str, struct riscv_cl_ins >> but the 2nd (with 2 operands) might. */ >> if (oparg == insn->args) >> { >> + jump_check_gpr: >> asargStart = asarg; >> if (reg_lookup (&asarg, RCLASS_GPR, NULL) >> && (*asarg == ',' || (ISSPACE (*asarg) && asarg[1] == ','))) Just to mention it: I already have a patch to remove all this hackery again, I just want to chew on it for a little more before posting, in case I notice something that's wrong with the approach taken. Jan