From: Simon Marchi <simon.marchi@polymtl.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>,
gdb-patches@sourceware.org
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/5] bfd: add elfcore_write_file_note
Date: Fri, 22 Jan 2021 17:17:34 -0500 [thread overview]
Message-ID: <618186a8-b1c4-43b8-ff06-46c1d520d5d0@polymtl.ca> (raw)
In-Reply-To: <20210103130300.21637-2-mihails.strasuns@intel.com>
Adding binutils@ in CC, can someone over there please review this change?
The full series is here:
https://sourceware.org/pipermail/gdb-patches/2021-January/174652.html
Simon
On 2021-01-03 8:02 a.m., Mihails Strasuns via Gdb-patches wrote:
> Adds a trivial wrapper over elfcore_write_note, primarily to be more
> consistent with other ELF note helper functions and highlight NT_FILE as
> one of notes handled by gdb.
>
> bfd/ChangeLog:
> 2020-12-17 Mihails Strasuns <mihails.strasuns@intel.com>
>
> * bfd-elf.h (elfcore_write_file_note): New function.
> * elf.c (elfcore_write_file_note): New function.
>
> gdb/ChangeLog:
> 2020-12-17 Mihails Strasuns <mihails.strasuns@intel.com>
>
> * linux-tdep.c (linux_make_mappings_corefile_notes): Start using
> elfcore_write_file_note.
> ---
> bfd/elf-bfd.h | 2 ++
> bfd/elf.c | 8 ++++++++
> gdb/linux-tdep.c | 8 +++-----
> 3 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
> index 53b5ffc33d..75d5576042 100644
> --- a/bfd/elf-bfd.h
> +++ b/bfd/elf-bfd.h
> @@ -2801,6 +2801,8 @@ extern char *elfcore_write_lwpstatus
> (bfd *, char *, int *, long, int, const void *);
> extern char *elfcore_write_register_note
> (bfd *, char *, int *, const char *, const void *, int);
> +extern char *elfcore_write_file_note
> + (bfd *, char *, int *, const void*, int);
>
> /* Internal structure which holds information to be included in the
> PRPSINFO section of Linux core files.
> diff --git a/bfd/elf.c b/bfd/elf.c
> index 9c82912aeb..070db5b180 100644
> --- a/bfd/elf.c
> +++ b/bfd/elf.c
> @@ -12028,6 +12028,14 @@ elfcore_write_register_note (bfd *abfd,
> return NULL;
> }
>
> +char *
> +elfcore_write_file_note (bfd *obfd, char *note_data, int *note_size,
> + const void *buf, int bufsiz)
> +{
> + return elfcore_write_note (obfd, note_data, note_size,
> + "CORE", NT_FILE, buf, bufsiz);
> +}
> +
> static bfd_boolean
> elf_parse_notes (bfd *abfd, char *buf, size_t size, file_ptr offset,
> size_t align)
> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
> index 5ae28d826c..5b44e7135b 100644
> --- a/gdb/linux-tdep.c
> +++ b/gdb/linux-tdep.c
> @@ -1591,11 +1591,9 @@ linux_make_mappings_corefile_notes (struct gdbarch *gdbarch, bfd *obfd,
> obstack_grow (&data_obstack, obstack_base (&filename_obstack),
> size);
>
> - note_data.reset (elfcore_write_note
> - (obfd, note_data.release (),
> - note_size, "CORE", NT_FILE,
> - obstack_base (&data_obstack),
> - obstack_object_size (&data_obstack)));
> + note_data.reset (elfcore_write_file_note (obfd, note_data.release (), note_size,
> + obstack_base (&data_obstack),
> + obstack_object_size (&data_obstack)));
> }
> }
>
>
next parent reply other threads:[~2021-01-22 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210103130300.21637-1-mihails.strasuns@intel.com>
[not found] ` <20210103130300.21637-2-mihails.strasuns@intel.com>
2021-01-22 22:17 ` Simon Marchi [this message]
2021-01-25 11:04 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618186a8-b1c4-43b8-ff06-46c1d520d5d0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).