From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 5B834385DC02 for ; Wed, 1 Apr 2020 16:54:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B834385DC02 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 012EBABD1; Wed, 1 Apr 2020 16:54:43 +0000 (UTC) Subject: Re: [PATCH] PR lto/94249: Correct endianness detection with the __BYTE_ORDER macro To: "Maciej W. Rozycki" Cc: Jakub Jelinek , GCC Patches , binutils@sourceware.org, "H.J. Lu" References: <20200323103505.GF2156@tucnak> <6313e487-6dbb-ac17-4160-4ac600af40be@suse.cz> <7369b1aa-be0d-92cc-4f81-1612f101e2e8@suse.cz> <3786da05-1530-38c5-e9e2-cd69418cd42a@suse.cz> <5b27738a-9885-9906-0c93-888daf4a066f@suse.cz> <20200324083109.GP2156@tucnak> <20200324091805.GQ2156@tucnak> <58a785c1-08fc-a491-e19d-2b42e0a9817b@suse.cz> <2131cafa-703e-5f42-865b-e2f7f718dc83@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <61fdce93-0da7-3bda-6a78-c5a072304d6d@suse.cz> Date: Wed, 1 Apr 2020 18:54:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-17.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 16:54:46 -0000 On 4/1/20 5:59 PM, Maciej W. Rozycki wrote: > On Wed, 1 Apr 2020, Martin Liška wrote: > >>>> I've just installed the patch. >>>> @H.J. Can you please pull it to bintuils? >>> >>> Why didn't you use the commit as I published it >> >> Because it didn't fit my script that takes changelog entries >> and moves that to the corresponding ChangeLog files. >> Next time, you will install the patch by your own. > > That was the intent: I asked for approval to commit, which is the usual > practice for people who have write access to the repo, and not to commit > on my behalf. I've got it. > >>> and also assumed >>> authorship of my change? I feel insulted. >> >> I removed myself from the ownership of the patch here: >> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d3ee88fdb4e0f718aaba050a3eb7174b8934a29d > > I don't think it has changed anything: > > commit 142d68f50b48309f48e34fc1d9d6dbbeecfde684 > Author: Martin Liska > AuthorDate: Wed Apr 1 09:37:37 2020 +0200 > Commit: Martin Liska > CommitDate: Wed Apr 1 09:37:37 2020 +0200 > > You're still listed as the author of the change in question. It's the first time anybody is asking me for that. I considered the ChangeLog entry as sufficient. Anyway, next time please send a patch with git format-patch so that one can apply it with git am. That will preserve you as the author. Or ideally, feel free to fulfil copyright assignment and install commits by your own. Martin > > Maciej >