From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062.outbound.protection.outlook.com [40.107.104.62]) by sourceware.org (Postfix) with ESMTPS id 78ED23858D20 for ; Wed, 12 Jul 2023 07:56:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78ED23858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5f3dB4/7S95TJ1TQ9iMmQHhnbi0yE+gmwEsFNkyejpVrkl832L2CDs5ETiQBHmtbu7jDjEKRDMHOVzzGPyr98IZD0lDF0SgiYIw5IjH33dEF+1SuY5ncnu3sEVbazmd6AvsiYq44tfXwjLDI80ygvDVWiNQ32B+KNkBYKlYrZEZyAGFrgo/4T8Ki2hxzT1FM2FIDB9QwxDBuerUXo30uoA1Zc4Hja2SZSFOn5rPMCyjG2Wq6n6Cy2OKX4rxH7QfvhfUzkecpqdo7sl2M2+RZTh7dPLbtGj1jmtZuhO6ZOeITcV9EUV0IskJeP9jZw6Ctm5n6nFd+g2lyZ9edMLRrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbXqBifrXS7h72Iw+7ucp/0qXw9IuwF3Uf3TfAlHg8g=; b=E5Lp8DsLsnkyspkEP/u3eGCcptARtLP+C+mEfsIFks/+91h/FiXdyb9iYJQWV19GONkZ3ajeBUHKS8bmJHUfbu8GqwkhzR/HDSC1VmCRJh3vdsjEhEbEJEY7nFue9HYrVf5JBLSkS1gpvTkl5MZVtMsl25i5fMZD0Y/78gpzRssDjDjqvu4OdShx1eH3N5iei2d6q09J9mk93jJkFN/tqyWIRT3R8t7ajZT7MLH2gvRT1R4iri95YhXuW4szcZt7EBh5leDTVgM46nmoMzkCyaQdsjyZG1m08ZMzRa87nXT+aiWly8m3HiJOKPjyria2i/NmBojxA7ynEeSfCxHuOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbXqBifrXS7h72Iw+7ucp/0qXw9IuwF3Uf3TfAlHg8g=; b=xtHLJddDFi2qmPQKKxjUOxaJnHBYngXOvvoT09t7NFbMvJDiiNabJaG70lWeJZLq9fzzs4GLMjGbasMu6uXyO89NhbibHOLHcPa8uVMNXxHEMFMEZa3L1HmDrW41/FVjAm6VdFxg12rsb5fKpzO7OZKCnOHGaNZyS8jME+z/45mNINOany4aPKOQPM6h01jyEkvbn/DKRL/lCYZZK1vZV86Ths6Jif4WLQOd0Jif4yAKvzqjcZSZf91mvXHpcxG6HJ4JCVFgs3vxru1Z5mluGAJUu09060xn8sEQbH9Z1+6qssl6DakzJoc5d7iHfS1kjrF1JiokqhU34l9EPehX9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by DB8PR04MB6809.eurprd04.prod.outlook.com (2603:10a6:10:11b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Wed, 12 Jul 2023 07:56:00 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Wed, 12 Jul 2023 07:55:59 +0000 Message-ID: <62306e09-61cd-0a8e-f052-1e34b357936f@suse.com> Date: Wed, 12 Jul 2023 09:55:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] ld/PDB: fix off-by-1 in add_globals_ref() Content-Language: en-US To: Nick Clifton Cc: Mark Harmstone , Binutils References: <88c2fb96-185d-ae27-c025-ed025ed54641@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0170.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::8) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|DB8PR04MB6809:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fe231c0-0149-49fd-d772-08db82ad6e85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YKMrnBnxXA9bgGNAvuY1/z0NKcbBd7OiezIxLb6jj/K8+sIb/UAt0wN3iUXpEvhtePe2hH+SPPq3h9D4B4eazm6nCvCc8cefLdxyleMxeRVn/UChi52YWRCZ4XhHs9e5uY11JPS+l3dvUogKrYSm9yzR+sLG6LUrmKpadnTB5e5Qz+TvhbnehvgryhQ1990N56jEqQuVAdkwMDZGqw1XzSMrHz8vlrajnate0tOIAKqcFLBEKvMwq9xx4P2cfRkLZLekUpNnueZiW9p14tPRHaL6WEjvQERDZ8yQJkCfHyPHJnbSSuPDnOA3OlYXq3RJwGgmv4tibMzgmzlXybDGlafiaxhMq4YwtRDCMRzQZzskr5Im4TzcOXEevJK7+Af0JjuY2Ts1wAMLFDrAFmDtQ+F0TbtVCJ6oEcHZ1MZxLAdPJ4drGMPYvXchFfqRjKDApO8Ut/v3/BI8vq/zoUPnMtS3gOvM+x9kbQkEYag6YgZtXMKupI9Zq6AncT9hWhRHZGzN2YC/F1uKeXq3bALPmIjGyzJr0mN0GO9TuJ6oJCSkb8G5VDJy66YWAxyE1SQsCAFHV+bb9uZaggiDVGsbhSiqdnxktnK78BkscubYD18+sMkDXbMIdTrAjBFrwFLMmNM6v9IiLPveJRKkgtRL8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199021)(186003)(53546011)(26005)(6506007)(6512007)(2616005)(41300700001)(478600001)(6916009)(4744005)(316002)(66476007)(66556008)(83380400001)(5660300002)(8936002)(8676002)(4326008)(2906002)(66946007)(54906003)(36756003)(6486002)(38100700002)(31696002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXJnbHRETUVmdkZWWGtqWEJSNEVqTXVGeURHQloyZXdYNW5raFptVlVFdzB2?= =?utf-8?B?T0pTSXliZHB1OXRrZlVZOFBjMytZcWppOEU3RHJ0OE9mbXErZlM1WGNvWWhX?= =?utf-8?B?TWxXQnUrRkgvYlMzVUxEZkhjbVk3ekwxL1NiTFhieXRkNTZlL2wwRlMyTmZx?= =?utf-8?B?c2QzeENBNms5N1B0c29FL1JqMTVhS285aFdDZ1A3bWNmNTlnM3JaTm45dnNV?= =?utf-8?B?WFZBWi9meUtwb3A1TlVKd1NvOHVGaXJhWW82N2tCL0Zjc2VJYmRQcUF1TFdE?= =?utf-8?B?dEFtWlU3dnVNZWNnL1h0QUxxb3dhODVQMWlrMVFINk1wdU1uQlhiWWlsWFds?= =?utf-8?B?MWovaFhKUmNDTWErYjd2d2VibElHU0tXZHc5bkRtOUExQmI3VHJUSGlkU0xJ?= =?utf-8?B?RlBXWGdMQ3RBamdycmZ2SGE0MS8rSlVRbkhoT2dxU3gwRWVxc0hvQnNwQk1r?= =?utf-8?B?Vi84dVU1eTZhcWV1bmdFckFONWxuWlcxSDRmWVZJUXVsamZLQzJIdHByRGlN?= =?utf-8?B?R1ZIbG93RjZ2Z1YxVm1laE9IS1lxWUl0aE1XbXdzYld2QWpiZTBZcDZBa1Bv?= =?utf-8?B?aXEzMDdEeTlRQkJPeUtsZ1ZEUkV1blBzbzhUYk9sOUZJRGhKNU9LZkE5VkZw?= =?utf-8?B?Z1lzNzFrZ1FqM0FKd00yQVNVRmpqZEJqcmthM0pBVzIxSjFmc3IrQVVldDEy?= =?utf-8?B?WGkzS1ZIUmlNRkpkV2gzdk5VZXo3YkhMUGxNNk1uNVdmOW1hVW5qNndvcm04?= =?utf-8?B?VEpIekJ4dmJYekdlZWE1MTVEUk00bkVkVXBqSUc5VzdhRGNrYUtTcjlWK002?= =?utf-8?B?ekYxa3V0Nk9PRWcvWTRZY2NpNHJSVk45MTVtbHpaTmxKR2o3dG5XYTRzWGo0?= =?utf-8?B?YVo0emI2ZlZYMTB6OElEV2w4OFJsWlYrMnVvWDBnTzNuengxZVp1a1NIVDg4?= =?utf-8?B?QW9pUFdobXZCZklEdmdHRS9rWE1XdGdkeE1hRDZVWnlrWVVscUVEc0s1Umcr?= =?utf-8?B?bUFFWUljN2RpVzdBdk5JaGliOXMvNldiUS9LN3dnSXVwNjAzaXIyYnpZMFk3?= =?utf-8?B?Ymh4ai9GVjhjWVNoVjI3WWZYbWhySmRrekQvSk1QQnZ0VkkrMlkza0pXZWMx?= =?utf-8?B?VFhDRmUvczhveS9hOXAySXJ3bHU4RkxqL1JZQWxLOGtEVUpJc0x6cFVSaHRM?= =?utf-8?B?bEIxUFNuVEhGa0hBYjRXcElJdWlMalRlb1A2bkVlYUwrNVp5OFB4QkpNOVQx?= =?utf-8?B?Y0U2UDlOMUczaXg0ZFI4dFpIZ3lFTHllVTByV0Q3QVd6Wk02cDhIK2dSak1z?= =?utf-8?B?a0g3WHdJZ3ozc1hGdlNzcHgvdTcreW1xclBwNUQ4ZWVrYXNpdi9Sem56U0ZX?= =?utf-8?B?Tk01eVRCaEJjaDM1UFpDVTlQbnBSUVR6Rm1xWmRXWE5VelZLOUtHclBOMU9I?= =?utf-8?B?SHphQzdUeXJPKzZvL1pqWXU0SWZtemJxVVp6VkxtYXhueWlSWVRUeGR1UlVy?= =?utf-8?B?TGhGc3lGOWNUbThzbVo1ejU2MGdteW5FWDZqTlMrSUtYZ1BRdVh1QmN5TnJV?= =?utf-8?B?YnQvOHJEelQ4NENTYXNrMVp1Yk5rOHMxL2V6aTFJVDNwaWhSemUxQllzOFd3?= =?utf-8?B?bWozZmFvbHYwVmx0bnFrMzdqTDRUWXg2eVJ6RlpYVUp4aVp2dU5FV3p2Tkpj?= =?utf-8?B?cWwxVlM3TmhydVgvV2ZoOVhDdUU5dCtMTHlhTXhxdXhWWE9FYkh0VW1ITlBh?= =?utf-8?B?bVd0cjVLNTRtK2IvRWw3ZVRNdFV4TkpXSm12VmlHRTBvNk5RcmV2WUlLTVVU?= =?utf-8?B?eVY2OUZONkdYanZvcTV2OUdDdk1jVzFhVXREYkVrRHdmRDFIMGE1RE10c1pH?= =?utf-8?B?dTJMb1dJdTFyTEd3V1ZhOUZoQWpqRFdYWS9LTytlcGVjc3RqbDVrUW5Uekk5?= =?utf-8?B?Z3ZobkZ1RVNaQVIvd3VGM2R2ZzJ3QlUxMTBSL0FJcko3QXhFaERQTkhUSUZL?= =?utf-8?B?NWVGZ2p5NzhoeG91OHFaalAvbCtJN3Ziai9pOXJ0RnRxRmU5RVYyd3k0Uktk?= =?utf-8?B?a2FhamRFR2xCZDJKRy9HNkJabnB5QmZiNHZIbzExQzFHazJNYm1JNWZ0c2Zs?= =?utf-8?Q?C//GMO6vaVqGLJxvwGyO0RW8X?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe231c0-0149-49fd-d772-08db82ad6e85 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 07:55:59.9456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6fqn7pUdHbNm66EYCs3lqm+RysPpcrQd4O31mYkHMP5Q5E1Uft+dCdzZ54k6RZ2KDtTanwd6J4hnUYHNGFVNjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6809 X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.07.2023 01:30, Mark Harmstone wrote: > Thanks Jan - this looks good to me. I've committed this yesterday, so Nick - what about cherry-picking it onto the branch? Jan > On 7/7/23 14:47, Jan Beulich wrote: >> Copying one too many bytes can corrupt memory, detected and reported by >> glibc on a 32-bit distro. >> --- >> Nick, again I expect this wants to go on the branch as well. I'm sorry >> that I didn't get to look into this earlier; I had noticed it a while >> ago already. In any event I'd like to give Mark a little bit of time >> to reply (if necessary), before putting it in. >> >> --- a/ld/pdb.c >> +++ b/ld/pdb.c >> @@ -880,7 +880,7 @@ add_globals_ref (struct globals *glob, b >> g->offset = bfd_tell (sym_rec_stream); >> g->hash = hash; >> g->refcount = 1; >> - memcpy (g->data, data, len + 1); >> + memcpy (g->data, data, len); >> >> glob->num_entries++; >> > >