From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by sourceware.org (Postfix) with ESMTPS id 3FD693858D35 for ; Thu, 17 Aug 2023 16:28:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FD693858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUHCiJXjQK/bDBr/yQauRPxEUo3jq+n1HmYDvZB1Ffc=; b=O7r/95jW8AUwLGdU6PcFmRDswXbttjKwHh1Gu2cx0A6fEC3xRk9nnbqzh9mJZ/Fric2SAa8zgIID4/FP8GXibQtKd0xFrl61kWiiIcjnOrpHNCQiXVcNY1echisgbf0lkhw32WP5ZgJJUX86px/gEQ31H5n7Am7LMa8fmfWvckc= Received: from AS8PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:20b:310::7) by PR3PR08MB5595.eurprd08.prod.outlook.com (2603:10a6:102:83::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Thu, 17 Aug 2023 16:28:29 +0000 Received: from AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::65) by AS8PR04CA0002.outlook.office365.com (2603:10a6:20b:310::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.33 via Frontend Transport; Thu, 17 Aug 2023 16:28:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT050.mail.protection.outlook.com (100.127.141.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.17 via Frontend Transport; Thu, 17 Aug 2023 16:28:29 +0000 Received: ("Tessian outbound 1eb4e931b055:v175"); Thu, 17 Aug 2023 16:28:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 99d8dd6904f01a61 X-CR-MTA-TID: 64aa7808 Received: from 6fda0b0222ad.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7F75E191-6EED-4D74-9A62-5DDDAB89F622.1; Thu, 17 Aug 2023 16:28:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6fda0b0222ad.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Aug 2023 16:28:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ighPzAxfRjmJhVR9o+rn2qgUk0IkyFuRgthX4UomI37kXBM+u1QRcpRXx+xFvzxrmlIS33V8eAjktfKQYd3nZ9Pyu2mtnTpgHeDrP2PZw5xGFlbNc3zZe+5VjTMaTKYSmA18y3SU2w1mBqtbpQ+PJE1srZ++5iWvdI137stRHTKKoJZoyC7rmRQ+bVqB0DQSa92PNguaMah/fp/weF9pzTR515LTStjaSMvgY/AKbczUggb0M1GIBVsefMJz+WVpsBlf8XsgUJKXICM2BZnQHxpr9cA8SKNwsSEUWjOZ5xAO56Bh+/uG2etneuoWOBs18toslA3aQmdaWKh1OVwQEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUHCiJXjQK/bDBr/yQauRPxEUo3jq+n1HmYDvZB1Ffc=; b=bCoi46BI+W5uK7u4rmvdrmX2Vt8ysjrX6qdJTEOGq0VzEjdWTfGHGm76W3MRePyG+OOuB9/ZoZMRoidcAUHRaR2yuKr7kzwMnQhfcfzKCImp92KtPRVJW036vLYpoFR/cAa+O4WEIazDSOvTZjAlbCaZZIxolYFFH/DayE0XOrgtfJpdFCIlKGc41LSSrrtrHGenStb5I3TN6JV+PlbTXTkzXmeDWLWVmbAPrx8bITPqDU6n4GbQErg0Tsv0kTQiEDlqM2rLes9B10pwCzJQZci85tcg4d1dqy2i8ss7H5U2xlGazWvx0KpFVhlec9hletZZ55J2IAOyhxG2j2Ivkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUHCiJXjQK/bDBr/yQauRPxEUo3jq+n1HmYDvZB1Ffc=; b=O7r/95jW8AUwLGdU6PcFmRDswXbttjKwHh1Gu2cx0A6fEC3xRk9nnbqzh9mJZ/Fric2SAa8zgIID4/FP8GXibQtKd0xFrl61kWiiIcjnOrpHNCQiXVcNY1echisgbf0lkhw32WP5ZgJJUX86px/gEQ31H5n7Am7LMa8fmfWvckc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GVXPR08MB7845.eurprd08.prod.outlook.com (2603:10a6:150:1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Thu, 17 Aug 2023 16:28:19 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2%6]) with mapi id 15.20.6678.031; Thu, 17 Aug 2023 16:28:17 +0000 Message-ID: <626d0655-43f2-c7f6-4e61-060c73cf1d48@arm.com> Date: Thu, 17 Aug 2023 17:28:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] kvx: New port. Content-Language: en-US To: Paul Iannetta Cc: Nick Clifton , binutils@sourceware.org References: <20230721074956.7188-1-piannetta@kalrayinc.com> <7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com> <20230724123338.r27dhowqkwzqgt4u@ws2202.lin.mbt.kalray.eu> <886f77cd-8cee-d530-64f0-c09cb9643a93@redhat.com> <20230726073623.eaczp74zhock7dj7@ws2202.lin.mbt.kalray.eu> <20230726212435.bd5zf3azsj55ejme@ws2202.lin.mbt.kalray.eu> <20230802143845.icdkwvkvdfkjjpgu@ws2202.lin.mbt.kalray.eu> <20230817150953.cyi5falukouuz3re@ws2202.lin.mbt.kalray.eu> From: Luis Machado In-Reply-To: <20230817150953.cyi5falukouuz3re@ws2202.lin.mbt.kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0025.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::10) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GVXPR08MB7845:EE_|AM7EUR03FT050:EE_|PR3PR08MB5595:EE_ X-MS-Office365-Filtering-Correlation-Id: e1a32a76-ee31-4210-dac9-08db9f3efdc9 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4kf5KtLJyLy2GIjSN4Ds6Jpw2LJQK+uTIgXdvMDNaYhX02xLbZ9uBYHS+ok1mVwxJHZyK40hJQM0+MRIWtwhDI5KqmAVUsLOGM9h/R6pY24NrGNzyks1nNPChU3rq+vnRXdcTe5G3I4EIe0x/HvIdf1WKsNrARH0rZllWXyxGeSDBfVTIDISyg/sNcpPBXiIWumPqPQwC0oJNJYoN2Lrk/jfeg2PnZFaRIX+tjanPi5UxUWdSOE3ALy9Ch3gzGwWi4cfOkVdODKfA8U2KkfUSV92emxkOapFqBQ6hq+RIRfA4yTJqDfWwI7+PmCqm9ERGhOh3LTnht9QbppbNIYVR84tfs9NKIT656KJO84fBPwq3edtYmC7C4ua8ghCkd7ce95d57D+GUvPRmCv6vVmw7dBR5clgeDbGc/vZwU2sGPmIKMU/W7vh2/E8xVD19uP6A8MJcZisOCUcZUAQ5oFEhPqqvWKgUW1zbVex/S8ajaXsErdPbJfQqbrISoiF/D+FUyz2kmoVlEeOQ4jQkIysJygCoj2SI+9QkrozSbVusyIZ8YL1/XN6MZCgeKIeAYIAyC6k6adhsw9Tm3k2PcaNC7OdVB32BfcaOOXAtPcr+jAwgPamQElVQn1sFzIoraA5iAxpfum73k+d1eMBjmyRg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(376002)(39860400002)(396003)(346002)(186009)(451199024)(1800799009)(31696002)(2906002)(83380400001)(26005)(86362001)(478600001)(36756003)(6506007)(6666004)(2616005)(6486002)(6512007)(53546011)(966005)(44832011)(5660300002)(41300700001)(316002)(66946007)(66476007)(66556008)(6916009)(31686004)(4326008)(8676002)(8936002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7845 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a2e42e49-3137-45e1-b5ca-08db9f3ef5d8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aT0x/hLfF8Yf4Dgh+tH/dHSJdrRq6MboynoVlqPZEILPkoTyk+ZjqhdO5TuFkVH95p0nm9NZ7OGAMdiHHBb/wly/CUtWb9PY5r7xe3xcLgyrn+VorR6mHFp37oYnHfG7veckp4hgZt15MnqtyqAjkXmLWulUe2P7dfY526AhWhzbJ61ECDeIieQsH7Ig+nx9dgf98w5cdSfLNJPAYi3ZC6u2j1PMY6ae2ERLPvkFUcIYOEBbN86W6D9kJotD8gGws3efzX0trPFH+nSY77RssYzv7NnLmB0RTXVqeBOvv7po5yzvkzjpedHnmvOnMIA/V8KMHkjR0g+PS/l+T4B9eHPW989Zk1Ucj6WygEtMqOJkmDDBZqSPQ0kiAiN4hoVOti977j5Dn5Mtj/ydo/AmtiHupdyfBVnKUiPfiZ3Sp1+KGJ/5vDcDcUDCjmc6uSOjI4vZtxAH9PXdiUG311Dxm6Qut4vpuiDPypRDf5hUxmiQQuiWL55FhjpR8jJdvS+4IN6cLvWEBvNwRTBC75b0SP+M5UTKL+7qYcrdcFsp603igbOrtE8qZJxLwgG2sfb6bZII+0LnGUQDxSCHIFdF3WKunoyJBMLIcl8q7k4Jg6kBBKM9WqsAVREkclwMmBX3DuyCxitkx0K+GmB1AtvoU+26JhW5oDSfri0vBQ8cyLs7ZIBJROYEBUaTTTrqD607qWAqv4YU1JwinBvNywdJGT0LRCMgnLHmHDrvWQcowSpB3SR/SGHz8zDdkSGegBePRdM7zwosyhjQ7s539uo3aQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(39860400002)(396003)(346002)(186009)(451199024)(1800799009)(82310400011)(46966006)(40470700004)(36840700001)(31696002)(2906002)(40460700003)(83380400001)(26005)(86362001)(40480700001)(336012)(478600001)(36756003)(6506007)(6666004)(2616005)(6486002)(6512007)(53546011)(966005)(44832011)(5660300002)(36860700001)(41300700001)(82740400003)(356005)(316002)(70586007)(70206006)(81166007)(31686004)(4326008)(6862004)(8676002)(8936002)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2023 16:28:29.7085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1a32a76-ee31-4210-dac9-08db9f3efdc9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5595 X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, On 8/17/23 16:09, Paul Iannetta wrote: > On Thu, Aug 17, 2023 at 10:45:09AM +0100, Luis Machado wrote: >> >> The builders have caught a few hiccups related to printf modifiers for 32-bit architectures. >> >> Could you please take a look at those? A build with --enable-targets=all is recommended >> to catch those. >> >> See https://builder.sourceware.org/buildbot/#/builders/170/builds/3977. >> >> -- >> >> In file included from ../../binutils-gdb/bfd/elfnn-kvx.c:22: >> ../../binutils-gdb/bfd/elfxx-kvx-relocs.h:74:3: error: conversion from ‘long long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Werror=overflow] >> 74 | 0xffffffffffffffff, /* dst_mask */ >> | ^~~~~~~~~~~~~~~~~~ >> bfd.h:3204:15: note: in definition of macro ‘HOWTO’ >> 3204 | src_mask, dst_mask, func, name } >> | ^~~~~~~~ >> ../../binutils-gdb/bfd/elfnn-kvx.c: In function ‘elf32_kvx_stub_name’: >> ../../binutils-gdb/bfd/elfnn-kvx.c:740:28: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 6 has type ‘bfd_vma’ {aka ‘const unsigned int’} [-Werror=format=] >> 740 | snprintf (stub_name, len, "%08x_%s+%" PRIx64 "x", >> | ^~~~~~~~~~~ >> ...... >> 743 | rel->r_addend); >> | ~~~~~~~~~~~~~ >> | | >> | bfd_vma {aka const unsigned int} >> cc1: all warnings being treated as errors >> make[3]: *** [Makefile:1758: elf32-kvx.lo] Error 1 >> > > Hi, > > I was not able to fully reproduce but the attached patch should fix > the build errors. However, we did not do any validation on 32 bits > hosts, so I think that even with this patch it will not be enough to > pass `mack check'. I'll work on it so that everything pass by the end > of the week, so you may want to wait until I have also fixed the > validation before applying the patch. Thanks! If 32-bit is supported for kvx, you might want to give the testsuite for that particular mode, just to make sure things are sane. After pushing the changes, you may want to keep an eye out for the following: https://builder.sourceware.org/buildbot/#/builders?tags=binutils https://builder.sourceware.org/buildbot/#/builders?tags=gdb You should see some going back to green. > > Paul > >