From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 893463858C36 for ; Tue, 28 Nov 2023 01:25:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 893463858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 893463858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701134727; cv=none; b=lwX18e/cDcwU8QUNnDvyKedAEc6fam6Q8JsMKYy/DNfYVmGUfUmFKI3WZAQG34Y9Djd4ycaX4nRu3ADf1iaJYwoWhzUXqlPmAsSlB674T/sCeiVjqlFB4nrKvt7tyz592tWHLPOR0/5lwITJH/M9f/jCzLIvPDJftO3MeEO6HMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701134727; c=relaxed/simple; bh=ilmu4t2DP4iI+gzQCxj9X13G01Tm70LQDt7FC5I6UNA=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=I4JE9O2N3BL16pccKnsqxuMQgyfmnKuzQQWFuxSH9WeeMBgB6QhEb02luxpNxcSWkzcQffjaXhlUIJ3wWAYm5fIbN2EoWEoEpmvh61JuHRNFlAyViUN+KW3biSau5fs4tAH4w0iE8H/4CG/XNImQ1+wSGd/Mgbnf+UkxE3kucZ4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701134723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ilmu4t2DP4iI+gzQCxj9X13G01Tm70LQDt7FC5I6UNA=; b=FSvNWLHdD4KjqvPDvLR9xKmh4F6eKJ3iPKgG/OGXVXc9uNa5Arq3c8mCrFoMexBBOyNHDw mmLHImQK7V2i2eCMebqu1E7ohYaiuZjZGIhIdWnpw32SSBUNJMV6EYz8G1ZjYRSvhzmSP0 S7Qy5XAVxaxu8gTnglA0Vn5DZ2EJ83U= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-WUA3X57mM9-_dfSQpDEhNg-1; Mon, 27 Nov 2023 20:25:22 -0500 X-MC-Unique: WUA3X57mM9-_dfSQpDEhNg-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77d62634693so941402485a.0 for ; Mon, 27 Nov 2023 17:25:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701134721; x=1701739521; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ilmu4t2DP4iI+gzQCxj9X13G01Tm70LQDt7FC5I6UNA=; b=dDE+wk52tkuv6+ekNtYd5j3/koEUj6V6ZygJQa/Tm41Sln/4EUMJ3KFoLirITmIl+t +jTVYEDJddj3AjCfHBe5G94oFhijvoIjEiHED8H6uT4WQSW58ISpqpEYhbj7PJAVnROQ qzih/zWxbMXx5Iv9sZx+ECdQy5AxdrtDxwCr4JElyfnHzBsF44wcKg5i8KTUDJ8PPxbj +J4yG9tJw4KfqaRAiuTE1TYGmA0KI/meN407h8U6L6ozGKlzmkssZ0qm6c06iS7SL/FF tv55+0xonMiWQzBvuxvf3vJJuKyzgGOIPQzOd5q9ysmz7WaVOuBKot1nIXduK+ZO9/GH mD5Q== X-Gm-Message-State: AOJu0YysIUCc0Lp9734Ba7XtB42/L7vOoNqoM6fAaRfPVelByyCZ1ZCS M9gESyXWHmzkauRPZXw895px1ZAytB9VqREPZZ/RMagS2VGcQFDyo6D9N24FN2+kLu7mfATTW3a eEYzZmQKDLo7SOLn9JQ== X-Received: by 2002:a05:620a:24c2:b0:76e:f686:cad8 with SMTP id m2-20020a05620a24c200b0076ef686cad8mr29617470qkn.13.1701134721734; Mon, 27 Nov 2023 17:25:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpL5qjA39NbARwRLJzBPnqJtmr6G+Jo0jQv1sng++Pg8hGVS3iaUk548i82a7sukz5GGBVWw== X-Received: by 2002:a05:620a:24c2:b0:76e:f686:cad8 with SMTP id m2-20020a05620a24c200b0076ef686cad8mr29617453qkn.13.1701134721549; Mon, 27 Nov 2023 17:25:21 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id d13-20020ac851cd000000b00419b5274381sm4146306qtn.94.2023.11.27.17.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 17:25:21 -0800 (PST) Message-ID: <629ac1d7c30f2a773f07d8009f9d7c78f6e9422e.camel@redhat.com> Subject: Re: [PATCH 4/5] diagnostics: add diagnostic_context::get_location_text From: David Malcolm To: gcc-patches@gcc.gnu.org, binutils@sourceware.org Cc: Nick Clifton , Simon Sobisch Date: Mon, 27 Nov 2023 20:25:20 -0500 In-Reply-To: <20231121222019.646253-5-dmalcolm@redhat.com> References: <20231106222959.2707741-1-dmalcolm@redhat.com> <20231121222019.646253-1-dmalcolm@redhat.com> <20231121222019.646253-5-dmalcolm@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-11-21 at 17:20 -0500, David Malcolm wrote: > No functional change intended. >=20 > gcc/ChangeLog: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* diagnostic.cc (diagnost= ic_get_location_text): Convert to... > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(diagnostic_context::get_= location_text): ...this, and convert > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return type from char * t= o label_text. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(diagnostic_build_prefix)= : Update for above change. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(default_diagnostic_start= _span_fn): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(selftest::assert_locatio= n_text): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* diagnostic.h (diagnosti= c_context::get_location_text): New > decl. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Not a bugfix, but low-risk and useful for libdiagnostics, so I've taken the liberty of pushing this to gcc trunk as r14-5895-g93096d3ce14a89. Dave