From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 6D1833858C78 for ; Wed, 13 Dec 2023 08:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D1833858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D1833858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702455565; cv=none; b=nFijCwTcoQbKnAH0whv9+/tTHp9t8w2N9QOHVzDSnLovh2LvygLuOdweKWL0O0tVa2o87ub0n8JRfCsfhz8GhkjX9eaz1BLoA7/JatSgIDwV8Sv4JZGXkG1A5M9feQaEJZWcAGVePbVi5S4eu56NEluU6RLggaRW+6tosIQFCfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702455565; c=relaxed/simple; bh=1Znl8Foq/dKxwrQNSNdavm4C/EnfReeRYmeNC57epe8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IAG1K29zXqL1ncgVw8Km6UOL1k21Ybe1KCkd6sB3Q/0EDMRl7NKI3yNVRx+Hj+J5NfiQCtOU6EsuoWxETh71zb/gWSKu2hg0ET/1IKFSwwJ8YyzhR46FuiToXnbIzxomAipAUZ/+u6CjYsWmNXpESSMjMUQ6ucdidlBYsUb5YDU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a1e83adfe72so610351766b.1 for ; Wed, 13 Dec 2023 00:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702455562; x=1703060362; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YM8ZHjHwoWnPEAgOImIDymUtNNJ0/bIg/A17WZ2DYIQ=; b=CdjC7UbX4p63XpV3Z5UbqyPrZaIBdEvEqrGG346SQRUkl49t/UFMiVi0rF7Q76JYh1 nWL86DeE+L96e1CYfwWhqm5wEW0jekTU049cej3d+EU9D8ampU5EKy2MiKJB2acW4vhB g8QpA50Xu3p3BUfWdltInSHIejn6BlSrxF5D2G4LpMrAWPgMRlQnHPZYa0RNecZK75Jv yGuXDBQV0iNEnTMTFodwqnlA6ghvbNV8/zUb+7OGlNd+I4ZErSNxb0e63FojLUuWLYrj wsXFAQkWtTBYbKQneWWQUyJGumAgp5vpD7ltOAeLifdQ1bsgsygxcYaN79dRmW4KyJNI LMOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702455562; x=1703060362; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YM8ZHjHwoWnPEAgOImIDymUtNNJ0/bIg/A17WZ2DYIQ=; b=X7FBE3S7ONlR5tMbu2PDXwiEc9DSWanzCmZhd1HktcnIiasFPE3osl2z6nCxzDGGXV 5n1mADuOepgMCcJwENqKV53DJordkUyeUSb9AlcJQ4A5C9z2NdFvoXFTo0rSxpKqxlss f0sPx7Qph57xqUap7WPpP0oZs3Ux7bUxjZP1oqAjJ37NP+wupGKjlqtTAld5P5epdM02 OhevAB90PTFC3PsdexP8/tEfEhv6BzfuAocvMhc+tRg/mvhWaMhgSIMRhiJTQCUX6rwC XN8Tir+KS7hSK6OL6/d3wicNiYKwIc3DLd0BSDlgfMeZObmhZbQo/lbERitShA12TgMU 08fg== X-Gm-Message-State: AOJu0YyFCmP8pYbXPOlgjgxf/wxCktusCj6zbavQv3hxx2zMJCmVVmul lLrzwwoEhmVBn8WTRmpz+Okl X-Google-Smtp-Source: AGHT+IEsQznPF572tUakIskGpSdpJ92rgrq3tQPc5wgs/FVLUxmnx7FviNwKfJNn04MwyxfE2hFWFw== X-Received: by 2002:a17:906:af11:b0:a12:635d:fcd1 with SMTP id lx17-20020a170906af1100b00a12635dfcd1mr4659285ejb.35.1702455561970; Wed, 13 Dec 2023 00:19:21 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id wb8-20020a170907d50800b00a1cb351dd4fsm7384505ejc.9.2023.12.13.00.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 00:19:21 -0800 (PST) Message-ID: <62a97390-3c4e-42ab-b56b-a1f11af851b7@suse.com> Date: Wed, 13 Dec 2023 09:19:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/9] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Cui, Lili" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-8-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13.12.2023 07:06, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, December 12, 2023 4:46 PM >> To: Hu, Lin1 >> Cc: Lu, Hongjiu ; binutils@sourceware.org; Cui, Lili >> >> Subject: Re: [PATCH v3 8/9] Support APX NDD optimized encoding. >> >> On 12.12.2023 04:18, Hu, Lin1 wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Monday, December 11, 2023 8:28 PM >>>> >>>> On 24.11.2023 08:02, Cui, Lili wrote: >>>>> --- a/gas/config/tc-i386.c >>>>> +++ b/gas/config/tc-i386.c >>>>> @@ -7148,6 +7148,58 @@ check_APX_operands (const insn_template *t) >>>>> return 0; >>>>> } >>>>> >>>>> +/* Check if the instruction use the REX registers. */ static bool >>>>> +check_RexOperands () { >>>>> + for (unsigned int op = 0; op < i.operands; op++) >>>>> + { >>>>> + if (i.types[op].bitfield.class != Reg) >>>>> + continue; >>>>> + >>>>> + if (i.op[op].regs->reg_flags & (RegRex | RegRex64)) >>>>> + return true; >>>>> + } >>>>> + >>>>> + if ((i.index_reg && (i.index_reg->reg_flags & (RegRex | RegRex64))) >>>>> + || (i.base_reg && (i.base_reg->reg_flags & (RegRex | RegRex64)))) >>>>> + return true; >>>>> + >>>>> + /* Check pseudo prefix {rex} are valid. */ return >>>>> + i.rex_encoding; >>>> >>>> Can this actually happen, when we're converting from EVEX to legacy? >>>> (Initially I wanted to ask about "rex" and alike prefixes, i.e. the >>>> non- pseudo >>>> ones.) >>>> >>> >>> This is to align with check_EgprOperands. I hope the function be more general. >> Not just for this optimization problem. >> >> But then the comment shouldn't say "REX registers", and "Operands" in its name >> isn't quite right either. >> >> Also you want to make the function be a proper modern declaration, by adding >> "void" between the parentheses. >> > > I have modified the comment like " Check if the instruction use the REX registers or REX prefix." And function name is check_RexOperands_or_RexPrefix. How about check_Rex_required() or is_rex_required() or some such? No need to have two "Rex" in a single name. Jan