From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7DC8E394742F for ; Mon, 25 Jan 2021 11:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7DC8E394742F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-4amQQKKQMtOpS9vwIqDiZw-1; Mon, 25 Jan 2021 06:05:02 -0500 X-MC-Unique: 4amQQKKQMtOpS9vwIqDiZw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55C2D802B46; Mon, 25 Jan 2021 11:05:01 +0000 (UTC) Received: from [10.36.112.14] (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B54C60871; Mon, 25 Jan 2021 11:05:00 +0000 (UTC) Subject: Re: [PATCH 1/5] bfd: add elfcore_write_file_note To: Simon Marchi , Mihails Strasuns , gdb-patches@sourceware.org Cc: binutils@sourceware.org References: <20210103130300.21637-1-mihails.strasuns@intel.com> <20210103130300.21637-2-mihails.strasuns@intel.com> <618186a8-b1c4-43b8-ff06-46c1d520d5d0@polymtl.ca> From: Nick Clifton Organization: Red Hat Message-ID: <62ec3fd4-404c-c84f-fe12-4bdef212ce0d@redhat.com> Date: Mon, 25 Jan 2021 11:04:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <618186a8-b1c4-43b8-ff06-46c1d520d5d0@polymtl.ca> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 11:05:08 -0000 Hi Simon, > Adding binutils@ in CC, can someone over there please review this change? >> bfd/ChangeLog: >> 2020-12-17 Mihails Strasuns >> >> * bfd-elf.h (elfcore_write_file_note): New function. >> * elf.c (elfcore_write_file_note): New function. This part of the change is totally fine. Please consider it approved. Cheers Nick