From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 218CF3858C50 for ; Wed, 23 Mar 2022 14:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 218CF3858C50 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-rSgGjCo8NliFNVZQSGAcvQ-1; Wed, 23 Mar 2022 10:14:33 -0400 X-MC-Unique: rSgGjCo8NliFNVZQSGAcvQ-1 Received: by mail-wr1-f69.google.com with SMTP id 41-20020adf802c000000b00203f27bebddso548294wrk.21 for ; Wed, 23 Mar 2022 07:14:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=Gv2eXap4KFD++6CO9MOln6tkUdRYWKMyfPSib/8Zzao=; b=zKb7ddOAsAtuCblrCqRejf+KWjuITkDy+SuJyLm+zf8C3AqVU6Z7Hpzg7SquUL0m7J TADkhV2+HAVimFg9PT4UcBCTqtLobFBZWfZhNl/4B9u8S1kAfROo+m6ZVaHCWrdzbqtO wYvym0lzhm33eftiUY8kYk6J+YJ86UuTSwUU19fo6WxyO+cdeYYmEXM4SBJ3XcpyVfQU akN+QFUbYop7AEtLn6wyuke5SwY6czoItqArzFD2fzd48eSIV3QshSPXdcgxpZXmG4s+ w8R928XNNVU84IhgPX/EMLP6jCn9Kh8NNUrOaFXJtI5i1zmVdMfKI+VR7mM4BBjMUs8u dBGw== X-Gm-Message-State: AOAM5336+bqsfUlIQrZXITUQlF1Ox9bTVwZEPh1mPFPfI5phZwLcMqil IbejEmbWKHaDNmUUoMF/t1wsJSuSgwGxJVrQkFfy00T2Q/uArl2Utd1vVRTyCDA/MS3/U+4kT61 9FBPuIkYM+KQOpToMEg== X-Received: by 2002:a5d:6405:0:b0:204:1ef:56e8 with SMTP id z5-20020a5d6405000000b0020401ef56e8mr17948399wru.677.1648044872712; Wed, 23 Mar 2022 07:14:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8fYbPwyGb4dIw81hMqNZSrAm5aBAmW9IGm2+vLyhnOxqxn3Cpx64WFYAtbsvMVN6Nca7IEw== X-Received: by 2002:a5d:6405:0:b0:204:1ef:56e8 with SMTP id z5-20020a5d6405000000b0020401ef56e8mr17948378wru.677.1648044872436; Wed, 23 Mar 2022 07:14:32 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id l11-20020a5d674b000000b0020402c09067sm3911wrw.50.2022.03.23.07.14.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 07:14:32 -0700 (PDT) Message-ID: <63191455-2374-5db9-f55e-ddf794c7d88e@redhat.com> Date: Wed, 23 Mar 2022 14:14:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: "Steinar H. Gunderson" , binutils@sourceware.org Cc: sesse@chromium.org References: <20220321094030.1256430-1-sesse@google.com> From: Nick Clifton Subject: Re: [PATCH] Add a trie to map quickly from address range to compilation unit. In-Reply-To: <20220321094030.1256430-1-sesse@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 14:14:37 -0000 Hi Steinar, > Add a radix-256 trie over the address space to quickly map address to > compilation unit spaces; for content_shell, which is 1.6 GB when some > (but not full) debug information turned is on, we go from 6 ms to > 0.006 ms (6 µs) for each lookup from address to compilation unit, a 1000x > speedup. There is still a slow part left in mapping to symbol name, > but this at least gets us halfway there. This patch appears to introduce some new failures into the various testsuites. For example with a toolchain targeted at x86_64-pc-linux-gnu I see: GAS REGRESSION: DWARF2 debugging information 2 GAS REGRESSION: DWARF2 debugging information 2 with SHF_COMPRESS GAS REGRESSION: 64bit DWARF2 debugging information 2 GAS REGRESSION: 64bit DWARF2 debugging information 2 with SHF_COMPRESS LD REGRESSION: Dump pr21978.so BIN REGRESSION: build-id-debuglink (grepping for source file name is disassembly output) These all appear to be due to lack of line number information. For example the gas tests are failing because they are expecting to see a line like this: ./dw2-compress-2.c:6 But instead they are being given: ./dw2-compress-2.c:? There are similar explanations for the other failures too. Please could you look into this ? Cheers Nick