From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63464 invoked by alias); 2 May 2019 10:56:48 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 63456 invoked by uid 89); 2 May 2019 10:56:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:790 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 May 2019 10:56:46 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEEEE59451; Thu, 2 May 2019 10:56:44 +0000 (UTC) Received: from [10.36.116.145] (ovpn-116-145.ams2.redhat.com [10.36.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25A507C5ED; Thu, 2 May 2019 10:56:43 +0000 (UTC) To: "Andre Vieira (lists)" , binutils@sourceware.org Cc: Richard Earnshaw References: <19569550-4d2e-0bb3-592a-d91050d490f6@arm.com> <70aab06d-34c1-476d-e760-59ac05f645df@arm.com> From: Nick Clifton Openpgp: preference=signencrypt Subject: Re: [PATCH 2/57][Arm][GAS] Add support for MVE instructions: vpst, vadd, vsub and vabd Message-ID: <632b1db8-acee-6152-1720-a6a19ff6bb81@redhat.com> Date: Thu, 02 May 2019 10:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <70aab06d-34c1-476d-e760-59ac05f645df@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00097.txt.bz2 Hi Andre, > This patch adds most of the framework used by the rest of the GAS patches for MVE. I noticed that this function: > +static int > +check_simd_pred_availability (int fp, unsigned check) returns an integer value, but it is only ever used in boolean tests. IMHO it should either have a bfd_boolean return type, or else an enum with the return values having textual names to indicate their meaning. I also saw that in do_neon_logic() there is a test against the function returning FAIL: if (rs == NS_QQQ && check_simd_pred_availability (0, NEON_CHECK_ARCH | NEON_CHECK_CC) == FAIL) But FAIL is not one of the values explicitly returned by check_simd_pred_availability().... Cheers Nick