From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by sourceware.org (Postfix) with ESMTPS id 3EEE238582BC for ; Fri, 15 Sep 2023 08:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EEE238582BC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJWcPnIMCcEpt+9Iw7cK5gX+t+9VdviGPv9A2huj737s7nCQOZvz94ERCYDbNjy7oOjcptOJSxiNpD+nfeh/X4ico+pF49hQ+8cbuUJOpOKUDWFRbbs1+8yvlAdzBTFpN916Gv2v3Ey3o/bV83WaGiy8ra1sKBK8bJNAnf7EJtPtRZzT9jEIa+jbdHxC+e9Sfz7k6u3LhGM8WPpHyPy/A6DIbpfKiKxM6fWgrI6lT5axuioayRredmayT0RECfghW/jni6pGnEhtKNZBQ3Z6vhEOzg8zID4tkTUfbYkSoI4p87/8D6mVCKHUaq1DzhUd52IZ52ahKL/jkndpW3pAbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ysXwf95WRIwbjwRfsA9PxhzMqlzOcD0slkZ9BPkcVc=; b=ePcfdn4i/o6FmWGh2JGT0cA9EY9E5xYhjF35hnNBPpmmV63aY/hnqa47FWsGNs22z/uSsdA5XjriHHxgvQ6THdwa0PsXmQB+wu7dzmGgoEpKxgCwghosqS99TcSU3u+hQp/qNaMbQKwa00aBSH/O6ZFzWXzwqQeePMeyaiFmqNi5dDGr05b8YXfEw5N0fMfSWRIOv7VpOuIQ/jPhQJwwv2RO+1IcFaciokfLOmgdNN7/TFec9mxbuY6Khajvm1Bgo/bfXju+2WTkxdZnDmo1duiKzZWVgdU4sgAyYm3okneyPIKklHnwYR5sDGcfnJZErqDLcqgb8rA10+yNx4qU7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ysXwf95WRIwbjwRfsA9PxhzMqlzOcD0slkZ9BPkcVc=; b=TqdBQ6KQz/7BnbGJLdems7GQJfFVBS/DgbCuy8PzMs1d+rk80oAkei8NUlGv2q3GYxk4JcK8A5o627nrbc8Fmg1cr8EuXmNdN8O8lzpFDgVbp8FvSZnMbmnfKe7g9lkTHF69GKQ1XbYqllFMlGt5K/6SmfJQnV756YhwM1cXtUszd7lJa4wfqnqtJm0mJG3CTNiulInVE0TqtAPNZ2x1UWAdQ+Vni0E3cEDLr8+OSeuCt5mQAIU3EUeFu9Opyk0wKZgMTv/rvbr9UgrRNUoNTSaRK+3gdfDlXZ6xs9kMEB/pG5TOxeov0hxlyQQkjjEdGacVEPyJEKvWcV2WCSKk8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8530.eurprd04.prod.outlook.com (2603:10a6:20b:421::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 08:59:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6792.020; Fri, 15 Sep 2023 08:59:40 +0000 Message-ID: <635f1462-9704-efca-c034-f4bc39e706f2@suse.com> Date: Fri, 15 Sep 2023 10:59:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 2/3] x86: drop cpu_arch_tune_flags Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <8d21b532-7a4a-da25-3e95-d1aea76f75a3@suse.com> From: Jan Beulich In-Reply-To: <8d21b532-7a4a-da25-3e95-d1aea76f75a3@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8530:EE_ X-MS-Office365-Filtering-Correlation-Id: 10814b3f-a0ec-4c9f-2433-08dbb5ca18d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kzhHERjCGY0/pTTNp3yKjVf0E4wqC+RcYgh5+P3tq4GW7VWembjDJN5mrHmolJ76+DC14XdYmNbKIskStAI2gf/VDYYX6gLxRsBHS3oe9G5lLVAzObDvLa124/O1+D1fy+qZL/8RPGhq3e+HRmsTYFNtnQ9sj+zcYClIGF0aCnSLsS+sEToGZAKqbB6zNqBjoM7P6Na1C0yycoe8OQvCXybkvqk/hGa8Pu0ShLb/djxh2guqgUGDJJUyA072mgwh+vKaJ6p+xKrlqsrhf1qA+ZwYU849oMdC7i3QrYyvgbm7/X0w+xb0v/EdCCU+cXzurp5JzL0hh/1zn01GawI1fQP/SSVwVc8Rznpk0Nj4o10ZJfcZI0GX+3yNcrqZhNMNCsc4qc2BYNELDs58GhLcUfeEFkGbMToyQ99MqllttjdsHXWTW3GJfMoAIJJoQtVUioANlhLMLHku8KWda7H7Hyg9mUjLqy8+EcQheA0fqcnUxaKMF5SD/FIahf4AgK4zS10pify5KRLRCq2CwfxCOk68eEKsDMS95Eb/pM+a7O9oQXtsZ8NPRBUO3YDVSj1gX6HvGEIZN6aIxlrdobVKBKbYCmjKPs2at9b4NnRyV/xphxLKIAUoCwUiF9FWLbCTGiR5Ykp8jK+4V9FB9nSLGA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199024)(1800799009)(186009)(6506007)(6486002)(6512007)(2906002)(26005)(66556008)(5660300002)(38100700002)(36756003)(66476007)(66946007)(4326008)(6916009)(316002)(41300700001)(8936002)(8676002)(2616005)(478600001)(31686004)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZyYnIrNSt6Q0E4dUhhZU9FczJwY0l0RXVlL2wxVkxJYmV1UWpVRWlOYkU1?= =?utf-8?B?YUlyN2JaNnZZK0lqUCtmMWlQTENRa1pGbDVYM09Xb3FvWTIxNGZiOTczd2ZO?= =?utf-8?B?TXlQVmpWNnhWeC8vaXlVcU82V25tRWpYR2NMN2tJS2svaWdJNFQ4NlJBTlhD?= =?utf-8?B?RHkvRHEwSGYzRG9xVHg0WU83aFNUSHdnYkg1b3Y2anMzY083c2x3TTFLQTVs?= =?utf-8?B?bUZRMUZEcmxFME51SzRhUTIzV2JNUTB1M2hDS3VCNDhseC9wR2sxOXdzWjN5?= =?utf-8?B?cnFnZWRXUlV4WEtCdDdqTmpRbEFXYnQ0M1VHRndRTHVURnk5ZW9nSU9jTHEz?= =?utf-8?B?VnNsOWJZYkNITVh4K2NkUmN5U1pveDRzcmRZOXRVVFdUaG5VSVdpdjh2bmtz?= =?utf-8?B?K1QrcjVIUHhHbE43aDl2S094VU9FNTFQam5rczJZTXNpeXFObXR3MWk1Vngr?= =?utf-8?B?SUp5SnNWdXZBSkIrcVBJdVZ0b05KT1gwUEVNbXg5V1BFdFltc2ZWbVZUY3JQ?= =?utf-8?B?VWJtVFhtN05XRnFobGdvc28vaUw1My8wRUQ2L20relp6d0N3bUVIc1IrSEpF?= =?utf-8?B?QUlRa2h1ZkppbU5NeFp5SVFvMlJJSDYzNVVsZkFGL1ZFRVcvbzh4VEtmRVpv?= =?utf-8?B?bWloRkowQVg0QlNDSDRNWEVrdGxza2xOTEVHOTFRRkZDN3NRYkt2KzB2RmdW?= =?utf-8?B?Q05MOWZBazFJYjhQZzNJKzEzcDNLeWNML2tPcTVMQThnSUhqSExjcytrbjZo?= =?utf-8?B?NlE2MkorbnhsRVRvZEdXTHF0cjgrbjU2Q3UzbFIwZXNmNmMvLzRFSHBUbitR?= =?utf-8?B?UDAxT3FrTkVIRmEwUDZWMkFNalFlc1c5OEVEUkFoU2dYK3BVTDdtTjRoVTNk?= =?utf-8?B?SEx3cDMxQ0FyeUFQNjBLNHd2dnhOYWNEL0FWTnlmekxjNTZsZS8xNnZOVnZI?= =?utf-8?B?NllBYW91Z0FEU0w1V0N5UU9YaEFvejU5dXdjTXllWGtBNmo1Nk4vVXVtYU9T?= =?utf-8?B?TU45RktjV201UG5abEZZcWk1TmJBMW1Tc3pzMTJRUzd5NkNxMklGMUJsYUVp?= =?utf-8?B?YmJCUThtL1Z0YU1PNzFldStBY2QvVGQzSm5iVXRBbU8rbXQxckROQ3pDWUd3?= =?utf-8?B?TEJwQmQrTUZ4Uld0VnFQdHZiUVlMYUpydk9tdHU5TVVmZ2NDMHpVS3Y4SVda?= =?utf-8?B?NEt2WXUrMnB1K3lkYTh1N3hFUklWSGJuTkcyUy9aenBIV0t2SDRvdWRFa1BQ?= =?utf-8?B?dGhmTHZpV3NMTWpZRXhoL3BjVzdxT0xkZVZoREVMeHdpWHZXOFliRVBaaU5Q?= =?utf-8?B?a1NiTll0QzFubE0yYzFCVllURXlmbHZ0RnVZQWx0ZFpNdDhZbXQwendndXRz?= =?utf-8?B?aUhPREl3czZRUkJPN0RnZXpnZnBwTks1UW5TcEVFMXJyRGJPclZhc2s3MVpj?= =?utf-8?B?RU1oMDZLb0FGV1BieHlYdkVXalZMTW9OVDlxaHlmQTVwNnE3UTNLTXFENkxN?= =?utf-8?B?cnJtR0htQTdhZm44MUFJeE9NdlovQUFtSExOaG5KbTRTQlQ1eEUxTXdMdkZl?= =?utf-8?B?ZGF3Y2pRUENxS0NLTVd1NFYrL0tWNWd0SkJXOHZFc2JOTEE2YmxHNk1Rd2hZ?= =?utf-8?B?UkNKRkxuYmxlN3h6RlZXZHJiTVVNUWtMeEpLb3QwNVF5cWQ3WlNmMmpQbzkx?= =?utf-8?B?Y1UwRXJIVHR5TU5UaUZWRG9sSWdoc0RXMmhxNmYxR29vZ2JQRzk5eGlLVUFy?= =?utf-8?B?d0EwWDlnK09aNjBqT3pCLzZENkRvZEE0clkrWFpHQ2hjRDl3OUp0Rlc1cG9z?= =?utf-8?B?K09zN1Y3SHJQWStQeWtNbzBHb0FFelp4ellHKzVndGpxUkNLcUxZVG9nTnpv?= =?utf-8?B?MkFlSi80Vk9qU1VscjZzQVdnTWdxZVpORFVDcWdFb21UZ09FOVM4Q28vTnVG?= =?utf-8?B?MzA4c1NCMjVKZEFOSEdHZGtFSnY1SThMaVowVmsvY2QyaDBubkJBSklBR2Iz?= =?utf-8?B?SW9mYUFhc2RRVHlld2JlZmhRZlVTZVYzS1AyMmp5SFI4Wk1iQnNnR3drenVk?= =?utf-8?B?ZSswZkhINkVlWG0xSVE4MTA5MWtobXpRc2NuRmVLMlFPUWY4MEVWWWFoVkNT?= =?utf-8?Q?/q6owKmm74y/8n8JPHQskHrJq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10814b3f-a0ec-4c9f-2433-08dbb5ca18d1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 08:59:40.8235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tLeGQS+iyla38rgdWStBsVaFLbzvy5ZTM9JFQ+B6dPJEI+9Nckyks3XSsp4bKIw6mXN8TZRWaIm2RKIe+QTV0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8530 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Apparently from its introduction the variable was only ever written (the only read is merely to determine whether to write it with another value). (Since, due to the need to re-indent, the adjacent lines setting cpu_arch_tune need touching anyway, switch to using PREOCESSOR_* constants where applicable, to make more obvious what the resulting state is going to be.) --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -816,9 +816,6 @@ static int cpu_arch_tune_set = 0; /* Cpu we are generating instructions for. */ enum processor_type cpu_arch_tune = PROCESSOR_UNKNOWN; -/* CPU feature flags of cpu we are generating instructions for. */ -static i386_cpu_flags cpu_arch_tune_flags; - /* CPU instruction set architecture used. */ enum processor_type cpu_arch_isa = PROCESSOR_UNKNOWN; @@ -2955,10 +2952,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED cpu_arch_isa = PROCESSOR_UNKNOWN; cpu_arch_isa_flags = cpu_arch[flag_code == CODE_64BIT].enable; if (!cpu_arch_tune_set) - { - cpu_arch_tune = cpu_arch_isa; - cpu_arch_tune_flags = cpu_arch_isa_flags; - } + cpu_arch_tune = PROCESSOR_UNKNOWN; vector_size = VSZ_DEFAULT; @@ -3000,10 +2994,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED cpu_arch_isa = cpu_arch[j].type; cpu_arch_isa_flags = cpu_arch[j].enable; if (!cpu_arch_tune_set) - { - cpu_arch_tune = cpu_arch_isa; - cpu_arch_tune_flags = cpu_arch_isa_flags; - } + cpu_arch_tune = cpu_arch_isa; vector_size = VSZ_DEFAULT; @@ -14597,10 +14588,7 @@ md_parse_option (int c, const char *arg) cpu_arch_isa = cpu_arch[j].type; cpu_arch_isa_flags = cpu_arch[j].enable; if (!cpu_arch_tune_set) - { - cpu_arch_tune = cpu_arch_isa; - cpu_arch_tune_flags = cpu_arch_isa_flags; - } + cpu_arch_tune = cpu_arch_isa; vector_size = VSZ_DEFAULT; break; } @@ -14678,7 +14666,6 @@ md_parse_option (int c, const char *arg) { cpu_arch_tune_set = 1; cpu_arch_tune = cpu_arch [j].type; - cpu_arch_tune_flags = cpu_arch[j].enable; break; } } @@ -15284,10 +15271,7 @@ i386_target_format (void) cpu_arch_isa = PROCESSOR_IAMCU; cpu_arch_isa_flags = iamcu_flags; if (!cpu_arch_tune_set) - { - cpu_arch_tune = cpu_arch_isa; - cpu_arch_tune_flags = cpu_arch_isa_flags; - } + cpu_arch_tune = PROCESSOR_IAMCU; } else if (cpu_arch_isa != PROCESSOR_IAMCU) as_fatal (_("Intel MCU doesn't support `%s' architecture"), @@ -15298,8 +15282,6 @@ i386_target_format (void) if (cpu_flags_all_zero (&cpu_arch_isa_flags)) cpu_arch_isa_flags = cpu_arch[flag_code == CODE_64BIT].enable; - if (cpu_flags_all_zero (&cpu_arch_tune_flags)) - cpu_arch_tune_flags = cpu_arch[flag_code == CODE_64BIT].enable; switch (OUTPUT_FLAVOR) {