From: Nick Clifton <nickc@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>, binutils@sourceware.org
Subject: Re: [PING][PATCH] binutils: Avoid renaming over existing files
Date: Thu, 18 Feb 2021 19:20:03 +0000 [thread overview]
Message-ID: <635f56e3-dad4-2449-ea1d-039415ff7bf7@redhat.com> (raw)
In-Reply-To: <6066dd62-aa26-40a6-c4ff-67a3cd22d4d3@gotplt.org>
Hi Siddhesh,
Sorry for the long delay in looking at this patch.
>> binutils/
>>
>> * ar.c (write_archive): Remove TARGET_STAT. Adjust call to
>> SMART_RENAME.
>> * arsup.c (ar_save): Likewise.
>> * objcopy (strip_main): Don't copy TMPFD. Don't set times on
>> temporary file and adjust call to SMART_RENAME.
>> (copy_main): Likewise.
>> * rename.c [!S_ISLNK]: Remove definitions.
>> (try_preserve_permissions): Remove function.
>> (smart_rename): Remove FD, PRESERVE_DATES arguments. Use
>> rename system call only if TO does not exist.
>> * bucomm.h (smart_rename): Adjust declaration.
>> ---
Approved - please apply.
Cheers
Nick
next prev parent reply other threads:[~2021-02-18 19:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 19:17 [PATCH] " Siddhesh Poyarekar
2021-02-09 3:33 ` Fangrui Song
2021-02-15 5:17 ` [PING][PATCH] " Siddhesh Poyarekar
2021-02-15 15:59 ` Michael Matz
2021-02-15 16:11 ` Siddhesh Poyarekar
2021-02-18 19:20 ` Nick Clifton [this message]
2021-02-19 2:37 ` Siddhesh Poyarekar
2021-02-19 7:44 ` Matthias Klose
2021-02-19 8:02 ` Siddhesh Poyarekar
2021-02-19 16:45 ` Nick Clifton
2021-02-22 15:30 ` Siddhesh Poyarekar
2021-02-23 0:00 ` Alan Modra
2021-02-23 2:23 ` Siddhesh Poyarekar
2021-02-23 4:44 ` Fangrui Song
2021-02-23 5:10 ` Siddhesh Poyarekar
2021-02-23 6:52 ` [PATCH] binutils: Attempt to retain permissions on copying file Siddhesh Poyarekar
2021-02-23 11:56 ` Alan Modra
2021-02-24 10:27 ` Siddhesh Poyarekar
2021-02-24 23:47 ` Alan Modra
2021-02-25 2:28 ` Siddhesh Poyarekar
2021-02-26 7:33 ` Alan Modra
2021-02-23 18:49 ` Marco Atzeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635f56e3-dad4-2449-ea1d-039415ff7bf7@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).