Alan Modra wrote:
> On Tue, Nov 03, 2020 at 03:31:49PM +0000, Howard Chu wrote:
>> Nick Clifton wrote:
>>> Hi Howard,
>>>
>>>> Whitespace fixes done, attached.
>>>
>>> Sorry for the delay in reviewing this patch.  This revised form
>>> looks good to me, so I have gone ahead and applied it to the sources.
> 
> I now see these failures.
> 
> alpha-dec-vms  +FAIL: ar adding library dependencies
> hppa-hp-hpux10  +FAIL: ar adding library dependencies
> i386-bsd  +FAIL: ar adding library dependencies
> i386-msdos  +FAIL: ar adding library dependencies
> ia64-vms  +FAIL: ar adding library dependencies
> ns32k-netbsd  +FAIL: ar adding library dependencies
> ns32k-pc532-mach  +FAIL: ar adding library dependencies
> pdp11-dec-aout  +FAIL: ar adding library dependencies
> powerpc-aix5.1  +FAIL: ar adding library dependencies
> powerpc-aix5.2  +FAIL: ar adding library dependencies
> rs6000-aix4.3.3  +FAIL: ar adding library dependencies
> rs6000-aix5.1  +FAIL: ar adding library dependencies
> rs6000-aix5.2  +FAIL: ar adding library dependencies
> 
> I think these are all targets that default to --disable-plugins.  The
> proper fix is to condition all of the added ar.c code on
> BFD_SUPPORTS_PLUGINS, including help text and option processing.  And
> then of course not run the new tests if --record-libdeps is not a
> known ar option.
> 
Thanks for catching that. This feature doesn't actually require plugin
support, that was a mistake in the previous patch. Fixed here.

-- 
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/