[patch] guard against null, coffgen.c

[patch] guard against null, coffgen.c

[msnyder]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Unlike some of the other macros, bfd_is_common_section dereferences
the section pointer.  Since we later check it for NULL, we ought to
do so here too, before dereferencing it.


[-- Attachment #2: coffgen4.txt --]
[-- Type: text/plain, Size: 1047 bytes --]

2007-07-25  Michael Snyder  <msnyder@svkmacdonelllnx>

	* coffgen.c (fixup_symbol_value): Guard against null; 
	bfd_is_com_section will dereference the section pointer.

Index: coffgen.c
===================================================================
RCS file: /cvs/src/src/bfd/coffgen.c,v
retrieving revision 1.59
diff -p -r1.59 coffgen.c
*** coffgen.c	12 Jul 2007 07:16:40 -0000	1.59
--- coffgen.c	26 Jul 2007 01:45:25 -0000
*************** fixup_symbol_value (bfd *abfd,
*** 562,568 ****
  		    struct internal_syment *syment)
  {
    /* Normalize the symbol flags.  */
!   if (bfd_is_com_section (coff_symbol_ptr->symbol.section))
      {
        /* A common symbol is undefined with a value.  */
        syment->n_scnum = N_UNDEF;
--- 567,574 ----
  		    struct internal_syment *syment)
  {
    /* Normalize the symbol flags.  */
!   if (coff_symbol_ptr->symbol.section 
!       && bfd_is_com_section (coff_symbol_ptr->symbol.section))
      {
        /* A common symbol is undefined with a value.  */
        syment->n_scnum = N_UNDEF;

Re: [patch] guard against null, coffgen.c

[Alan Modra]

On Wed, Jul 25, 2007 at 06:48:44PM -0700, msnyder@sonic.net wrote:
> 	* coffgen.c (fixup_symbol_value): Guard against null; 
> 	bfd_is_com_section will dereference the section pointer.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

Re: [patch] guard against null, coffgen.c

[msnyder]

> On Wed, Jul 25, 2007 at 06:48:44PM -0700, msnyder@sonic.net wrote:
>> 	* coffgen.c (fixup_symbol_value): Guard against null;
>> 	bfd_is_com_section will dereference the section pointer.
>
> OK.

Thanks - committed.