[PATCH] linker.c, check for null return from bfd_hash_allocate

[msnyder@sonic.net]

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Most callers of bfd_hash_allocate check for null returns.


[-- Attachment #2: linker.txt --]
[-- Type: text/plain, Size: 1154 bytes --]

2007-07-25  Michael Snyder  <msnyder@access-company.com>

	* linker.c (bfd_section_already_linked_table_insert): Check for
	NULL return from bfd_hash_allocate.
	(already_linked_newfunc): Ditto.

Index: linker.c
===================================================================
RCS file: /cvs/src/src/bfd/linker.c,v
retrieving revision 1.60
diff -p -r1.60 linker.c
*** linker.c	24 Jul 2007 23:38:13 -0000	1.60
--- linker.c	26 Jul 2007 01:55:13 -0000
*************** bfd_section_already_linked_table_insert
*** 2933,2938 ****
--- 2933,2940 ----
    /* Allocate the memory from the same obstack as the hash table is
       kept in.  */
    l = bfd_hash_allocate (&_bfd_section_already_linked_table, sizeof *l);
+   if (l == NULL)
+     return;		/* Should we abort?  */
    l->sec = sec;
    l->next = already_linked_list->entry;
    already_linked_list->entry = l;
*************** already_linked_newfunc (struct bfd_hash_
*** 2946,2951 ****
--- 2948,2956 ----
    struct bfd_section_already_linked_hash_entry *ret =
      bfd_hash_allocate (table, sizeof *ret);
  
+   if (ret == NULL)
+     return ret;
+ 
    ret->entry = NULL;
  
    return &ret->root;