From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2054.outbound.protection.outlook.com [40.107.104.54]) by sourceware.org (Postfix) with ESMTPS id 09C4B3858D33 for ; Thu, 2 Mar 2023 09:02:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09C4B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iZ4dFZs3MjgwtJHCYFmdT8qNPSQogmQAUtm2Z7pUsp7F3nNOaB9E3h/Va48nCkX3g/l38sH6qDYBqftS/SZ46gkRW5A3nM6xGau/YCsR6Ae2Ltm1omf2a9HghdyCZxYHr7/GQUMal8kDac29pA+wYIpeXmxYyPpsrYXL7eusBP8IX78Jk8tR8xmTy9dFDCHD0/3ab5vUTRmb2x6+UiE2MH9qq9lgPkLgdiaDrBlr+jj1cYgqWkAAoq2/6AYqd0UJNgTOq7XADXYGfYOkm5ZoRNpillQxvkmmdPO8e2CEuDU+MbAn0LlqYA9I/dndqnxQDLZGQfoi8pe59TPqBE+9eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ms488rOw/nseQaeHFcht1585H+mDQo4Iq6HrUPJUce8=; b=lufb6Mlt4IQ2gee5PMJT9d96Im2IMOm4ptz4ouvLGfhE/uZK3wkeU77xyR9C592abJtDq0ZOWvNYo9JsQA8y77QAz60kk/qnGAJWjK8z7TR5VdxXz8dUrKA/D9a6pbuFF9I1ua4YPRqtpFtVu0Psea+msrzfL040zUt3CCSI7bXPD+bhqcIZO/b64y8edvIRnnRceZBsJrasu4TnVAcehVsCUoO7wxSmSOp7A32kZvb1eI8LHDtEbzfu/QfyoUHzdcpCxK6H+DOih7rRNpal+7Wn16R009Bm1Dddtsgvtq+Y5OCrAT859Jjg4nIUGpZcI3pmLtwdDshnDZITRVtuWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ms488rOw/nseQaeHFcht1585H+mDQo4Iq6HrUPJUce8=; b=tpneORyomhsx9IOwLLMB1dlGdkfIyjtwHApcT4td3qw6gNh13kWTcuWr17WFkx54Xr3J2a/n+shdovnB1gNHlPPR8Wbm0OXFSc47zIK2dpGZEpPHdmNIXTdy0pPjrKF6SWp+8GwJiCqikEzgg004mBGi+7o4xC80FiB/Ak8saBEbVEl0ypvTeunpEQqPwJ8a5eiABJ4UjF6+/XlIuc3UK2R+WnWhQwqBlOl7sA50IujSIXExtC3QjBxydat6N9CJW2PL0Bl/hgpAcmTeXnPT8++Nzx6DTPgM5ztU05lzDZGnrK2kv1DY7FtpNQSzZ50CX/2W+MvTP7GFGGkSVBkWgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS5PR04MB9875.eurprd04.prod.outlook.com (2603:10a6:20b:652::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17; Thu, 2 Mar 2023 09:02:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6156.019; Thu, 2 Mar 2023 09:02:54 +0000 Message-ID: <6376e192-2b15-354c-e051-269245f3efc5@suse.com> Date: Thu, 2 Mar 2023 10:02:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RESEND] elfedit: add support for editing e_flags Content-Language: en-US To: WANG Xuerui Cc: Chenghua Xu , Zhensong Liu , Qinggang Meng , Xi Ruoyao , WANG Xuerui , binutils@sourceware.org References: <20230302081452.3429908-1-i.swmail@xen0n.name> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS5PR04MB9875:EE_ X-MS-Office365-Filtering-Correlation-Id: 850d6498-e239-45eb-d31d-08db1afce873 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J4i2CUe/aLEu978EqsOonC3LOtPay6eJzquxzvFdzNbK/fFTYWeeHTBXOuU/dCo/WPLe26C67KGbgbw1jbhfz8qGOPgk4XXaTQRnX1uuCf0J1HdSRWRO1qCoMIRf1pWeRDKklsLPJ/LM6/IPeJIdnSNS3dAMZxVxo58r6AH63woM20IG3+d4qvNF1lm566G17tBSeCTeQzNW/pTAbqDe7U769wCDrGjBNysIs900VS22QNSkkfdJJyORbHS2k8Kn2ZJdLL96hpTSnmnIbG+rhO2zAehi+FwQ3SFuEUg3Eg+qh1+oFAu242E4tckucC4JWfZvz9eFDEHK1iWV5P0lqRU5txP/6BEXPZPY5pXro+/snB1Mv1y+NE1lwYH+v4OoppxNizfjBw4vLpnH2MiYWJzv49opxhkgiP+m/vWOzvxF1IMHMAHMVqiRkdUbU8ppcEeDLzGJG1JCXvFlkVW4W1mv0YIOV1orJcX4H2TyUUwkPGOtEZuMlb91YX4teemr92oSxa2nLYvnqKdDIi8JI9ronO1jzx+TThec6MGemL2NVXrQ9IYhXBIsdALAsVDsKrccE4tPW+jElw5i6kuqS27MDtJ+seojpHtBAnb0NAj1HfnwTpCEnbusvsuvHVKqEQY1iA4KwHJ67qyy9/HXQZp09G8nLBruJZEhyeg9Uh6a6Q36L6cloI093JfKa0DEe5i6fhgvQAG7Mql27noZR2vrTgL5TJyh0Ww/8v+s3LA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199018)(316002)(54906003)(6916009)(8676002)(66476007)(66556008)(2906002)(66946007)(4326008)(36756003)(41300700001)(83380400001)(2616005)(6512007)(6506007)(53546011)(6666004)(186003)(31696002)(478600001)(86362001)(6486002)(26005)(38100700002)(4744005)(5660300002)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?US83cTBpV2paSUxXdW1BTjZxaE9ONlE1MGdpdkpydEdFdTRTNlZBZVFHM2ZU?= =?utf-8?B?UnVKU0w4QXZsdW4veE1hYUpmeU9LQXNWS2RlNlpWWjRiT0JpREN6a1BudGdL?= =?utf-8?B?b21Uek5NWFZxRHNRYjZrSFlPVTJLbXNIcmtCbHdoNTVjWGZleWZhLzk0c1o3?= =?utf-8?B?eE14SlRxRjZEWmNCaTB0NjZlVzltTmpOQkV5L0J6NTUySi9BRWRmSmJScUFk?= =?utf-8?B?aktMWnZ3RzFzYXB6RkY2eUJ0cDZPeDZNRlQxSXcrZjhWdk4yci9BOFh4N1FO?= =?utf-8?B?KzdjTS9xdjFzQ3U5MUdDeFM4VzQ0Wlo3b3ZaUDVuaFdSVHVaeDBMK0hSUEF0?= =?utf-8?B?UExuaTUyNHhiazl3bTlvMHc2Nk1mWTIrYVhQMTBucmpwQlc4SVVwVTh6bUgz?= =?utf-8?B?RjdZZ3ZLa2MxWWsrQUZpUlBXVVhLdyt3YWsya24xVmZaWnduK3JIUnZNWkRj?= =?utf-8?B?OFBySS9UVGZYM1VTNk1hbC9jMmFFTkZBZUVONm1GcXZDZ1RWRmFteEZzMVlY?= =?utf-8?B?Mmp6U3QvaGxjVU9zbzhzcjRtclZQVElqb243bUl2N3FVK0xIL0JzYklrT1ph?= =?utf-8?B?RWdCRlZSR3M4Zm1lMnB5TkpzcEtOZlpPdnptYm85TzFrTkQweDRUWFhKU2Rs?= =?utf-8?B?MTNoeWhVT0xCQ3M3NEhnYkRTc2Npcm43Y040aFpITTZUSWluWlVTL3VEWlox?= =?utf-8?B?cndnZVBTdTVETXZ0VEtaSVJpL3lKYW1EWVVPMnFvazRTZ29GeW9pd2w4amVD?= =?utf-8?B?eURmWlZWdmpWUW52SXdRaHMwbVhyRWdGbXZRdFZMRlg4S0pCdi8wZ3FNVVR1?= =?utf-8?B?c2xhbGt4NGFFcXppdzRtOW1YanFWa3F1TFJlQUtoNjJpL0NwR1JmR2UrMDZR?= =?utf-8?B?VnVIamNBYm5aTTI1cjBKaDlTSGlTY2pUWEdNbTU1eUJQSHhYRUpYTXpMV3k3?= =?utf-8?B?S1Q1enp2N1c3REtKRFFqV1FNSHJMdmVCWXhJYlNMZjVJZ2Rsclc4NlZFSmc2?= =?utf-8?B?d0FtTW9zekx6M25vVDVmenpWQmJqbEk0RFk4YVFQVm1pampFLzhKblNNZko1?= =?utf-8?B?VnVNQnVsdUNSTmh3d3NlRUJDYUJSRlZ1cHljOFpmdDNIVWJ4bEVuNjFPY3Fk?= =?utf-8?B?eEFFNkRGTG5hTlNpcW5TYkVIVU5IbFE3KzBQQ1ZYaWZDQTVyQmthS3NzOHVn?= =?utf-8?B?L252V0U5aFk2RmhFdkQ5QkdYWWRCSDJrSkJ4YTUvaWQ2UW1wK0duNmlEYjAv?= =?utf-8?B?L3VNYm5qcFlreWdhOTRKcFZDTGRpSFAyb01DemJwS3NMQVNJTjRRUmxZQlUr?= =?utf-8?B?aGREUlVUVnIvcXpkUFB2Y3FIYzZyLzZvMnNzRWM1RDdud3Bzb0hteWpZdEJR?= =?utf-8?B?RGtCNFdTUTRFUm5ObnAwRHgrNUpyV0RBNXBWOTN6OVJrbVNZYllPMTg2RnhQ?= =?utf-8?B?TkhYVlRKbU1YaFFSZ1RqQ29aMTF6YzRxeGpzVzVJQWNhTmhCNGlOZlk4bnJh?= =?utf-8?B?ZmxDbG5RQ2NBR2YyTTU2bjJyTmZOVmlMbjB1L0VuS3cvcC9rcmdvNWhXcmFj?= =?utf-8?B?VTdkaHhvY2dDT3NKRCtaQWVLekJnQXQwS1NoSWRVTjZjOWUwaWhUc2lRQWFr?= =?utf-8?B?RkUyS3FtTjdmSFhyb1UvQ21xM0Z3YTRLanhhYVJFNGhqTnJrQWFiU2srY1c5?= =?utf-8?B?MlYrLzluQWJvTEhudU9sU29ZMCs3WGhXOG0rMVBCTEF3WlZWalN6ZlpsanVG?= =?utf-8?B?aFhabzRPTlZuaVpKb1UyMm5rU1BzbnhsQW9hSk1wRlRsK0E2dXVkRFVUb2FZ?= =?utf-8?B?S2tSRWMzRnNMVXNnM1dwV09qK1EwU0RSME1GRUM3NmREcjF1eHBaTGY3UFJx?= =?utf-8?B?SENLTGVESzg2akxaTU9GT0JycHVnLzdaWjdjQmtnd1FoNno3NzFhTVUxR2ti?= =?utf-8?B?OXIyMHZmTjVtNDByWTJmNStiU1RsWWRJUmRaMnZPemtyV0hUMlRtVExSWnpT?= =?utf-8?B?WUFFNzlQeXRLTHE5cGVuWkw0TWxhdExUOGdqdWlEN0xLMzY4MC9LWlk4eFgx?= =?utf-8?B?YmxKckVOVDJiQTIrYkFGSU45MXYzU2w4enNaVnBTaU9Sbi9wUXhPVlFnTXJF?= =?utf-8?Q?AkW+uMPZRaYXotwFtmvy+nWL1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 850d6498-e239-45eb-d31d-08db1afce873 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 09:02:53.9698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NuzKaEf5/pecTU1FDVRsc3jY5BbeVZNYU04SOeIDeOXyqzjEbz4dMSaP3egcMrzPDBCseG9JciicOtSaifVQKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9875 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.03.2023 09:58, Jan Beulich via Binutils wrote: > On 02.03.2023 09:14, WANG Xuerui wrote: >> + tmp = strtoul (optarg, &end, 0); >> + if (*end != '\0' || tmp > 0xffffffff) > > I'm afraid this may trigger compiler warnings: For one because the constant > isn't flagged as unsigned. And then (for 32-bit targets) for being an > always-true comparison. Argh, always-false (but you get the point). Jan