From: Simon Marchi <simon.marchi@efficios.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] bfd/elf64-ppc.c: fix clang -Wbitwise-instead-of-logical warning in ppc64_elf_check_init_fini
Date: Mon, 17 Jan 2022 05:50:46 -0500 [thread overview]
Message-ID: <6416247f-d88f-48db-4352-e04988ecfe94@efficios.com> (raw)
In-Reply-To: <YeSmAF7x6TrESmEu@squeak.grove.modra.org>
On 2022-01-16 18:10, Alan Modra wrote:
> On Sat, Jan 15, 2022 at 10:13:07PM -0500, Simon Marchi via Binutils wrote:
>> --- a/bfd/elf64-ppc.c
>> +++ b/bfd/elf64-ppc.c
>> @@ -13129,7 +13129,7 @@ bool
>> ppc64_elf_check_init_fini (struct bfd_link_info *info)
>> {
>> return (check_pasted_section (info, ".init")
>> - & check_pasted_section (info, ".fini"));
>> + && check_pasted_section (info, ".fini"));
>> }
>>
>> /* See whether we can group stub sections together. Grouping stub
>
> I think I'd rather see this fixed by
>
> bool ret1 = check_pasted_section (info, ".init");
> bool ret2 = check_pasted_section (info, ".fini");
> return ret1 && ret1;
>
> check_pasted_section has a side effect, and failure normally only
> produces a warning.
>
No problem, here's the updated patch.
From bb27b41b2cd0dc4ebbbc8de6cfc5b691281695f1 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Sat, 15 Jan 2022 22:13:07 -0500
Subject: [PATCH] bfd/elf64-ppc.c: fix clang -Wbitwise-instead-of-logical
warning in ppc64_elf_check_init_fini
I see this error with clang-14:
CC elf64-ppc.lo
/home/smarchi/src/binutils-gdb/bfd/elf64-ppc.c:13131:11: error: use of bitwise '&' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
return (check_pasted_section (info, ".init")
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix by replacing & with &&. But given that the check_pasted_section
function has side-effects and we want to make sure both calls are made,
assign to temporary variables before evaluating the `&&`.
Change-Id: I849e1b2401bea5f4d8ef3ab9af99ba9e3ef42490
---
bfd/elf64-ppc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index ea9e60217bc3..206d85b319da 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13128,8 +13128,10 @@ check_pasted_section (struct bfd_link_info *info, const char *name)
bool
ppc64_elf_check_init_fini (struct bfd_link_info *info)
{
- return (check_pasted_section (info, ".init")
- & check_pasted_section (info, ".fini"));
+ bool ret1 = check_pasted_section (info, ".init");
+ bool ret2 = check_pasted_section (info, ".fini");
+
+ return ret1 && ret2;
}
/* See whether we can group stub sections together. Grouping stub
base-commit: ab31da6aff52fe3206cba98c03d7f74159da8677
--
2.34.1
next prev parent reply other threads:[~2022-01-17 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 3:13 Simon Marchi
2022-01-16 23:10 ` Alan Modra
2022-01-17 10:50 ` Simon Marchi [this message]
2022-01-17 11:14 ` Alan Modra
2022-01-18 4:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6416247f-d88f-48db-4352-e04988ecfe94@efficios.com \
--to=simon.marchi@efficios.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).