From: Jan Beulich <jbeulich@suse.com>
To: "Jiang, Haochen" <haochen.jiang@intel.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] x86: Remove the restriction for size of the mask register in AVX10
Date: Fri, 15 Dec 2023 09:15:30 +0100 [thread overview]
Message-ID: <644f539c-9c1b-4a86-b59e-431ee313c6c1@suse.com> (raw)
In-Reply-To: <SA1PR11MB5946A2466BEFCE10335646DEEC93A@SA1PR11MB5946.namprd11.prod.outlook.com>
On 15.12.2023 09:06, Jiang, Haochen wrote:
>>> --- a/opcodes/i386-opc.tbl
>>> +++ b/opcodes/i386-opc.tbl
>>> @@ -135,9 +135,6 @@
>>>
>>> #define Disp8ShiftVL Disp8MemShift=DISP8_SHIFT_VL
>>>
>>> -#define Vsz256 Vsz=VSZ256
>>> -#define Vsz512 Vsz=VSZ512
>>
>> Isn't it that with this and ...
>>
>>> @@ -996,9 +993,9 @@ pause, 0xf390, i186, NoSuf, {}
>>> b:0:VexW0:Byte:AVX512DQ:66:AVX512VBMI, +
>>> w:1:VexW1:Word:AVX512F::AVX512BW>
>>>
>>> -<dq:opc:vexw:vexw64:elem:cpu64:gpr:kpfx:kvsz, +
>>> - d:0:VexW0::Dword::Reg32:66:Vsz256, +
>>> - q:1:VexW1:VexW1:Qword:x64:Reg64::Vsz512>
>>> +<dq:opc:vexw:vexw64:elem:cpu64:gpr:kpfx, +
>>> + d:0:VexW0::Dword::Reg32:66, +
>>> + q:1:VexW1:VexW1:Qword:x64:Reg64:>
>>
>> ... this, the Vsz attribute is no longer used? If so, it wants removing altogether
>> at the same time.
>
> If I understand correctly, the attribute still need to be there for xmm/ymm/zmm
> restriction right?
Well, if no template uses it anymore, then the attribute can hardly still
be needed for anything. From my checking, all other affected templates
are restricted based on their EVex<N> attributes instead. And my
recollection also is that I introduced the attribute solely for the
purpose of the opmask insns.
Yet of course if internally you have indications that the attribute is
going to be needed for something again (within foreseeable future), then
we might better keep it.
Jan
next prev parent reply other threads:[~2023-12-15 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 2:23 Haochen Jiang
2023-12-15 7:51 ` Jan Beulich
2023-12-15 8:06 ` Jiang, Haochen
2023-12-15 8:15 ` Jan Beulich [this message]
2023-12-18 2:58 ` Jiang, Haochen
2023-12-18 3:18 ` Jiang, Haochen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644f539c-9c1b-4a86-b59e-431ee313c6c1@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).