public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: your change "x86: Also pass -P to $(CPP) when processing i386-opc.tbl"
Date: Thu, 28 Jul 2022 14:32:54 +0200	[thread overview]
Message-ID: <649aee92-1caa-f420-2806-7d8ff74854ed@suse.com> (raw)

H.J.,

the description there talks about dealing with \ uses for line
continuation. -P, however, is about the suppression of line markers.
In recent work I've been wondering why i386-gen gives far off line
numbers in error diagnostics, making it sometimes quite difficult to
spot what is actually wrong. Furthermore i386-gen.c specifically has
code to consume the line markers.

Can you please explain to me what your change really was about? And
can you please propose an alternative way of having i386-gen give
useful diagnostics (unless you agree with reverting that change of
yours)?

Thanks, Jan

             reply	other threads:[~2022-07-28 12:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 12:32 Jan Beulich [this message]
2022-07-28 15:16 ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=649aee92-1caa-f420-2806-7d8ff74854ed@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).