public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PING^1][PATCH] RISC-V: Prohibit combination of 'E' and 'H'
Date: Tue, 5 Sep 2023 10:43:48 +0900	[thread overview]
Message-ID: <64ebeb83-8fe2-4845-98ba-0ffec186e327@irq.a4lg.com> (raw)
In-Reply-To: <CAPpQWtBL=mn0hpE+HJ_12nMrcWn=ZP+jHX_JrhH+pPdac6cTKw@mail.gmail.com>

On 2023/09/05 10:14, Nelson Chu wrote:
> OKay, LGTM, thanks.  Does gcc also need the same check?
> 
> Nelson

I think so (although not important as Binutils).  I'll take care the
synchronization between Binutils and GCC.

Tsukasa

> 
> On Wed, Aug 30, 2023 at 12:12 PM Tsukasa OI
> <research_trasio@irq.a4lg.com <mailto:research_trasio@irq.a4lg.com>> wrote:
> 
>     Ping.
> 
>     On 2023/08/08 13:16, Tsukasa OI wrote:
>     > From: Tsukasa OI <research_trasio@irq.a4lg.com
>     <mailto:research_trasio@irq.a4lg.com>>
>     >
>     > According to the ratified privileged specification (version 20211203),
>     > it says:
>     >
>     >> The hypervisor extension depends on an "I" base integer ISA with 32 x
>     >> registers (RV32I or RV64I), not RV32E, which has only 16 x registers.
>     >
>     > Also in the latest draft, it also prohibits RV64E with the 'H'
>     extension.
>     > This commit prohibits the combination of 'E' and 'H' extensions.
>     >
>     > bfd/ChangeLog:
>     >
>     >       * elfxx-riscv.c (riscv_parse_check_conflicts): Prohibit 'E' and
>     >       'H' combinations.
>     >
>     > gas/ChangeLog:
>     >
>     >       * testsuite/gas/riscv/march-fail-rv32eh.d: New failure test to
>     >       make sure that RV32E + 'H' is prohibited.
>     >       * testsuite/gas/riscv/march-fail-rv32eh.l: Likewise.
>     > ---
>     >  bfd/elfxx-riscv.c                           | 7 +++++++
>     >  gas/testsuite/gas/riscv/march-fail-rv32eh.d | 3 +++
>     >  gas/testsuite/gas/riscv/march-fail-rv32eh.l | 2 ++
>     >  3 files changed, 12 insertions(+)
>     >  create mode 100644 gas/testsuite/gas/riscv/march-fail-rv32eh.d
>     >  create mode 100644 gas/testsuite/gas/riscv/march-fail-rv32eh.l
>     >
>     > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
>     > index ee4598729480..1655bb2df364 100644
>     > --- a/bfd/elfxx-riscv.c
>     > +++ b/bfd/elfxx-riscv.c
>     > @@ -1949,6 +1949,13 @@ riscv_parse_check_conflicts
>     (riscv_parse_subset_t *rps)
>     >       (_("rv%d does not support the `e' extension"), xlen);
>     >        no_conflict = false;
>     >      }
>     > +  if (riscv_subset_supports (rps, "e")
>     > +      && riscv_subset_supports (rps, "h"))
>     > +    {
>     > +      rps->error_handler
>     > +     (_("rv%de does not support the `h' extension"), xlen);
>     > +      no_conflict = false;
>     > +    }
>     >    if (riscv_lookup_subset (rps->subset_list, "q", &subset)
>     >        && (subset->major_version < 2 || (subset->major_version == 2
>     >                                       && subset->minor_version < 2))
>     > diff --git a/gas/testsuite/gas/riscv/march-fail-rv32eh.d
>     b/gas/testsuite/gas/riscv/march-fail-rv32eh.d
>     > new file mode 100644
>     > index 000000000000..b57199efa0f6
>     > --- /dev/null
>     > +++ b/gas/testsuite/gas/riscv/march-fail-rv32eh.d
>     > @@ -0,0 +1,3 @@
>     > +#as: -march=rv32eh
>     > +#source: empty.s
>     > +#error_output: march-fail-rv32eh.l
>     > diff --git a/gas/testsuite/gas/riscv/march-fail-rv32eh.l
>     b/gas/testsuite/gas/riscv/march-fail-rv32eh.l
>     > new file mode 100644
>     > index 000000000000..c7cd1ccc2a89
>     > --- /dev/null
>     > +++ b/gas/testsuite/gas/riscv/march-fail-rv32eh.l
>     > @@ -0,0 +1,2 @@
>     > +.*Assembler messages:
>     > +.*Error: .*rv32e does not support the `h' extension
>     >
>     > base-commit: d734d43a048b33ee12df2c06c2e782887e9715f6
> 

      reply	other threads:[~2023-09-05  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  4:16 [PATCH] " Tsukasa OI
2023-08-30  4:12 ` [PING^1][PATCH] " Tsukasa OI
2023-09-05  1:14   ` Nelson Chu
2023-09-05  1:43     ` Tsukasa OI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64ebeb83-8fe2-4845-98ba-0ffec186e327@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=nelson@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).