From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BAA363865493 for ; Thu, 28 Sep 2023 14:04:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAA363865493 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695909890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzavlHSXXfOlmait6ClpebgwBQu6LDOjkbhxVuL+oj8=; b=Jte1Qkc0x3OO3dRexcmksftgL08+YorQpEx34gVUG29qwQDYyErsC1hZ8DsCzFDw6oHR9L DcVX5JnWONOF4dizRu+pi8GjuIPYvhKAUR/KtzkfLYa5gUMJyuUwhJhLPVdulL/AVRBCTD TOpUxk8IgZRTJ2Ji3IFD+fqGQWDWUKc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-Zol4bEyeMRueHnqwPMOiLw-1; Thu, 28 Sep 2023 10:04:48 -0400 X-MC-Unique: Zol4bEyeMRueHnqwPMOiLw-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7742eeceeacso1922741285a.3 for ; Thu, 28 Sep 2023 07:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695909887; x=1696514687; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qzavlHSXXfOlmait6ClpebgwBQu6LDOjkbhxVuL+oj8=; b=fTXo7ACX3jqzJCLwZ/pZvR5724buTl6ncc+6GP8+HAqIVq7Y0UT4l/x4JqywoJy0Vs YegbjnAP4Iwy37ngVz5QHcMg8Tl42sBB0/uwQIwki0xYkLZhxt3hnoxaqbdCooEA4ON2 yR2tJvVwkrznSXfvzyEj4/F1i7L1eW2xYvTeLCBZNfwQ/N5DeItR9YT6KCyQcuQo+7vp OJz2I2dol4y/yVv82wgJSU0bma1FFCeFX0xolSbpbXdNNFH04xDWthTXz+/IhPH/wx7+ MoDWrmvIB17FfBkxLYleKwOVy/vg3ezqwqzAxOFO5c9aTx7vr1n3zH9fsEGX21sahhCB 68Mg== X-Gm-Message-State: AOJu0Yz0OSu/8CpbiTg28hZeWuCizOrGBaQ/WtCbdg6BrCIyLcZtNYR4 0p1wUOF0WbCISzxtuIXtB9kNKv9zcOhl7F8PaDkh4Mn5vqNbmFCEgbMheLth25iuAov5roea8vN 9pKnJqgatbaEC+voK7YewqNhJBA== X-Received: by 2002:a05:620a:31a5:b0:775:8040:ede6 with SMTP id bi37-20020a05620a31a500b007758040ede6mr1446440qkb.21.1695909887652; Thu, 28 Sep 2023 07:04:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkcD/Jx4Ww0BWPV+Gk71lpC07QnJr/+IucDMH+lmdqazwp2z/HlyGNL+Jr7Az87y2ZERHJTQ== X-Received: by 2002:a05:620a:31a5:b0:775:8040:ede6 with SMTP id bi37-20020a05620a31a500b007758040ede6mr1446416qkb.21.1695909887394; Thu, 28 Sep 2023 07:04:47 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id t12-20020a05620a004c00b00767dcf6f4adsm4077340qkt.51.2023.09.28.07.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 07:04:46 -0700 (PDT) Message-ID: <6582d489-7ac5-6c4d-cfc2-8e5ca7e399e4@redhat.com> Date: Thu, 28 Sep 2023 15:04:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Indu Bhagat , binutils@sourceware.org References: <20230920230401.1739139-1-indu.bhagat@oracle.com> <20230920230401.1739139-6-indu.bhagat@oracle.com> From: Nick Clifton Subject: Re: [PATCH,RFC 5/9] gas: add new command line option --scfi[=all,none] In-Reply-To: <20230920230401.1739139-6-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Indu, > When the command line option --scfi (default is --scfi=all) is passed to > the GNU assembler, it will synthesize DWARF call frame information (CFI) > for the assembly. > Also document the option. Please could you also add an entry in the gas/NEWS file about this new feature. > +# ifdef TARGET_USE_SCFI > + fprintf (stream, _("\ > + --scfi=[all,none] synthesize DWARF CFI for hand-written asm (not inline)\n\ > + (default --scfi=all)\n")); > +# endif I was wondering how the code would detect inline assembler. Presumably it looks for the #NOAPP preprocessor directive ? Or is the point of the comment in the above delta that the user should not use this new option in conjunction with actual compiled code ? Either way I think that you need to extend the documentation to include describing what happens when compiled code and this option are used together. Also - I have not checked this yet - if this option is enabled and no CFI statements are generated (or maybe if an incomplete sequence is generated) - presumably because of badly written code - will there be an error message generated ? Cheers Nick