From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2079.outbound.protection.outlook.com [40.107.15.79]) by sourceware.org (Postfix) with ESMTPS id 012B13852C5A for ; Mon, 28 Nov 2022 14:24:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 012B13852C5A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eIkBqV1XNiy70bYbEfwIY3fDp0YMV5bP6A2mJ00DpWp6XsqBcnpjy51j+0m5CE2pdi5upD8GuZKoHLiyE5j/IN8Pd3e2PayJ8MSMyBLy0c5C426+2Bb0Gzlpr9MulLiFbNZh1rMVp8t1EDKZuW2Tss26tZoFNQQ4fRG8QehXk5vqxz4kMIET4FMGyUzHwwnxGg18zIZ5xoLok1nQNNIZkOo7MhRfrPvBjPGraltfn2uTB5Mn3Wdz5cz1s/EpCjKy0yCQs2XgqvVp0RJfGXWuGPPNY00PNNtZR0faNiLRbja6X8WdgDBpCUAqYyBVOsgtVvlmzV1dkbCzifi/BbwlSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HpyoQbT5KXkx6WiRE3Ws9AJN1W2uXktAgXJxsqtoU6o=; b=gYKmp0DcKLDEY/7xzopQhOQaB8BSmaLDrHpG6SHd4mv+0Hks6kN83FsZLVbY8F1YOpTkVgUfRezpQ1vl4uNWGeacG+f/bdsAQNsEcR38/Kf8UUf5XtzyZ/Wgsdv6zRAsv+rf80Jssc3AIQ6+khwTHgTkD0z/tgA781Mp0i8C+R6jYsoxBl0co+grg39uSBYmrOBGb+vM/DLP4EkV/0r466exFTTuXYcR582G2nsWplrqdz/WrqdlsmjQQ3p7f74ZuTkAs1Wo12f9zybHQ1l6vePJjZz54zI2PA69srGW6f7FIvUL8uTj36eFN5kl1YkwIulh9Xmw/6pd6EL3mI2XaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpyoQbT5KXkx6WiRE3Ws9AJN1W2uXktAgXJxsqtoU6o=; b=LeZL6s0e2eG2IaM3VmXS6pxL+Qj7Fw8MCUTObE1ptCBLTnfSyTRZL2TbhVS1ueyZRa1mQbQuf6buNunXkD6lYeR7J15YyeDYZ43TFTF0t8FFwHTmitxaWTS2Oxf1ZaLQ61b3maIzvMWyGkmA9GAfcQ5TqnZ2HAu4WnGNrDdnetb7AaCJM6wL1bNKoVBF+qhT63FNK7Zsg6t+N5duKRyBXHhdlAFa9DYJV57aAY+dU+FNHB9uR5Kpt8dt1jvIB2u0sGFslpNQLeMjxz8rY6mP3JPiJ7EJ1cHJk//Njwlev0875K+U/3gy4DoxTLkJir+WU6gU2pgrGkjjKoCAikNZjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8120.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Mon, 28 Nov 2022 14:24:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 14:24:33 +0000 Message-ID: <661d0e07-cc75-0fba-941b-88160dbcbb13@suse.com> Date: Mon, 28 Nov 2022 15:24:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] x86/Intel: adjustment to restricted suffix derivation Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8120:EE_ X-MS-Office365-Filtering-Correlation-Id: 467e6a40-12f1-462f-b9f3-08dad14c44f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fCiQeheja2/piEakAlCTBEBJ5mVe3aZBFZuoLyPBgGIytVYEncMqQ+PFpez2GtRRmY04qz1/KbwQDpaTLUJqpJeJBEOcWxlp/zFKrRZ60q+P7P4ehLLKxQRbyZjsdnbjJDVCzU+sN7nEiMir7a3YE63mLtJhGs6T72UuaipUpeHPhWLpsiAs6pvss/hMMsenkFWABpX/Tr+oH2T1TFzQbp+gKS1+kl8XYE26Kvq+1QoLAb7y42vkbSHLf4it09irQ/7rQKY5s/zgcMK8f4aNbp4lVZxlKbvzB/yFgoFNYKy5eKXCI46dInfPjIjoDuS0F3KxFgz3uSOpNs+AQPk3+uJXi1JhtArdzKAbLxdns+t5BChgs91ehHewTFOrpGFOa0PLVg7S1ULNDoN1/QM6oqFV/GFEVGGod1VnsrEF/DJEmrHUA2yu4P3nTQUlG1O/3tFKvgfVL0pg9593gCT815eX5sbdRfPzglP9GgocdIqQFovJ80AO4JI87Yxhm2R6yOeTfv/FtTPvXHY3fhDvAv9Bs6QmyVzBfO8whKQp7fx5zNtUo9ou7C+STngrcgf0sWsn+fHlDRDPTnD8O2Jiu3Uz7mCug1MF8NVfTmchQrqZUeZTe8EXkDshPlZpyxVO+bFkia/VlC4+3UhgROeZCoFG76WOqb1CgpnZyHuqJjfkBIMEU70AEmczgqQ3A6vw8em8q1sglGs2MOZ0BTME3TvvjGjZV9dIX8h35snylFs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(316002)(2906002)(478600001)(36756003)(66946007)(6486002)(6916009)(38100700002)(26005)(6506007)(6512007)(86362001)(31696002)(186003)(2616005)(5660300002)(41300700001)(8676002)(8936002)(66476007)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDRidTRlRTFseXVQSFc1SEplckpZYzh0KzRULzBoMzN1VEx2MGdBL2p6RGF6?= =?utf-8?B?VDZ5RzRwWDJPbWdZS2YzY1p3MkdQcFpJMXIvdzZaZzBBLzg5Nm1iQXdnSk0y?= =?utf-8?B?Y2RXOTBIc0RUdXNGUUl2RzJvOVN6YWdFdmpiUFgwVkdtTFRCeWVkNXRxQkdJ?= =?utf-8?B?UWVBdWlyUlpnN0sybDNSL3V3bXFyTklJcTFvWnJRZkNNZ3dIdzlVSXhWN1ZC?= =?utf-8?B?UFZNM1psQ1ZRdVM5dmFNT1l0eUwyV2RKTkN2MlhFNmt2eHNBNkZFeGNsK2Y4?= =?utf-8?B?RVova0JjTnYzb2Fvbm4vZ0FZUVlGTTExY0htWHBGQktqdlREZEhZd01EYmlG?= =?utf-8?B?TUw4SDIzUnhVVG04ZHVxTnlPUFlicFRNT0l2aXAybkZJR3pyb1dzdkZrcTNo?= =?utf-8?B?N0J3bEg1ZzhJWXV6SHRtaTdZUFBUL21DQm9NME5VWlZRQU1ISTFObUQwUzVC?= =?utf-8?B?a3c5NDNyckErRjZ5d2JIRW5iSVpldEoyNTJnTlFEcTBGRFA0akpObFlnZTEr?= =?utf-8?B?NGRlQ3lwYktXVTRBOHNOTXF1aXVEYUdYeEtUeDdrcGM1djRBR29XM2QzWTNB?= =?utf-8?B?RElMVlpyVEw4aEMrQlFVc1VScWlQaXpadENDTnlSRHA4U1pZVU0rYjJEWXVS?= =?utf-8?B?NndDVnJSbGFXRGREZWtpZDd3SWJVN2xUM2tTYjdob2ZzWmFGU0QvRDlHS25G?= =?utf-8?B?SU0yK2s1MnFYeGVpVnFmMW9EbEtkUUxuRDIvRjhuMStuSjNBVGd0ajJpZUU5?= =?utf-8?B?a3hRNmtMcENmNWZkODl4ODRsMjRXbnJheU9MeVd5R1B3cGRUNFp6MWVmdjFi?= =?utf-8?B?K21nSHdWUld5dmQrTTlmaGFsZTVSWXBmMDFTTjZmWEFCaHFpcG43Z3doZ1dl?= =?utf-8?B?MUhZZjJzbytzNlNKcGhObFp0T09BdncwejM1MzVCaDZ2ems3alZ2MHN3cU9U?= =?utf-8?B?OURWeDZMWUYwZVJIUEFHRmxtL3R1YTAvdkpXS0NxWW9mRWd4Vk1JT1l4N3pu?= =?utf-8?B?TzhoRVRieTdHWVJPdG8veTNqV2hYN1JaamlGUDl1RkVSa3Vhcm9aa2xJSkMw?= =?utf-8?B?UEw4eFBNeHhRNjdsYkYrdkNrcTd3WitTY1lTRkNRQTF4QTFoLzROQ2ltSXNs?= =?utf-8?B?c3BrOGYvalA3MzI3SGtVSDIwSFRQV01VdnpSSUdlME5wSVJ6NkRNaHEyTit1?= =?utf-8?B?WG1LN2FEa2k1RFNTQ2pQUnl2Zkg2S3hXRHl4OUEyOUR6dGVXUzMxR1NNeDZs?= =?utf-8?B?WmZKaFZ3N3d3YjhteGIxeWplS3ZnOUp1WGJjSnB2QmZQb3NLZ0laUURaamhB?= =?utf-8?B?VzA2aGNSVlZPcjh3bysrcEJORlplTXhKbjhyUkVMRGxqNkFMd2pseWRxaVYy?= =?utf-8?B?Vy9qa1VEZEN0blNpK2ZjTC83VlJGajlpWGE2VjBFYzFIS1dwbE5ERDhVeDI4?= =?utf-8?B?VXZ4V1JlZmFYdU12KzdkV1pKeC8rb3R0OWN2Sk1qcCtiK2grZTZGM3ovSjJC?= =?utf-8?B?R2dTYUQ4WjQzT3N3bDE5V1gyUzFYYkhjNXQ5UHZJc1hEOWRvLzVmMmIvYzVI?= =?utf-8?B?U2xLYVRmS0ZtdWpGQ3h4c0dXN1YzL0xGSHA1eUpYNkN1N24vTG1yaXJ3TVp3?= =?utf-8?B?bzFzK3hGdkUzQU05VDNBMm9tWGpjT1dvNFk5cDJkWm1Tayt6L3BlRmZiMDI3?= =?utf-8?B?TmRRdmN1SkJJQW1NWFVCTWs3NmVJenV1TnVFdFhqSklxT2ovN08rOWF5U01p?= =?utf-8?B?OENpbTRrMW5uSnpVQU1jWmN0SDRjQWsvZXNMNXdDQ1ozR254ZUNJRW9HWFV0?= =?utf-8?B?OXBScytqaGE0OGxKN3pjWmxndjZTT1NDM0lFRkpGTTg2NzBpWktXRGpVRHAz?= =?utf-8?B?dWd2dENEUkxPMk1IbVdSSUhEdHBac01aeXJoQW5qZDZGVWNWSU9VZklFOHgw?= =?utf-8?B?c28xMHVYSkZDK21aZ09wVXR5eE1uRTd2cU1SODdSY3A2eWhHT05ZVjNvcjdU?= =?utf-8?B?RG1JcmFCS21kRHpScjM1NTgwejl6eE5EL2JhMGYxTzFHNXNIVnpPZWdCS0Yv?= =?utf-8?B?d0Rrb2UzQnBIK3BzZUNRLzZpNTJubngwUGhHRUtMVXhYcER4L29DOWdSMmJh?= =?utf-8?Q?QrRGJW14SyPhjXgSWJi+eeJA4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 467e6a40-12f1-462f-b9f3-08dad14c44f7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 14:24:33.2089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CZkKrI1UMAxFoskpw+IiNcAsSns3ZFeJrhv0UDM7+TEHl60LUwSiGAOUQLsXCzczJ0/w2s+eo9s+ilwwme44PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8120 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In "x86/Intel: restrict suffix derivation" I think I screwed up slightly, bringing a piece of code out of sync with its comment, and resulting in a suffix potentially being derived when one isn't needed. --- Really we could go further and check whether _any_ register-only operand in a template permits for multiple sizes, thus implying that operand size can be derived from it. But that would involve looping over all operands, when we'd like to keep the checking here quick. --- a/gas/config/tc-i386-intel.c +++ b/gas/config/tc-i386-intel.c @@ -841,11 +841,16 @@ i386_intel_operand (char *operand_string abort (); } + /* We can skip templates with swappable operands here, as one + operand will be a register, which operand size can be + determined from. */ + if (t->opcode_modifier.d) + continue; + /* In a few cases suffixes are permitted, but we can nevertheless derive that these aren't going to be needed. This is only of - interest for insns using ModR/M, plus we can skip templates with - swappable operands here (simplifying subsequent logic). */ - if (!t->opcode_modifier.modrm || t->opcode_modifier.d) + interest for insns using ModR/M. */ + if (!t->opcode_modifier.modrm) break; if (!t->operand_types[op].bitfield.baseindex)