Re: [RFC PATCH 0/9] s390: Initial support to generate SFrame info from CFI directives in assembler

[Jens Remus <jremus@linux.ibm.com>]

Am 05.04.2024 um 20:26 schrieb Indu Bhagat:
> On 2/23/24 13:16, Indu Bhagat wrote:
>> On 2/23/24 09:07, Jens Remus wrote:
>>> This patch series adds initial support to the assembler on s390x to
>>> generate SFrame stack trace information from CFI directives. It is
>>> largely based on the respective AArch64 support.
>>>
>>> Please be aware that the SFrame support for s390x provided by patch 9
>>> of this series still has some open issues, which need to be addressed.
>>> Any ideas or assistance to overcome the current SFrame limitations
>>> listed below and in the patch description are very welcome.
>>>
>>> Patches 1-8 are generic cleanups and enhancements to the generation
>>> of SFrame information in the assembler. Patch 9 adds the initial s390x
>>> support and is purely RFC.
>>>
>>>
>>> Patches 1-3 are minor cleanups/enhancements to the existing SFrame
>>> support on AArch64 and x86 AMD64.
>>>
>>> Patch 4 enables readelf/objdump to dump the SFrame fixed offsets from
>>> CFA to the frame pointer (FP) and return address (RA).
>>>
>>> Patch 5 enhances an SFrame warning message to print the human readable
>>> DWARF call frame instruction name.
>>>
>>> Patch 6 and 7 resolve issues that cause the assembler to either generate
>>> bad SFrame FDE or to silently skip it. Both issues would be triggered by
>>> s390-specific SFrame error test cases introduced by patch 9.
>>>
>>> Patch 8 adds verbose assembler warning messages when generation of
>>> SFrame FDE is skipped.
>>>
>>
>> Thanks for fixing issues and enhancing SFrame handling in Binutils.
>>
> 
> Hi Jens,
> 
> I think it will be great to split this series and send a V2 for the 
> Patches 1-8 from your series. What do you think ?

Hi Indu,

thank you for your valuable feedback to my patch series! Sorry for the 
long delay in getting back to you.

That is an excellent suggestion to separate the non-s390 specific 
patches from the experimental s390 ones. I will do so shortly for both. 
Patches 1-8 have meanwhile grown to 1-15.

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des 
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der 
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/