From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 5FE9E3858416 for ; Fri, 30 Jun 2023 17:51:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FE9E3858416 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1b801e6ce85so13944545ad.1 for ; Fri, 30 Jun 2023 10:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688147516; x=1690739516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V64gNAH+MaCdZK8As2CZSHNgDx9rRhvgkzjLUkmg+Uk=; b=rShLP8hdW+xLxMeeYnWtSDapA1w21L2hjirR5bcDsHCl4TUdecraQCPbRmZgmOZLp2 /cfjsF8OvI5mvNuxo94BIbFa5eSonZT37SIEcUib7JezQixYd+x+aYOwCv+Kwn49uIuP 85FuzqfdNYJcV/UJcN0DbwGgcSBcagCCh31hpB6XVcABjgx6qZvgIP/2aZToUwM0U2sY 8cgWJLMe1a9IrZorq/v53UGqc9wxrhlBxELmr91ktTrxqizgxtRz216FLm3/+Ah+vNIg S+xZJSQivmQ7bJtr6J07fz+P44NUDI0Ma05TiUzxYNzYvTgmxIzoHBqF+fld76XKh5pV nvSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688147516; x=1690739516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V64gNAH+MaCdZK8As2CZSHNgDx9rRhvgkzjLUkmg+Uk=; b=NLxquTK25aMx5GLK4x8L9JcFEF/RcZkhml8C5K1gGxL2KC4ZgMgRchEOraMPPpf5/X 7M/F3cP4Cymi438/P77QbHySZOZIqgxOBeEQTg3zJFE4Vo4xMiHkN2AsCUW2xJKixvIR jKZvcYkUW8JN39a48XZA/FZOn8n/nec0lgor7nn5SL/OJSFM1ii0fhLZSLk/U+bhrz6F e1aBVwpa2vG8lwQmysljK36wkoyngj3v+JD/A9swzhHQ6RfmUrEPVeEr0cYONsOKSOfP YBtUASx1VGSoLU0yq/KQwAdJkkzUEV3UIRvAdQojAGWaXOdRyLtwIR8XTpK+qDqb83Uh CqqA== X-Gm-Message-State: ABy/qLYYRUxwcRhDBJXj02y/c6N/z8h36cjtrBPO+KnvDTXA3gUZkjgp 7UBpGMa5i1sqiKBA0UPuh/oFEikJ7V4= X-Google-Smtp-Source: APBJJlHfL7oOtq1U2k3qIRSMk55oa1uAwid7H1xUSu/BzC0elKJRfihTqYz76METqZzK9t89jpglIw== X-Received: by 2002:a17:902:c94e:b0:1b8:7613:594d with SMTP id i14-20020a170902c94e00b001b87613594dmr2598336pla.24.1688147516292; Fri, 30 Jun 2023 10:51:56 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id w1-20020a170902d70100b001b523714ed5sm11047396ply.252.2023.06.30.10.51.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 10:51:55 -0700 (PDT) Message-ID: <66c6fcc9-95f0-fce4-75c9-68d746aede50@gmail.com> Date: Fri, 30 Jun 2023 11:51:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/14] Add support for the Zvbb ISA extension. Content-Language: en-US To: Nathan Huckleberry , binutils@sourceware.org Cc: nhuck@pmull.org, =?UTF-8?Q?Christoph_M=c3=bcllner?= References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-2-nhuck@google.com> From: Jeff Law In-Reply-To: <20230629171839.573187-2-nhuck@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: > From: Christoph Müllner > > Zvbb is part of the vector crypto extensions. > > This extension adds the following instructions: > - vandn.[vv,vx] > - vbrev.v > - vbrev8.v > - vrev8.v > - vclz.v > - vctz.v > - vcpop.v > - vrol.[vv,vx] > - vror.[vv,vx,vi] > - vwsll.[vv,vx,vi] > > Signed-off-by: Christoph Müllner > [Updated to newest version of RISC-V spec] > Signed-off-by: Nathan Huckleberry > --- > bfd/elfxx-riscv.c | 5 ++++ > gas/config/tc-riscv.c | 13 +++++++++ > gas/testsuite/gas/riscv/zvbb.d | 43 +++++++++++++++++++++++++++++ > gas/testsuite/gas/riscv/zvbb.s | 34 +++++++++++++++++++++++ > include/opcode/riscv-opc.h | 50 ++++++++++++++++++++++++++++++++++ > include/opcode/riscv.h | 5 ++++ > opcodes/riscv-dis.c | 4 +++ > opcodes/riscv-opc.c | 18 ++++++++++++ > 8 files changed, 172 insertions(+) > create mode 100644 gas/testsuite/gas/riscv/zvbb.d > create mode 100644 gas/testsuite/gas/riscv/zvbb.s This needs appropriate ChangeLog entries as well as an update to the binutils/NEWS file. With those missing pieces this will be OK for the trunk. Sometimes I'm willing to cobble together ChangeLogs, but with 14 patches in the kit, I'm not going to have the time. If a suitable ChangeLog and NEWS file is provided today, I can go ahead and push it to the trunk. I might be able to do that Sat/Sun as well, but I can't commit to that. I don't offhand know Nick's policy WRT patches going into a release branch. So while I can ACK this for the trunk with a suitable ChangeLog/NEWS file entry, I don't know if that ACK will apply to the upcoming 2.41 branch if this doesn't get pushed to the trunk before Nick makes the branch (Sunday, July 2). Jeff