From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by sourceware.org (Postfix) with ESMTPS id 190843858D1E for ; Tue, 14 Feb 2023 07:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 190843858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jm7u1m1mjPHug+snSwXgRzxr55YCObcI/ibPVBHyzKle3SfYaZEF8dPHVoVlT8zaDm22OJe0PRwWc+c3xWt7XljmwBVZSpSVBixPzyjZwIv054i8BGN+OhX5zTzZiVtcdw6m7MP3i6CjFZoKpyZjXbQ2GTzaYcG3Rqp+I3C4dDaHh3Xs8ZmD46JXdo1udD8YS52NT0+ZKXHKMXTWCj2TEgdsd3v3R9DcuMu2kGzG37Bzu4GJ+aPYa+PPtgXm8jKRpCc2xlntVahkyMOTKrrRbmsaN13BixiOlxtqibhpwfSr9VbzwEmAeY5en8eGrNbz5RNK8drXkdeJ+BeRJ5NwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGtGnCYHJo9O7dpD6HeVsM0GKC+84zuiWV8733vA6aQ=; b=aWBvh1im8rSf1jDqXMioAvaReKa3LLVA1WBnA9cAfCOYTaDWAcPh5aCv60jmgf0Bcha8pYVatCjDvY7SImeFB1NfkSoAMz3pv8DF8odIpn4cCsN2ZiHfZSOZVLnFUzVdGXUzOkx9N9KWqqycyxZ5ZbYJ1UrLVczCBVne8YMrdvK4VUv5txyzzJO4QGbKY+BxEpw0jE7zkFFhY9Ma0m4duPZOlISNjYC4lChW1qh7/MByqenJaq1bzhPxT7LcWePiVi5AZi4snILyLHpnFl28n8808vWw73/YZTneEGn37YID0q5cpF8ylCuU9VltHBrMJR68VVmaMNBb9WaDulDAxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGtGnCYHJo9O7dpD6HeVsM0GKC+84zuiWV8733vA6aQ=; b=hcYbvhvQEzPx/hyZCtKLT+HlLV/D/lVtnodZhXLspdO2Vb2wYAHIAT49KoGMmKduJJhUhImJuiSm3gPVmNEKD0cWh3W3jJIZtksHBePIrfe7d1ScRAuBcGyhB2bZen6nY04RVb+t+LBb5r2+9HzzrqHBpOblI9ZCR7aEL83f5Nov46h6bPkSsiSbcYJjiS9xPUy7Upr97FMEMYGjhbnY9Xm0BXjV6qxD6cKe6C4tAAUIfFQ+nUI3zlKemSSCuvcCLsl8eLjZl43EU1s4hrdGCx5E5UAjHq416d2M4uES+nGxjdNj2I9OPPvtorwT4jfkmtqGYqVrLtXAIYULRO9VhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7466.eurprd04.prod.outlook.com (2603:10a6:102:87::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 07:26:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 07:26:34 +0000 Message-ID: <66ca084b-8e9e-ebd9-866c-58b9a1dc5724@suse.com> Date: Tue, 14 Feb 2023 08:26:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/3] RISC-V: move OR and XOR aliases down Content-Language: en-US To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu References: <678b275f-1930-4a59-dfba-fe21cd548fca@suse.com> <63fa0796-59e6-6429-6c86-b8707cc9f8d9@suse.com> From: Jan Beulich In-Reply-To: <63fa0796-59e6-6429-6c86-b8707cc9f8d9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7466:EE_ X-MS-Office365-Filtering-Correlation-Id: 5735dece-13c0-4344-a887-08db0e5ccc7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2OipbfzjIHtIzsZBCCyz8pcfbflCM0MMwu1gbIuOqQ1NHsQsMRsLmqxDVBR8Gm4vdADyyEUqHhh41HsXHxCpPIDUu5m22LK69WvuCpefBePROWXzUIMp3RPkNHM++xotaCOJrBxTO15Xa7CDb4Cob8ZtkG/yXpMHHhT691JtPXm6qUCUUyiR2VmIOo41F/lsE8bAOLFOm2gcxrWa7Lo3Q+ImsE1/RtPFVttBKe/bK6PkErAmhnT4sz996srzDzzi5uPnfgfZiLt/l41Rry1NbcEsy+dEWTeDJWHiUxWAW0McnZslxnbIoIBJLX0TaM62QVCeRt96AJ8Rq5HXfenZg4/AYybppF00crxvhDtFbAvhQpy14E+ZXyaDwO7JmGKOOvLxVMEbYg+xdeJlRPVw6DDGmlSjmvzAnJP+b3ZuLaFRtpLzBI4wDV6L/QG/YanQbkismc6qdcqSE471PCSfeZ5jAmlzx8hvD57mXnwTOnwBRqZsb8UGjt1O+2lTGLnSmSspq3ueWb2+WnuSR0H5MC6CGDlhu6HITaGk4CPRNF9xXnXYxY8/j6NYA8qe0ofJ9OLhhsj9rJjHvJfUL1/j7vANy4YQ4FAeBPfiGqb9A4YfRz3dYhD+n+XVJ4On7UKNoD6Nh2PHmVhsCeQ/BtEEWfpJ6Mx94O2B/0+f/EZf15sMlOdyYXFI7zMzTxuJQShGrcv7Zuxsq8RhwmYZhAijww== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(136003)(346002)(366004)(451199018)(186003)(53546011)(26005)(6506007)(6512007)(6666004)(36756003)(2616005)(41300700001)(8936002)(5660300002)(6916009)(66556008)(8676002)(4326008)(66476007)(66946007)(2906002)(478600001)(6486002)(54906003)(316002)(38100700002)(31696002)(966005)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDdaRHppMU1nQXZFc2hyRTFVaGd1Rm9yTlY0ZzJPMUpRTEVUbDA4U2JKdFdn?= =?utf-8?B?VzByRWhJNU1URkViZ3lNWk9kOEd6aVlKWWRKb1dzMDhNZE5VWmlRQ1MyS0Z4?= =?utf-8?B?ZXQwY2wzdzdlOU8zNUlzSjlsSGVsNU43bTBJT1VYVGZmMHZMU0ptekt6Sjd1?= =?utf-8?B?Q2w2a295V0RLanhOT3FlWVY5b1lSVDBuelpPeFlvbytrYkF2Um1vdkl3ZGZY?= =?utf-8?B?YktWZ01SSzFmajFlZmoyeXhNb1ZDZFhKOWUyL0R0UkhWT2hZTTJyMmhUK0J5?= =?utf-8?B?YUp0eTI2YkJVNkNwS2ZNRDhVWExaeGNDaFd1MHFNTmJkRDU2NlpXSkxBZ1JD?= =?utf-8?B?Sm5ta1k5V0xONW80Q3N4azhycjg4TSt6V1VCLzIrYmNuaXJJQW1IOExWNUxm?= =?utf-8?B?dWVYRGhVSFdaWm9ybEJ4NWZJNXJsVE9LM0ZFQS9YNkRueTN2c0Z3QVZEVnd3?= =?utf-8?B?NWRZeFdPRjkxYzN6dFNuTVY3RDVPMmtENmp1NW8wcDQzSVVqRzJEdDhzMmdC?= =?utf-8?B?VUJJaHFNcTZMMWlVOGNIMlkwaCtNWnN5WEoxMFVvM3BUbTdsSzU1bWZ4MTI0?= =?utf-8?B?bjNKMklTbkZQR3paUTRtOWxnWC9DendGclpFZHhFdkdnTXhGclZ4SVhoQkth?= =?utf-8?B?d1pWS1k5dXhZRWRLU3lhUGlyOUw3eUhZKzVsZC9JWnFvVVJSM0NZUG5uajBr?= =?utf-8?B?MUZzcU5xTkZRNWFxcVpDVitVR2I2dldRekxxaDVMTlcyUko2Q29GdWt1TXBq?= =?utf-8?B?S1ByUjF3d29uYU05eGxMQ01nQzNyUnpHMWZ6d3dHTytqekZrMUtyUHBlZDBC?= =?utf-8?B?VmFyZTVOUDZhcnIvbFJxczBYVFNyUnQ5czArVlBHN1dEZ2NqUWg1dEI4aVlH?= =?utf-8?B?RmU2Ty8ydU1jODRHOVBTb2ZuZ3M1R1VmUmNPeURKTWFVUTVCazZBTEYxWGND?= =?utf-8?B?YmY4K09pNzVQRHJhM3hpRmVRQzlpSUE2eWhLc0V2WmpuS3lWeVkrZThnOXZ6?= =?utf-8?B?dkMyeU1aSGJOMWFJQytaYVloTVhvN09xa1VrcEh1a25qNVFTTGlHSG5MbHNs?= =?utf-8?B?UnRKUGZhUFhibUlhb3NXc0JXYWVuMmFNaklaR0pKTUc4ZFN4aFRVTmJFc2Nv?= =?utf-8?B?bnZEMXNoUC9icmVPaGJ1TlEzbEh0MUQwZHpqQkJ3Um1WN0o1YVpQaFcvWFk1?= =?utf-8?B?VkZFd0RzZFk0REdCVHR3WGM1RkN1Y002L0FwZFoveXNNZTVHTTRzc0Y0YXNL?= =?utf-8?B?SjVIWnNRRThVU1ZBek9wR0tEcFFtRjgrRlZSMFA1QmwyU0tNV3dKT0w4ZzZt?= =?utf-8?B?VS93dUZUSVA1dXJkV3hrNFRudG94YzVpRFoycXlxa0NQZUplZVJaZHdVeXln?= =?utf-8?B?RTMxcS93VWRja1hhSXFhWjdybmhHbkZKWXFxMWRTemRGSzNUdWx2MDhuZ2VY?= =?utf-8?B?akRlZDg0UVlpd2QyYU9IbFFOYWJqL2xVQmtMRG5mMkhDdnU3cWZCbVJ4bmU0?= =?utf-8?B?K0Q5SEs3TVNXb045MmhKR1FlekgwNk5mUllxNCsvcDBwa3RsL0JvMnYxYjRI?= =?utf-8?B?dzFYbnY3c2Ixa3F0RDdBQ2c2dy9PeTRhZzl5TGg4T2tpMjhrZklWaHRZOCtO?= =?utf-8?B?SDF6ZlA4NlBMUm1FaGxUeTQyY0JySG5sRDBpcjkwTG5RN0VZU2FRMUwwRTg0?= =?utf-8?B?NFR5VlMzVjVsTGRqK24rNFl3U2VmQVpwUmc5Wk56SUI0Qndld1pLRVVPZ3JR?= =?utf-8?B?RmVJRUQzZmo3SmdHUlJGMUNEYlRUaGdRNjhUSGkwVEhRaXg1OER4enQyR1ZE?= =?utf-8?B?eXlYQXBidG9jWWpmK1AwcTh6U3V5NlN3TEsvWlhEaXJaKzJwdUY0OWR6WUVE?= =?utf-8?B?ay9ncWI5WHpyaVRJUzZTYlRLMlNmVEJsaVZUMTRmQTBJWnp3TzdnUmhQWjBw?= =?utf-8?B?ZjJmVThHM0ZBbDRta1lCZEU3M3VPTFZIN3VwbGJ1ZEtUaElUS2E2UTBTMWJ5?= =?utf-8?B?VlE0ZkxUZ0xWVEtOMXh2OW5nRHV4QzF5dVJYblBTV28vWGRLZEtVTythVDE4?= =?utf-8?B?MnBNbjN0azdXT01vbHBTZDA1SEs5bnYyL2U5c01QSlRIMDZtZTBRaHBPVk83?= =?utf-8?Q?OTLdnO2KQldLou+5MsT8LGsgb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5735dece-13c0-4344-a887-08db0e5ccc7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 07:26:34.8804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mCJYGbQeZUaDzd8tfn7Oni5FvyAzeDqVx3BDG6GLz5PYkldeRafQQkg7VUVOVztPiCH2XE6pxxca0borbodP1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7466 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13.01.2023 11:19, Jan Beulich via Binutils wrote: > While benign right now, everywhere else register forms come ahead of > immediate (alias) ones. That way both also end up next to their non- > alias (i-suffixed) forms, making it easier to see that the pairs are > identical (except for INSN_ALIAS of course). With the equate considerations in [1] it may actually be the case that the adjustments want to be the other way around, for all immediate operand aliases to come ahead of their otherwise similar register-only forms. Yet as said there - first of all it needs to be established what the intended (and then consistent) behavior is to be. Jan [1] https://sourceware.org/pipermail/binutils/2023-February/125993.html > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -438,10 +438,10 @@ const struct riscv_opcode riscv_opcodes[ > {"lw", 0, INSN_CLASS_I, "d,o(s)", MATCH_LW, MASK_LW, match_opcode, INSN_DREF|INSN_4_BYTE }, > {"lw", 0, INSN_CLASS_I, "d,A", 0, (int) M_LW, match_never, INSN_MACRO }, > {"not", 0, INSN_CLASS_I, "d,s", MATCH_XORI|MASK_IMM, MASK_XORI|MASK_IMM, match_opcode, INSN_ALIAS }, > -{"or", 0, INSN_CLASS_I, "d,s,j", MATCH_ORI, MASK_ORI, match_opcode, INSN_ALIAS }, > {"or", 0, INSN_CLASS_C, "Cs,Cw,Ct", MATCH_C_OR, MASK_C_OR, match_opcode, INSN_ALIAS }, > {"or", 0, INSN_CLASS_C, "Cs,Ct,Cw", MATCH_C_OR, MASK_C_OR, match_opcode, INSN_ALIAS }, > {"or", 0, INSN_CLASS_I, "d,s,t", MATCH_OR, MASK_OR, match_opcode, 0 }, > +{"or", 0, INSN_CLASS_I, "d,s,j", MATCH_ORI, MASK_ORI, match_opcode, INSN_ALIAS }, > {"ori", 0, INSN_CLASS_I, "d,s,j", MATCH_ORI, MASK_ORI, match_opcode, 0 }, > {"auipc", 0, INSN_CLASS_I, "d,u", MATCH_AUIPC, MASK_AUIPC, match_opcode, 0 }, > {"seqz", 0, INSN_CLASS_I, "d,s", MATCH_SLTIU|ENCODE_ITYPE_IMM (1), MASK_SLTIU | MASK_IMM, match_opcode, INSN_ALIAS }, > @@ -476,10 +476,10 @@ const struct riscv_opcode riscv_opcodes[ > {"rdtimeh", 32, INSN_CLASS_I, "d", MATCH_RDTIMEH, MASK_RDTIMEH, match_opcode, INSN_ALIAS }, > {"ecall", 0, INSN_CLASS_I, "", MATCH_SCALL, MASK_SCALL, match_opcode, 0 }, > {"scall", 0, INSN_CLASS_I, "", MATCH_SCALL, MASK_SCALL, match_opcode, 0 }, > -{"xor", 0, INSN_CLASS_I, "d,s,j", MATCH_XORI, MASK_XORI, match_opcode, INSN_ALIAS }, > {"xor", 0, INSN_CLASS_C, "Cs,Cw,Ct", MATCH_C_XOR, MASK_C_XOR, match_opcode, INSN_ALIAS }, > {"xor", 0, INSN_CLASS_C, "Cs,Ct,Cw", MATCH_C_XOR, MASK_C_XOR, match_opcode, INSN_ALIAS }, > {"xor", 0, INSN_CLASS_I, "d,s,t", MATCH_XOR, MASK_XOR, match_opcode, 0 }, > +{"xor", 0, INSN_CLASS_I, "d,s,j", MATCH_XORI, MASK_XORI, match_opcode, INSN_ALIAS }, > {"xori", 0, INSN_CLASS_I, "d,s,j", MATCH_XORI, MASK_XORI, match_opcode, 0 }, > {"lwu", 64, INSN_CLASS_I, "d,o(s)", MATCH_LWU, MASK_LWU, match_opcode, INSN_DREF|INSN_4_BYTE }, > {"lwu", 64, INSN_CLASS_I, "d,A", 0, (int) M_LWU, match_never, INSN_MACRO }, >