From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by sourceware.org (Postfix) with ESMTPS id E51D03857737 for ; Sat, 7 Oct 2023 23:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E51D03857737 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CFFB54C167B; Sat, 7 Oct 2023 23:11:04 +0000 (UTC) Received: from pdx1-sub0-mail-a246.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 60EAC4C1716; Sat, 7 Oct 2023 23:11:04 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696720264; a=rsa-sha256; cv=none; b=rrLzHBKcLZVYfZcgFpg6TXHH8iVVmiAC1i8tNvXhim31y4Ew3c+nL1ooXlVwGZFfufLHXZ eJDZEuBX6QFCz6Fmjg+ZS67N96UwHNdmg8opjIO9eGEq6PJ4o4K/KXJ4NOr+p7Q7t4NDzh 1hNuF/yOuhnciOVbgRMjDYJ3RyFUB4d/bjDl+Ed/LfREnHl+M469bEY/Kz2/ls+HUOP9pE vmKqGu/TrmttNWA85uJoWbt5oqGqsSGjWe1hO9FgdZ0uhcDhVjIWaErJWWb+Y8Q2vIXtLC X66f6kqjMV4ew5cuVGW3J5aJgxKSQo9DLLms34jsl6nkW/wgVJTTLgRSEBLbYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696720264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yCUjhPwF/zoK/hgrpkIHVmW1FEYxbl6n70hdRHBXjqU=; b=JQwo+HvQQ+Vt9bhKPLiTcpzi+9EAgYc0H+n0rJc1aOpEQj4HSOZZleWs9B+RbY8zxkzCM2 /SMCNjbQswWa6usuB5GiAfh1I6erEZPvoDUwwvozrbRfrYzYV3xsL639al6S2EZA13U5IV ST50nu4D4kWBbwJBmoULCXHQ6RnA4aTGtei6fwYoWEk2LiuJb3pRV1eeQVby6anRge5XoK xZoLhZSrQfCCaD0bJYB1VvsjdpY/iOe281qKW6V06580JTI3neyJqN/n/OPswzraaLYweV dUIjVqtR6Ozx62M0b+Mgap2K5VwMFDmMhyrLood9b8BfMU+FHBNtGmXR4u4aLQ== ARC-Authentication-Results: i=1; rspamd-7c449d4847-25hg7; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Lyrical-Squirrel: 0519890a17bb8116_1696720264702_3437932197 X-MC-Loop-Signature: 1696720264702:54893529 X-MC-Ingress-Time: 1696720264702 Received: from pdx1-sub0-mail-a246.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.131.218 (trex/6.9.1); Sat, 07 Oct 2023 23:11:04 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a246.dreamhost.com (Postfix) with ESMTPSA id 4S31Hq4Nd8z54; Sat, 7 Oct 2023 16:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1696720264; bh=yCUjhPwF/zoK/hgrpkIHVmW1FEYxbl6n70hdRHBXjqU=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=LL0oesVVZrIeOoo80aGTNzODZgD2jGDmjBvMozY9yNe4nVYTUb3Ep8zd8poyfrXWj PCRhFfaocpTQ3aDtIO3VTbU5e8da79eBdze6vDq4TeBTMDeKlw6jcKu0/IeMNDmzXT 3T1VdSx8gBUjpdjPCDzleL0FKi9nEvzJF2oBr9m2o04aRQgA1h0Zu0jIH/Om4oOF/Z egHWlY5n+IA8m7KjlNJCjF5qdftSq+W60VP5mJD2V4JLsYeXbBUVtfR4DqXEAYGcGY 5lYUxd2UNopWj4OVJcn3rkH1eaKtIlDTUoYkiODd+85byboo/Z7ppHa7dWELPkSQqw Y+I3+ciQiQNjw== Message-ID: <66d26b55-0457-9ed6-50af-0f5feeb057b0@eagercon.com> Date: Sat, 7 Oct 2023 16:11:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/1] opcodes: microblaze: Add new bit-field instructions Content-Language: en-US To: Neal Frager Cc: binutils@sourceware.org, ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com, Nick Clifton , "Maciej W. Rozycki" References: <20231005125103.1330807-1-neal.frager@amd.com> <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> From: Michael Eager In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Neal -- Please resubmit this patch. Add test cases for new instructions. Fix GNU Coding Standard issues. Run binutils test suite. Thanks. On 10/7/23 12:23, Maciej W. Rozycki wrote: > On Fri, 6 Oct 2023, Michael Eager wrote: > >>> This patch has been tested for years of AMD Xilinx Yocto >>> releases as part of the following patch set: >>> >>> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils >>> >>> Signed-off-by: nagaraju >>> Signed-off-by: Ibai Erkiaga >>> Signed-off-by: Neal Frager >> >> Committed. > > Yet it has caused numerous regressions: > > microblaze-elf +FAIL: unordered .debug_info references to .debug_ranges > microblaze-elf +FAIL: binutils-all/pr26548 > microblaze-elf +FAIL: readelf -Wwi pr26548e (reason: unexpected output) > microblaze-elf +FAIL: readelf --debug-dump=loc locview-1 (reason: unexpected output) > microblaze-elf +FAIL: readelf --debug-dump=loc locview-2 (reason: unexpected output) > microblaze-elf +FAIL: readelf -wiaoRlL dw5 > microblaze-elf +FAIL: readelf -wi dwarf-attributes (reason: unexpected output) > microblaze-elf +FAIL: readelf -wKis -P debuglink (reason: unexpected output) > microblaze-elf +FAIL: readelf --debug-dump=links --debug-dump=no-follow-links dwo > microblaze-elf +FAIL: DWARF2 1 > microblaze-elf +FAIL: DWARF2 2 > microblaze-elf +FAIL: DWARF2 3 > microblaze-elf +FAIL: DWARF2 5 > microblaze-elf +FAIL: DWARF2 6 > microblaze-elf +FAIL: DWARF2 7 > microblaze-elf +FAIL: DWARF2 11 > microblaze-elf +FAIL: DWARF2 12 > microblaze-elf +FAIL: DWARF2 13 > microblaze-elf +FAIL: DWARF2 14 > microblaze-elf +FAIL: DWARF2 15 > microblaze-elf +FAIL: DWARF2 16 > microblaze-elf +FAIL: DWARF2 17 > microblaze-elf +FAIL: DWARF2 18 > microblaze-elf +FAIL: DWARF2 19 > microblaze-elf +FAIL: DWARF2_20: debug ranges ignore non-code sections > microblaze-elf +FAIL: DWARF2 21 > microblaze-elf +FAIL: DWARF5 .loc 0 > microblaze-elf +FAIL: DWARF4 CU > microblaze-elf +FAIL: DWARF5 CU > microblaze-elf +FAIL: Check line table is produced with .nops > microblaze-elf +FAIL: line number entries for section changes inside .irp > microblaze-elf +FAIL: line number entries for .macro expansions > microblaze-elf +FAIL: line number entries for expansions of .macro coming from .include > microblaze-elf +FAIL: lns-duplicate > microblaze-elf +FAIL: lns-common-1 > microblaze-elf +FAIL: ld-elf/pr22450 > > They all seem to follow a similar pattern, e.g: > > exited abnormally with 1, output:readelf: Warning: Corrupt unit length (got 0x4e00004e expected at most 0x4e) in section .debug_info > > FAIL: DWARF2 1 > > or: > > exited abnormally with 0, output:readelf: Warning: Corrupt unit length (got 0x20000020 expected at most 0x20) in section .debug_info > > FAIL: Check line table is produced with .nops > > Configured with: > > $ /path/to/configure --disable-nls --disable-gdb --disable-gdbserver --disable-gprofng --disable-libbacktrace --disable-libdecnumber --disable-readline --disable-sim --enable-obsolete --enable-plugins --build=powerpc64le-linux --target=microblaze-elf > > Just reporting in case it's useful as it has popped up in unrelated > verification; I won't do anything else here. > > NB I've skimmed over the change and noticed it does not follow the GNU > Coding Standards in many places, most prominently in `get_field_imm5width' > and `get_field_rfsl', but also elsewhere (which is easy to spot looking > through the diff). > > Maciej > -- Michael Eager