public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Nick Clifton <nickc@redhat.com>,
	Binutils <binutils@sourceware.org>,
	Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Subject: Re: Build issues due to patch "gprofng: a new GNU profiler" – CLOCK_MONOTONIC_RAW not defined
Date: Fri, 18 Mar 2022 16:25:53 +0100	[thread overview]
Message-ID: <66d46cf4-ac4d-94bf-ffc4-168903e7b24d@codesourcery.com> (raw)
In-Reply-To: <35f693ef-3006-bece-21ab-2e6e46255a11@codesourcery.com>

Hi Nick,

I was wondering whether you still intent to apply the patch? It would be
great if the build would work again after a week ...

Thanks,

Tobias

PS: Regarding the proposed patch, I wrote:

On 16.03.22 15:55, Tobias Burnus wrote:
> Hi Nick,
>
> On 16.03.22 13:29, Nick Clifton wrote:
>>> Thanks for the commit – but it fails for
>>> .../bin/ld: ./.libs/libgprofng.a(gethrtime.o): in function
>>> `gethrvtime':
>>> obj/binutils-src-mainline-0-x86_64-none-linux-gnu-x86_64-linux-gnu/gprofng/src/gethrtime.c:131:
>>> undefined reference to `clock_gettime'
>>
>> Hmm, it looks like I missed a few places where the -lrt library is
>> needed.
>>
>> Please could you try out the attached patch and let me know if these
>> changes
>> (on top of the ones that have already been checked in) are enough to
>> solve
>> your build problems ?
>
> Works – I had some patch-apply fails due to HJ's commits, but fixing
> the .rej was trivial. (One line removed, two #line number changes, and
> two changes in makefiles (.in, .mk) in two files which were already
> there.)
>
> After doing so, your patch did build with the two x86-64 Linux build
> servers (both require  -lrt, but only one has CLOCK_MONOTONIC_RAW). Thus:
>
> :-)
>
> Thanks,
>
> Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

  reply	other threads:[~2022-03-18 15:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 10:57 Tobias Burnus
2022-03-14 18:16 ` Vladimir Mezentsev
2022-03-15 15:24   ` Nick Clifton
2022-03-15 16:24     ` Tobias Burnus
2022-03-16 12:29       ` Nick Clifton
2022-03-16 14:55         ` Tobias Burnus
2022-03-18 15:25           ` Tobias Burnus [this message]
2022-03-18 15:47             ` Nick Clifton
2022-03-15 16:54     ` Vladimir Mezentsev
2022-03-15 16:59       ` Vladimir Mezentsev
2022-03-16  7:56       ` Tobias Burnus
2022-03-14 20:53 ` Joseph Myers
2022-03-14 21:52   ` Vladimir Mezentsev
2022-03-16 11:30   ` Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66d46cf4-ac4d-94bf-ffc4-168903e7b24d@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=vladimir.mezentsev@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).