public inbox for
 help / color / mirror / Atom feed
From: Nick Clifton <>
To: Jan-Benedict Glaw <>,,
Subject: Re: [PATCH] diagnostics.h: GCC 13 got -Wself-move, breaks GDB build
Date: Mon, 3 Oct 2022 14:49:55 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Jan-Benedict,

> +# if __GNUC__ >= 13
> +# endif

There appears to be a convention that the definition should be broken
up over two lines, ie:

   # if __GNUC__ >= 13
      DIAGNOSTIC_IGNORE ("-Wself-move")
   # endif

Although DIAGNOSTIC_ERROR_SWITCH appears to be the exception to this rule.

More importantly however, you need to provide an empty definition at the
end of the file should the macro not be defined.  ie:



  reply	other threads:[~2022-10-03 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 18:54 Jan-Benedict Glaw
2022-10-03 13:49 ` Nick Clifton [this message]
2022-10-03 14:24   ` Jan-Benedict Glaw
2022-10-03 14:36     ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).