From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 829293858C2C for ; Mon, 3 Oct 2022 13:50:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 829293858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664805000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyzz7cVHu7AHKjd1M1VgC4yTR4K43USiKZzUNPuYDiw=; b=ORnXgumo5Ox4vc8yhehp2Plc05bKe5HZzJvdkdZ1mOsWr+Xwp2+/uSTrLr5Hf2vym55625 L2WP9aHzb1abrAEqV51cXlzuwHfihhj03ASCEYMeZWxCTm6uH//Ff7cA9js1NEQWDjOXF7 mx84GYlsDQViO4lkN8yU2P5+raFe9FU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-9-oNB1k8OAMY6vnvZvjyKjAw-1; Mon, 03 Oct 2022 09:49:59 -0400 X-MC-Unique: oNB1k8OAMY6vnvZvjyKjAw-1 Received: by mail-wr1-f72.google.com with SMTP id s4-20020adfbc04000000b0022e03fc10a9so1793128wrg.15 for ; Mon, 03 Oct 2022 06:49:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=jyzz7cVHu7AHKjd1M1VgC4yTR4K43USiKZzUNPuYDiw=; b=j7B9r3uGV20c7+mfUTvn3bdmufbQFlV4qLLCAaGhn3aPkwlg5zQY2PBv4firMWugPT YEFqXQxQQkgjdXRyKhAClp4NYwWvYbZJyuTxqYJN86aiFTcPKRLfNOmm5X70ymo1hUU1 CCe5xx6VDTxqUrx+2uqZ9ZSXqEKRyS6dzcwY5QGPVx8R0z2GSbehvlykHBDML/CBYuVs 2ZOvXqcYyReVLsCVpF4KmJnbG6ZLxn3tWmu0gg8gHahEYHfpRIvgNwtJD+0UJ+L3Zjtk zki/rHPoca7kz5+ZCH6wlCJ2LyWYjpBt+tNYeNLEOi5OTkJ79knzyZOO88TCtT0EnOt2 BOlg== X-Gm-Message-State: ACrzQf3fSiqGN2jqPmdhZKgS4KKz2o2W9LakYHGnVh5kgDPHumhvQeIq dag1TASDnSGtK1IT+CnKQxuJA1yhUyZPVeiGSiL5zgi423uHeXnNJArnIIeP8Ghp7o9q1sMgF3A ZNEFZRWCIyjbh+8S5mQ== X-Received: by 2002:a7b:cb49:0:b0:3b4:b08a:89b with SMTP id v9-20020a7bcb49000000b003b4b08a089bmr6818117wmj.173.1664804998416; Mon, 03 Oct 2022 06:49:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5sucBm95hyeZzjoclSNy2U7MNnIedb3hmAEoKgXcp9iSjjddlvQf2FQgOQ9mdqj+Ms+ss1Vg== X-Received: by 2002:a7b:cb49:0:b0:3b4:b08a:89b with SMTP id v9-20020a7bcb49000000b003b4b08a089bmr6818105wmj.173.1664804998215; Mon, 03 Oct 2022 06:49:58 -0700 (PDT) Received: from [192.168.1.18] ([79.123.82.157]) by smtp.gmail.com with ESMTPSA id c10-20020a7bc00a000000b003b49bd61b19sm16369197wmb.15.2022.10.03.06.49.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 06:49:57 -0700 (PDT) Message-ID: <670fd724-f14f-565f-b4a1-5883a8a1b5ab@redhat.com> Date: Mon, 3 Oct 2022 14:49:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] diagnostics.h: GCC 13 got -Wself-move, breaks GDB build To: Jan-Benedict Glaw , binutils@sourceware.org, gdb-patches@sourceware.org References: <20221002185433.gl7dvytfh5wthifx@lug-owl.de> From: Nick Clifton In-Reply-To: <20221002185433.gl7dvytfh5wthifx@lug-owl.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan-Benedict, > +# if __GNUC__ >= 13 > +# define DIAGNOSTIC_IGNORE_SELF_MOVE DIAGNOSTIC_IGNORE ("-Wself-move") > +# endif There appears to be a convention that the definition should be broken up over two lines, ie: # if __GNUC__ >= 13 # define DIAGNOSTIC_IGNORE_SELF_MOVE \ DIAGNOSTIC_IGNORE ("-Wself-move") # endif Although DIAGNOSTIC_ERROR_SWITCH appears to be the exception to this rule. More importantly however, you need to provide an empty definition at the end of the file should the macro not be defined. ie: #ifndef DIAGNOSTIC_IGNORE_SELF_MOVE # define DIAGNOSTIC_IGNORE_SELF_MOVE #endif Cheers Nick