From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2083.outbound.protection.outlook.com [40.107.8.83]) by sourceware.org (Postfix) with ESMTPS id 833643858C98 for ; Wed, 15 Nov 2023 08:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 833643858C98 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 833643858C98 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.83 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700038659; cv=pass; b=HqOd7k+PiENz/FD8mkQflA29NUFcNNLLNuKzRFTF744UzwYabZgNWFjqHTh1M3bQNZ4939FyU4stY6tXtGzLs9UDER/8C2dSIm9LwqLe9jPmMDncW8Fq7mABnDoNfjlrBxCs0dFf/cia3PuI0exjJa9tGXpzf3SKdq9q8+nNQew= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700038659; c=relaxed/simple; bh=/8Mg/6NMHYsTup6PfwULntKYf/HAQiv1OEFLRutQ194=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=FDft3iU4OP+BkEwcVdarrj4FXMgdFiwxxhdhuD9rkqTk/meyR0/k88lOWWvLnRhPgyJDY6nrSjTFhsytVt279D5DZD1F/IDhF8oeyECLVkqtliHB8GO3cHoyTZpM5M2KsvjNlcGt19FHha2Q5Fjib9Pdu8sqTquh6Tsw5vOtrfc= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GtFmpbUq9SsO6YsJt8rSQiavVoXwjvTkpLFuouNuHMPyxt0DNtEo88phZDUSNoz6Zqz62fjuPzL6TXpWWfpRiKMPlJWOkW3S3/2sLd/i31nUulZVo5SRezfBuR4PGsFiKRGIu617m0RCo3jNOrbNt/0uWKYnqP/bnShPXSwoQS3u2k59AXDwoxT7+FbdqotsBFjW3xDm6QQBRjp+aBUYFqpEeifZICsJSPuMnpyHa40h5xiFRpM9Qf0VFC0VBVB7r+RG29zxkSQchgROTqgsIRhvTpzgsEXI+p9HE82izl1//8QQyB+7B6HHoF0mNFMZkFFbArXuHYpoTtdQSZg8mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOgbHEvL13/zvhPIvG/bI5QWBuODETbXnrrsb9AVTNI=; b=EM5v9SOnownvg9ehyMsVKamRmgtO5/R/TYMT/jCJUA2aZQxYrZiSC6RQllD8OcBk143B3pXOHRp9x+B0ipiYwcpGY2wji0gSqqabnQCzkNuNo3HB93WQ7wdc2fewtI0jd3FA7ZYvCT0OOLd5FgkzXphMODJJ8yStb96gTKtFQ5Un7wn8Zr8Aa1M039zX7vLqaWljdGEh/DlRDJlVP/VsZSyLZNt49hA223GUk0pStPtnjTWLF7KdAujRvPYu4G5HXsV6EA52ZXRblyHN9bIFhPDIXh5jnj2cZG3M4gnFAYH9T50NvMtYjYA89G0chvaltAhEo9cc6CaiFP8rEVKGMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOgbHEvL13/zvhPIvG/bI5QWBuODETbXnrrsb9AVTNI=; b=JxI5FE5RJXrp2dvrnxlVPYmYyG5xSPieFMJy1e42PbRJFASjY65cNxZuberKq/6UzZ9Ye7ipsbqxWxP0tDSyv+cdD2LZbIrLCFPKjUxmgiZxGLTjfpp4hVsT6/AthcS8eNJi0xRjCLqw/l/B96AheBlwyOUtHXef52ijPQLuETbiY+soB5JTbo8r6X/u05iX6lEs6EPggm2E4c/76gBZNzT6xp3Hew0uGh6y71K353Bn0+55wlg9DTL7+4zVkx8w22G8U9vqNrwfOtRXCDkfwWTtPlijOK2oKHu7LwxKWONrH3nmwCx0/5qX/V9Vp/J153yKLFDhSopvT/0MAZzHSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9335.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.18; Wed, 15 Nov 2023 08:57:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7002.019; Wed, 15 Nov 2023 08:57:34 +0000 Message-ID: <678ca881-2a7c-4810-85a1-2c04d7c2d896@suse.com> Date: Wed, 15 Nov 2023 09:57:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Cui, Lili" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-8-lili.cui@intel.com> <8ed3b7a2-8cba-6428-1c01-5b6c28ca4a89@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9335:EE_ X-MS-Office365-Filtering-Correlation-Id: d9eb1f53-c186-472d-83bf-08dbe5b8e872 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U78/fIJNOLp3EBH4maEEi35xBcGrsILrmtzaAJj4/1Isp2gPNVCn27OWZNwsUMXmfmMDnjVePD/j4ta9T4jy1AIOjOk1Al6Mz4u+fYyGgDgzhPRfoF+dfa4q3nPeKlynLYH6DM7rjIk0QcVzQNE5LqoaI151YX3NAmj85hDRoveb9Rgtlqpt0VW8BTN03LiI3JcDs5YFcEhuX2/lPesp4BfAHTYEk0qhzeRSNDt4ywpALsxNg8ZYxTizrhCLul+cN+07YLTWXQxGhgJmiavlm1a85tckQrsDsjy7uyI3Wau3ZRwTrrBqXHpuMwPWnVIMGAD6p8gn/n8h0KQWbe8Cblg6FvgsbboMDIh9rI32yYzpR6VJxxQNTVxM61xfeWd/y5xH4kBq+afCEpzhQFnQlEpxscrTr7ffX5ItfS9dtnp0Ue3Ter9o/1lUEKES9+nMSuRuBsH4TUSUg+XENj7Nz2V8NvyIeJt9f5H/m2fmaPiHaQDEd2vjoadj/FONCbPnFO4Sp0zTpBm8wx6Gsmixi0Gs4Q/EmYzJRnoRbEZHUST2d98Nx/ewIntbIjbwLOUEik66uYp7x9j29ws/2o8GlcPkufNgFt0L9u3Yue6F1tRnJga8JF84NnUsq2+5VX9v6jACWQv1WRnLv8Ps4Dlv6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(366004)(39860400002)(396003)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(2906002)(2616005)(6512007)(83380400001)(26005)(41300700001)(6486002)(478600001)(6916009)(31696002)(36756003)(4326008)(66946007)(66556008)(316002)(8936002)(54906003)(66476007)(8676002)(19627235002)(53546011)(6506007)(86362001)(5660300002)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHdlK3VRK3NCMi9nSEFVQkxBWnVaaVFPTWt5eEhCQWtqM3hWdkVUNHBjME16?= =?utf-8?B?clFZVHZ1cExUWjlkcUY3Q3dJUkJabWIrQWRtdkZuMnZCL0F2RlBsUjZuaFRK?= =?utf-8?B?WE12NUNsVWdFK09OU005dmxRczZIMDNWVW9lYk9wNFV3MUsyNHRpem5FdUZy?= =?utf-8?B?Z3g1QmVKVW1wdk5TMVR4M3g4cjZhNHQwcHY1LzlLT3A3d3Z2VWNkUUZnc3dT?= =?utf-8?B?MkZNajRtVjUvbFRzL2tjLzdpUUZ0VkUwd1kzaHlIVlZnMkpWeldTeVg2dXpY?= =?utf-8?B?UTVuSjMrNVNOZ2p4ejE0SlZ6NGhRRVFXeHFTWktJS1UwaVp1blBCOU9XZWlK?= =?utf-8?B?SWd2UjUveVcwWWFaemdrSVZOelhudWNhREZSaStxWFNCRThIbkhyWnVLQzlm?= =?utf-8?B?NXViOUhEemE5Tlk1WGRLQTJ6MDc1SXlHdkJ1eWhMbEVNMGtGc0l2cXZZMERn?= =?utf-8?B?WUR6TWlsWFRCckxZTmdPR2FMNkdmUEZKd29yVnBwcldka1RtajNVR2NQWlAw?= =?utf-8?B?TnUzOXZLK3ZqMTRFN0doSFB2N2w4LytPWFdpNmwvYjZmOUdoUEp4dTd1Zktp?= =?utf-8?B?cDdDNWFicHVnWDFISTBkR2p2bjRVckd0cHJrMkNYS2QzWTF0bnFPY2ZvVlNi?= =?utf-8?B?VWptNlFLODVjNUVuVUh6Q3laVkIxOUl1ZER4aDNWU2lEMVBtRWdpOUkxM2Q3?= =?utf-8?B?ZEtMbkVicm9ieXBSclFzOTROb0tHcDVxUkN1aU9yYmVvMXQzOW9LbjBSdm9T?= =?utf-8?B?QUhMMk1yL0p5NEo4Q1RoWWpVZEVYRjAzRmRVMWM5N2ltSHVsS3U2NHhPQzhH?= =?utf-8?B?TVFyeXNlOGdFeVMzSUpyU1pRREIvSFY0aWpVRnpOdmRoeTNNaGE1eDF1RW5Y?= =?utf-8?B?SUdQY0VUYUR2SmJUMUdzZ2VZV0l5TDVVQ2tjbThRUzFmOEZ4UmxEREhvTkVk?= =?utf-8?B?TWZTeEVyRm9aSHY1OVM3SXBRblVqS3BaTlNYZjMvN1pnL0hNTHBPanByRmxZ?= =?utf-8?B?ZHptT00rVGczcUtPcVRvU0tRb1ZmM21Jc1FpQitxT3BaNGhvRm9PUE03TW9v?= =?utf-8?B?T2EzU1pEcTRGWXYwQkVLZ0NUQ2J0SWRjOWhLZkVneWZPWVVrWEVCVVV0Qm1r?= =?utf-8?B?YVA3Rjc2NTFySUNyL05ZcFkwSzlzZTlLRFpYaytGR3BnZTdydUZXVTZWbHov?= =?utf-8?B?RGxFSUF6Q3ROMWVsRm5ITWNaMk9VSlJEaTBiYzhuU1E5TldRZUhVNVhWdGl2?= =?utf-8?B?UENZaUJQSkwvQ1J6RmpwN3NmRDQyL0xmelVwRlU1aDQxTmVHTzJYRUs3b3Nw?= =?utf-8?B?S0ZrSUdDZ2V2bWNHOWs1L3dUMC96aFdjWkd4MGZwTmdBbmJzQzV1QXc1S1VK?= =?utf-8?B?YjJQQTI1aEpWTXVXd2R0N3JpcGpuK0cvRlN5WWJDUG1mWEpzcURRaU80SGg1?= =?utf-8?B?alF1T01ab1BYMENscnAvYytRVkFrQ1NERlhNOFcxelVtV2EvNFBBTGg0QTZY?= =?utf-8?B?L2NUMTNzcTFtZ3o5VHZocmh6MTJVeksvNms4TFZnN3pwQmxzWTQxaEs3UTJu?= =?utf-8?B?YnYrUVFxT2FFa1FvT3h5SHNuN0RHVWI3N0dJaWF6Rkc3OUhMRTFidUY5NnQ4?= =?utf-8?B?ZUtSbElHckx5NkRlSFFtSGZKMG9XNGU3NHRza1A2d0JMNks1cVRxK1BSWERw?= =?utf-8?B?TXNlT2pSeng1cm1YVStRTFd1Z3lJUFl1VzVIZ2VjTnBFS3c1VzI4aEQxZlNV?= =?utf-8?B?eTBqSXloZ1NUQXlNalVsd3lzVzd4NDNseXJhb0ZtZ04zaGt3WGVuR0w2WUVq?= =?utf-8?B?TVNTRDFjZHRQUEl0SUhOeVR5VFIxSVA3N21KYTI5alpmRC8xWXg4bmhkbW00?= =?utf-8?B?eW9WdjJVMVErRG9taGErSXh0QnlCS2lrMldXMEY0VlJGWE1WTlNkaTV1a3VW?= =?utf-8?B?VHhTMXcybTJuVzF6MnNuNkpHaG5zWXBrVDlyWHlpdDdDRGQwRGc4Vkd1ZEp4?= =?utf-8?B?a0dDM1diRHhBMzhvWC96Y0VlanB2bjdURDZNOE04K29zelNncm9xdjh0M1RB?= =?utf-8?B?akM4alVVMFpWeTIwRDlGVm0zdzNNWEwvK3YvSzRhRi9TUmNDb0Y4UnpnbW1B?= =?utf-8?Q?5HZseYzbXJ2W/NR6Hvpr0oRUC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9eb1f53-c186-472d-83bf-08dbe5b8e872 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 08:57:34.0957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q501Fb/eE+5v47p2hP90KLktm0LxDLDVvOKCwe5EDqe3uNsoGTOWeXatpRqea6T7see5aaaAKwqS3/5B2LdNjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9335 X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.11.2023 03:52, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, November 14, 2023 6:51 PM >> >> On 14.11.2023 03:28, Hu, Lin1 wrote: >>> @ -7728,6 +7765,40 @@ match_template (char mnem_suffix) >>> i.memshift = memshift; >>> } >>> >>> + /* If we can optimize a NDD insn to non-NDD insn, like >>> + add %r16, %r8, %r8 -> add %r16, %r8, >>> + add %r8, %r16, %r8 -> add %r16, %r8, then rematch template. >>> + Note that the semantics have not been changed. */ >>> + if (optimize >>> + && !i.no_optimize >>> + && i.vec_encoding != vex_encoding_evex >>> + && t + 1 < current_templates->end >>> + && !t[1].opcode_modifier.evex) >>> + { >>> + unsigned int readonly_var = convert_NDD_to_REX2 (t); >>> + if (readonly_var != ~0) >>> + { >>> + if (!check_EgprOperands (t + 1)) >>> + { >>> + specific_error = progress (internal_error); >>> + continue; >>> + } >>> + ++i.operands; >>> + ++i.reg_operands; >> >> DYM decrement rather than increment for these? We're trying to go from >> 3 to 2 operands, after all. >> > > Here's a backtrace to considering for possible other opcode_space (0f38,...) instructions that can't accept the r16+ register, but can accept other rex registers or the normal. I decrement i.operands and i.reg_operands in convert_NDD_to_REX2. If the legacy or rex version of the insn can't support rex2 registers, I won't optimize it. So I need to increment these. Okay, I need to see the full patch for this. Incrementing to undo earlier decrementing still looks suspicious to me (for now). >>> + >>> + if (readonly_var == 1) >>> + swap_2_operands (0, 1); >>> + } >>> + } >>> >>> convert_NDD_to_REX2 return readonly_var now. check_EgprOperands aims >> to exclude some insns like adcx and adox. Because their opcode_space is legacy- >> map2 can't support rex2. >> >> Good. Looking forward to seeing the full change. >> > > For some insns like adcx and adox, I'd like to add some details. check_EgprOperands only used to exclude some situation that these insns with gpr32 registers. If we think about optimization in terms of encoding length. Is it safe to assume that some insn with prefixes 66, f2, f3 and their opcode_space isn't legacy-map0 or legacy-map1 won't reduce the length of the code even if they are optimized? Well, no, not always. See my other reply regarding 32-bit ADCX/ADOX. > If yes, I think the code can be simplified like: > > /* If we can optimize a NDD insn to non-NDD insn, like > add %r16, %r8, %r8 -> add %r16, %r8, > add %r8, %r16, %r8 -> add %r16, %r8, then rematch template. > Note that the semantics have not been changed. */ > if (optimize > && !i.no_optimize > && i.vec_encoding != vex_encoding_evex > && t + 1 < current_templates->end > && !t[1].opcode_modifier.evex > && convert_NDD_to_REX2 (t)) > { > specific_error = progress (internal_error); > continue; > } > > For those instructions that don't need to be optimized, like adcx and adox we just don't swap the order, so we don't need check_EgprOperands and backtrack, and convert_NDD_to_REX2 has the same return value as before. > > PS. So shouldn't the name of the function be convert_NDD_to_legacy. Perhaps yes, if the result can also be non-REX2 encodings. Jan