From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by sourceware.org (Postfix) with ESMTPS id 0542A3858D32 for ; Mon, 13 Mar 2023 15:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0542A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUvOH5yHiqWwBBw9vHDCT2oPefeLl1FNUqRr5O/J+HqrU+e6ibWSkeAlYWvuapNNS1O8zJX3ICKjRvozYhJMcC073YyHX/64agrzrmr3x+6gMV/dLfiHvq+9g4keuB+DXoJ2CUppulYtW8A/C9qTBUy+TDI53ZSEj9TnfMpB4eIfuJ+Mm4sEfqt0iRZTTCI3FV/7MpZykHKlUQd7V3r6AWpJYDHVUgiD2jlOYJMU9DPnwZ0thT9Gh7m+d8Qz/l0xw8PWDKSf7tcD26TYoYdqyZ5U1Iwnc3J2qMDc17fkff/3lbppcZ+JwH0+OBFeHuQFLiRWUFUsbtbp4rVT5WsxKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/kafLygERuMH8Cme3apZ6C48jvd8sKqrA817qH533I=; b=XHG/HxJpQzFYHQOorZHvl+K/ts74Aot219xpqh+Az4BNkee3N//S8ynC4QkGvjGJyHTF4apw5knSfp8yuMBUNf6LSl1hp4inclRO2wAf000AE4b7rrUb1BXcH4igwUmiBIxXBDdO/aQh6NgKYTWF+5uIF07cSzIA3aUHMc113Qqr7+f7o+pkFhrIUIkebOvPk5arJ3ysC1/GIlANJ5fDV2yVWjpIq3jsX55D/dvoahd+x3FBodeYmoTjnFsyr5iZh9wk6S8GAxrUjopL+8WXmDVzTL2AwmBNgAPTgvzmxZJtfihj4c581vz8Xx0NeZ2VDqwKDG3rIeCMpCQjKxDOSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/kafLygERuMH8Cme3apZ6C48jvd8sKqrA817qH533I=; b=1v4EZ8fKerAXcp5ubZ6UFViX0TfAPhRFBu9dOjgmXUxZAprpGuH+Vb8T5dwa3RL1pG7o7bSRCDEt/PaUoHGFiFjuEXESGyj9BLdRZgt8bUd/wSZx20SXzVAOv/mrczAUE0zLyl0R1t0mWaLf6OGetfQ2dTl12MxDrozJIxLBmmTdeEOfDTR5wiJnBsU8bcTZrKFGXgOWIVP1N447Yaj7TeKwJFS3TOwJ4bm6yveaovZlP1Ob/VA+C9ztrC5HsvbWppU5YLrgMBSPP8mN2AgU5pXOJXJG2nwAGTcSOdmWHkP6DiDKm2VwaJkOJNR86G0DGn4ElSfjF0bmmRuv6yDTUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8670.eurprd04.prod.outlook.com (2603:10a6:102:21d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 15:57:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 15:57:14 +0000 Message-ID: <67df1a4d-223f-2b4c-4957-394a299fb112@suse.com> Date: Mon, 13 Mar 2023 16:57:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME Content-Language: en-US To: Nick Clifton Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Binutils , Alan Modra References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> <9f769d26-f51c-4f85-f61b-330226c1cc2d@suse.com> <0a576110-624b-6339-b24d-907d6df72e09@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8670:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fd9fa10-5a94-422d-2132-08db23db9cb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CXCkTiOytHTm6QO9nl8KjqY3AUqYpAZx+Jxptt6OLkeDLKaAQQSo+WTNW9zbdHKJWDVHFSZKW6pUvrqI7BvNjaeIKM8sN6NQw/nWnMKOZg8JoTZJixnJiu/v1MQwjzrUrSooeN5DVUfE0sBhZtpz3AbeP5/LLn0+Qelq/viCEFm8s0SGwSvxH7P5DTUN49mtCqghhPDGV8C9osEJ4ySLe13F2lO1UslshyDrXVLk8u/82jrJwJdy2ICcJOUXR2jgs5CnvSWHzWDrkb9Jpn9J+dAnx0rYtcQQzrWf9cKM6hxhxn3POcpfp09p0PzAnIxHymkyDN9e8Man6yW6SKI1CowD2SmwshaT9eJ9C1Y18TikyQZDkrcZJOxwtYJop3B6nRPfI77yZPpsSHWlHhAQd/bN8x0ZKN/jWAnP+lAziPNDBBwFryNiJfz3+QCUtkBYt4OT/UpjRnAtKiK/snUer3S29MWIS2iV3wTqeIDUOleAzMZp2eg+c/keotQCe2EwLRxEvgirQYMUakXke2lG/XS9tx6utrSETpSD+5zpIMNaQjkVQnwNO4B+yVvhH8YI6k54CwepYGlAtZshB04hqWEZIkLknudGAExs4n8FdS40yYcW+wMLgZu6yU/FgKIfVsRsv7HYv5daGXwwIRqvpg7+RL94jOIH1VkBmBAAXAsJaWHmBBCvqHWi6BWz5m5DMtjHK3mg1lGp9ByBczmCEJh624Nhj4JQB5QkNymdt2Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(366004)(346002)(136003)(39860400002)(451199018)(2906002)(31686004)(41300700001)(83380400001)(36756003)(5660300002)(66946007)(8676002)(8936002)(66556008)(4326008)(6916009)(66476007)(38100700002)(316002)(54906003)(86362001)(31696002)(478600001)(186003)(2616005)(53546011)(26005)(6666004)(6512007)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVZYcjRtV0NZb2pQeUJreXU1SDNUdDUxUlA1SFNZZCtodG1wcG82K0pqK2JO?= =?utf-8?B?WWYvVXZQMlM3V1llVzlnRDc2VFZXd01jS212N2I5dk9XRTJjbmpsV2thRnJp?= =?utf-8?B?NzN0OHlwVzMraHpncUR6VW5BWUMydWZ4bkYyTWxLUGpWVDFOTW9QYmRKU2Nl?= =?utf-8?B?emVtZ1A0aks5QjQyY2dPZGlwcmorQzR5UXlTMENJU0oyWmMwTmF3UHlic1pr?= =?utf-8?B?WFV3UGVxRFlGNW04N2tYWmZOeFFNWEprRUQ4eDlObmo4TFZsWTAyYWtia292?= =?utf-8?B?N3Z3cXNabCtqRGhyV0dMam8vVXJuWWxqZmxjeUZCekFoanVBOW9oaElaTFpU?= =?utf-8?B?SStZV2NZazhMVmZ6cFprbEJzMFo4bkU5eXMrVzhjemxtR3VDaEs1c09hL2F3?= =?utf-8?B?NGJuRTBSQXpJQU5sZFh3dUFjbGNaYlBaTGVnb0pQMEdrMDRnTStLU1h3TVlP?= =?utf-8?B?VmR4SFkxKzI0T0g4dHhYTGd4NnJJcmhabmZTc3c4L2RyNjR2a09NV2hoZ2dk?= =?utf-8?B?VGprTEUwT2hiNGE4VUpNUXF1SzJMYndPSEwyMDhPQWJMY3dnN0w0SENLdHpU?= =?utf-8?B?NysyVTJwVEZiNzFqNU9WUVBLblI3WFRWL2ZjVlV0NWhoZjRBRDl3YkFuYjAw?= =?utf-8?B?M2Y0OWhMd3ZZRlRzdkV4VWZCL1dnN2RDUUZqUVlmdTZDZ1pGZDVGd0dCS0R0?= =?utf-8?B?RW5wSnN3VnB2YjRMdkFKT09CdTc4NENSR1Z1UjV0Y2Nqd01NWk5mTXlIc2ND?= =?utf-8?B?U1lPUndGT0RXVnpTdzRxVGo3V0pjdUtuYmdOZkg2dGZ2ZVFFMDkrNmNWL3JK?= =?utf-8?B?L3J4R2ltVFFqZWxLRWpRTkt4MkRMVExyR0kxckF6QWxsQS9aVzh3S0dIN0M0?= =?utf-8?B?OGxJbktLOEpxMHYvTTdIdkRCbmlQSVhhc2VQdDJMU3J5c05adHBONWk5b1cy?= =?utf-8?B?bS9wYndTZkhvMDhpRmIwN0JFeXRSUGp6cnR0a29OQTRJK1I3ckpjRXBISmJY?= =?utf-8?B?bzJlVEY1ME9oejVEMDNISGUvNGtrNDZNcUN6QjlRdHdkdU0yM2hOM21EOHli?= =?utf-8?B?Qk9sVFdVMUZnOUp5NEZ3OHV0YUNyeW1zQ1BTVWhCeG5KU3R6TkpYNWE2RkhR?= =?utf-8?B?cndLU1J5VUIrc0hxQStPZEtQZWNmdlMrRUl6WHRzbXNJNFdGV3dWSzhVQmd2?= =?utf-8?B?RmRJVUQ5UUVRTHBPNVZZQ08yUElkUDI2WGFlN0Izd1F5TnlXNUx2eFdlOSth?= =?utf-8?B?SXRXZk10VndRazMyWjU4a04rYlJxcWlzOUNqWk9hNm54eG16Nkh6NDJ6Wlg4?= =?utf-8?B?cTc0elJ1Tktjd0ZBaDByS3UrTzMwS1BQZDVUM3YvNDAxMVQ1QVpnd1lZNGUw?= =?utf-8?B?WmpoZHYxSmh4Mmd5cUpXZUdHdjRxVUt1VDgxNERzdGFCL0cya3hMd2w5aUJ0?= =?utf-8?B?R1AybHNkNy96K3l3N0p5Rys1YUM0dHhrelltL1grbTEwWE9pZ0NyQ051STI4?= =?utf-8?B?cDMyVHJJTHlkcER0YXF3ZXdrVmw0SzdBZHdPWnUwNHJKeWpvS3BEUEJpOVZO?= =?utf-8?B?Y3pFS0x1ekRiWmxpL3JDVDJpdmhDbW5vaklXakRMeTd0aU1XMStMeWFVdFVE?= =?utf-8?B?U0M5UG15K1JtSnBiY29BaThzcVdibUsyOHR1eHV1eUQrQmx3UHNhOGdqSXNk?= =?utf-8?B?cHVqQ2RiRlh3N0M1K0IwOWZaZWU3OXFqdzhVNXJ6eFpwcWhPTXIxM25Fb0hh?= =?utf-8?B?eUNueVoxTkEwR29jSkxCdjJ3djVwdUNBNUE5SHdiUGQ5REhvdkl1M2lFWHFY?= =?utf-8?B?aHpQSkd3MDV2eG83V0gzRUtFbS91cm1vcUl0amMzUUp1dm9GNTNYb1V5Snc4?= =?utf-8?B?bmxTVHdBWGhRQzQ0ckRNSVdrdUhGVXMxeDJ6UjhzRkF4Mzl6MXZUU1BsQnVB?= =?utf-8?B?VjVJNEx4TVFDZXhpamhPbCtsRTFXUGNKZEtkeW5ySE1NcGNZQ0FHb2dmbXc1?= =?utf-8?B?RWRoVG0yMjl1cGRVK1ljQWxzWG5jN0hsYkcxQ1ZYblBJMTF6OXFvRk5LU2VS?= =?utf-8?B?alZpVS9BMGlIei9FM3RiMU5nejFyVi9PNzZOdld5V2FsRDNwMmRqM0ZZeFhj?= =?utf-8?Q?cmAhTlMNFDMZdZBQSJ/vEk7TZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd9fa10-5a94-422d-2132-08db23db9cb4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 15:57:14.0980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jt1vi5V3OAmCHDuC9NReDUtMEtGAmTKWsxcxy+MMUMfoogQpJklzkBpYSbBMTcoRaoJfM2yWhtM7Gx6NJQ1qXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8670 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Nick, On 13.03.2023 15:25, Nick Clifton wrote: >> What I don't think you addressed is my 2nd observation wrt quoted symbol >> names. There all characters can appear in symbol names, and hence >> deriving "local" (or not) based on symbol name looks wrong to me. > > Ok, that is fair. Let's see. So the issue is, what should S_IS_LOCAL do > if a user provides a global, quoted symbol name that includes characters > that match DOLLAR_LABEL_CHAR, LOCAL_LABEL_CHAR or FAKE_LABEL_CHAR, right ? > > I would imagine that this is an extremely unusual case, which is why it has > not come up before. > > First off, I wonder why S_IS_LOCAL does not check to see if BSF_GLOBAL is > set in flags and return false if that is the case. If it did, I think that > that would solve the problem. I cannot think of any situation where you > could have a global symbol that needs to be treated as local for the purposes > of S_IS_LOCAL. Well - fundamentally I expect there to be a reason for this name checking. It may of course simply be a remnant of non-BFD-gas times. It could also be that this works around certain supposedly-locals being marked global by mistake. It's also not clear whether e.g. the comment in write_object_file() regarding the relation of S_IS_LOCAL() and S_IS_EXTERNAL() is merely writing down the observation of S_IS_LOCAL() does, or whether it means to point out that this has to be that way for a reason (which then sadly isn't mentioned). I wonder therefore whether S_IS_LOCAL() and S_IS_EXTERNAL() can't be made true opposites of one another (with perhaps one of the two simply expanding to a call to the other, inverting the result). > Alternatively, maybe it would be simpler to just document that quoted > symbol names that contain special characters might be treated as if they > were local symbols, and leave it up to the user to decide whether they > want to risk such behaviour. Not very user friendly, but it would match > the current behaviour. We could also add a warning to read_symbol_name() > and get_symbol_name() to alert users to the problem. That's not good imo, as it might end in surprises / perceived regressions: We couldn't easily change the special characters we use, or add another one if needed. So I guess ... > What do you think ? Any preferences ? ... my preference is clear - see about making S_IS_LOCAL() and S_IS_EXTERNAL() as close opposites of one another as possible, if no other reason for their differences is known. I can give that a try, and see what running the testsuite says. Yet even if that didn't raise any problems, there'd be uncertainty left due to insufficient testsuite coverage on many targets. Jan