public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [patch] check return from bfd_make_section
@ 2007-07-25 21:34 msnyder
  2007-07-26  6:51 ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: msnyder @ 2007-07-25 21:34 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

Usually gets checked.  Ptr will be dereferenced.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tekhex.c --]
[-- Type: text/x-csrc; name="tekhex.c", Size: 633 bytes --]

2007-07-25  Michael Snyder  <msnyder@access-company.com>

	* tekhex.c (first_phase): Check return value for null.

Index: tekhex.c
===================================================================
RCS file: /cvs/src/src/bfd/tekhex.c,v
retrieving revision 1.32
diff -p -r1.32 tekhex.c
*** tekhex.c	3 Jul 2007 14:26:42 -0000	1.32
--- tekhex.c	25 Jul 2007 21:31:17 -0000
*************** first_phase (bfd *abfd, int type, char *
*** 389,394 ****
--- 389,396 ----
  	    return FALSE;
  	  memcpy (n, sym, len + 1);
  	  section = bfd_make_section (abfd, n);
+ 	  if (section == NULL)
+ 	    return FALSE;
  	}
        while (*src)
  	{

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] check return from bfd_make_section
  2007-07-25 21:34 [patch] check return from bfd_make_section msnyder
@ 2007-07-26  6:51 ` Alan Modra
  2007-07-26 18:21   ` msnyder
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2007-07-26  6:51 UTC (permalink / raw)
  To: msnyder; +Cc: binutils

On Wed, Jul 25, 2007 at 02:32:57PM -0700, msnyder@sonic.net wrote:
> 	* tekhex.c (first_phase): Check return value for null.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] check return from bfd_make_section
  2007-07-26  6:51 ` Alan Modra
@ 2007-07-26 18:21   ` msnyder
  0 siblings, 0 replies; 3+ messages in thread
From: msnyder @ 2007-07-26 18:21 UTC (permalink / raw)
  To: binutils

> On Wed, Jul 25, 2007 at 02:32:57PM -0700, msnyder@sonic.net wrote:
>> 	* tekhex.c (first_phase): Check return value for null.
>
> OK.

Thanks, committed.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-26 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-25 21:34 [patch] check return from bfd_make_section msnyder
2007-07-26  6:51 ` Alan Modra
2007-07-26 18:21   ` msnyder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).