From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2046.outbound.protection.outlook.com [40.107.6.46]) by sourceware.org (Postfix) with ESMTPS id E5077384D192 for ; Fri, 10 Mar 2023 10:24:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5077384D192 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ifYYW+hELTD+nW39LuEgFLPEv/4sFijqua+6LmtgYaUgypnniUOOiJEc/Ywg0BFzPCJlbpNfNr8DcnLxyVm5K6JJylA8IyZwicNxQkQgmI1Bp5X9+9M2rooKIVyV7QY8Mlxui1DXbJStjpMBBIvrvtCkun2wkQ3BVCFagMtnUSj84TEPc5B7zs2O6QR8Y83sygKw1kkATVKDMFTyb/WkDVl87A0ptuDZQk+iUQ2reD4E0BF6lV/HV/bNsqRaPTzXrHcEB8YK046pik3NOkDkx3p5goDWgLBLfWIHKCoQVmFGVcW5It0u7TS+C/2nKl/y8S6t3DdTVworqkfiaDf5uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8fdXjgVuX9HiovB3R7V1kaNDAQdF/e+ex5AhLjDSCk=; b=QwHF9DrEudE3pMxsITyRwBejgh6OO3b0mBgUhIdsw+JpjCTXLz6kVo/Y1t4JeqCewlMleQRcZzZEp0mGkLFOayS2gUrW+KYKOPhvtWr1EHFdhTT1RUdXJDZZkJ4/jYfVldfRmPruSxWcMm16zM0Lrc9vc/QnC10R3wcVN4DPCvlO1oMzNdH/Kcj5AEmm8p0HwGu3TI7o1iuGr8fF6HIlOBxKE3aV2kPui2rLabCMUXjbtJwpX2meaO8/V7o7DJlJIP0Os18Eqfr4mtNw4Hdp++mhYQqePy/IJ3POSj1UGisqZumft/V0Tdx6fbTJvSJ4wEssk/7QkjumIVxnKovPow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8fdXjgVuX9HiovB3R7V1kaNDAQdF/e+ex5AhLjDSCk=; b=bSauvTO99GdWioLCektdh+YuL4M3miTWj2uIBQ1aRodG1430SvifvGxoOt9gqn1Jmnn4skqUnak/948G9KxrdirdIpbWOJ+kbheBXJJoVpkb5z7jgll0pVx+Xsxrx+QHAr0KHc4mNYQrvS+J3jFNZOnSgozbCcGHhmNTFGej12Yrv3gR/9oLxOI5QXp7MTdb57+ZYk54O5HL2LR/GtxvQE+fxOsrNe+82DOkDV7mYvLVj5gFuIuT3jPUf7kp/XBcwym22DdSC3EGOOeEDolkF6gpaMZZa3fEQc//v2c2QgnPrCL4oYHEK+HGh/vDhq4FCCiQuzvl+l/dDR1OiLAqcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7138.eurprd04.prod.outlook.com (2603:10a6:208:19e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 10:24:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 10:24:55 +0000 Message-ID: <68848170-59cb-6546-6e7f-527f65a8c1fe@suse.com> Date: Fri, 10 Mar 2023 11:24:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH v2 10/14] x86: allow for multiple immediates in output_disp() Content-Language: en-US To: Binutils Cc: "H.J. Lu" , "Jiang, Haochen" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7138:EE_ X-MS-Office365-Filtering-Correlation-Id: f3597e09-c2f6-4ac3-b0c1-08db2151b13c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FyboIN7cQZIYY3czwALxgJGijl/UHN6kfwwsL7ZMbdX7p8RyRu3plJSzrQLbZQN+xUAda5W57JTUzVEB/u2ccsdc3B5ROjrqGTcnGcC66SRSTjOP0rGvGw9dln6dBNEC4M5y9RQGqnRZNxIHBk+5v2cGhtLHZXkqUiAWZ509YBn5Y+1pV8ocYRQB2LxTR7cIf53BS3VzADgRO6x1gnYTuPuI2m6VgIcpUYrI5bvhbTrC83DrYz6e1J6lcE6bHsq2acNw6yo0/luNCkVFAJM8brRgbAZlF0VVxSDkamLHAcp7NAWhljT1f1D3PsmWtqEDv+LpcqoYg1vwwyEGtm50VT1giml7dmMq4RCa73QVOMSVPyDJJ4yvDDqmSpzDLeg8rOOSlNNrD4SHoDPHlAU5e4FjA0JqtRA/VANg/CruSbcQNLUaeN+cmMlD6zpG45/9xhRQhdsKydnz9Hp3rIJGyUNM6WYaE3o63Qn2YI85MEPg58G8/L6nMAPZa2Qg9qVUnEYneN3Sun+XMc+e3lyycQ6qhO7d46m/mSWgRgGyFOZ+K1aPv5ZmK6IVfPbL+otNk+hMG4SA/jOd1O3TTTU8jLUkYHwAgvpjIc78utrZjAAVIlQy6u1vTpttM0cMTbjchXQnXSAaIRAJFsKPAtpmW5gKATvMHlRtjz3XoSDoy2YxNGwsE5dkoySwMO+deSpiGKz7nMga1Pd4bRXjtnnizvlLRoPscg5INoKgyseuWfOV0BUYPUBM2jHqJ77gw9Vn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(39860400002)(376002)(136003)(366004)(451199018)(31686004)(83380400001)(36756003)(6512007)(54906003)(478600001)(316002)(38100700002)(8936002)(6486002)(2616005)(41300700001)(6506007)(26005)(186003)(5660300002)(4744005)(8676002)(66476007)(66946007)(66556008)(2906002)(6916009)(4326008)(31696002)(86362001)(14773001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUJHRUw3Wmp6bFppR2dpdGNuTG1pVEtLa0NsdDJDYmY2cnNMS0tFS3VqTVBW?= =?utf-8?B?dGs1R01TZHkxQmtpYlN0MEVkMHM3YWl3bmFIeEFWdHl1SkY3NnV1NzJYZTVa?= =?utf-8?B?a04xNnZuMFVMUjhBRWhkbDVkek5uMDdSbEhjTktRbnFJZDhlNW4rZHptNHNS?= =?utf-8?B?aWN6UWgxN3Q1YkpYM2FyOGIzbmZwR0tHWEVtc1VEWU4vTGIzdTVMam83UTFl?= =?utf-8?B?YUNKYXNYVHV1Uldvdy8vaWdlM1QyV2VQeGdHTktiQXZBcnJBYWlsYm1pNnZ2?= =?utf-8?B?QjRhQWFtaXVNRE92UGxlcDRLS2RiNjNhRzNrSjJ4WXJBazZzRnJoV0craTBZ?= =?utf-8?B?YzRNZmVmUG01Wm5reXgrN0Vmck5CVzgrSDRna1RGVkNranFRSzRzdWhpcHQ3?= =?utf-8?B?Z2VXdGhkYzg2Q2JERllzaksrMHpiQm5JMEZkeS96YTRncWNVeDRuSmhqV2ln?= =?utf-8?B?Q3BaZ2M5OEVNNEcwcHR3SUZZQVhreThoWVB0WEt3dWc2TklLOUJtZjNTRUor?= =?utf-8?B?L09MeTdGZDUrV0czcGhFRkw0TXJ3UzFKV21TQ2ZQTzZsby93R05nb04yM2Fr?= =?utf-8?B?WkVHeUNDSmtYVGgzNFF3aGRaVm5zcitHYkdDUit0dThsYWVRcStFL1hsMHlU?= =?utf-8?B?bVczM3ZncEo0VWQ4WmhXTDBHcDA2eUlaOU9YakgzTzY5NStlV0RtTzd5Wk1Y?= =?utf-8?B?ajlEczl2bkVaWXM0OHYyMkJLUWVGNG84bkVBekVvbGJrWkVQN1hwMjN6b2Z5?= =?utf-8?B?QVN0ZkhlYlpvMXhlM2twNTUyNE9kM0hTS2M2aEVQMjZsN2plSEdyRmdjU1ZH?= =?utf-8?B?UVkrSnJERHBnbzFCSE4xb2tLMEFWK05OcXZ1NjMvcEZ5MG9qdk5aNWZZNnlN?= =?utf-8?B?UzlTMEoxeWs4WXR5anBNMmtTYWs3YUQ5YnNNWFpPTm9ySHZVbmtzMTg1OG1h?= =?utf-8?B?bk82bWZaaFJoVEQ3ZzQ4ZHdpMjlzMmRFNU9vZ2EyVnFMazhmQUttT1JLMlVt?= =?utf-8?B?ekNTWUNzQ1NHQVlacVV4c2ZZZm91N2FOSDU1QlhUS3BvOFVDcUxIbkhuL0p2?= =?utf-8?B?dXlsTUVzZkZRcVNISW42MkJ1NEpPdnZaYWRyT2xpeDQ4dk4zV3N1T3dLNWNC?= =?utf-8?B?QS8xNlFEN2FvNm9jdDNkNGloZ0ZzeVpnd0grbGJFQ05malMzMUFlK2poZmNj?= =?utf-8?B?VHg0cHFRZU56d1RkbjhyaGViTTBpTktpV0lNODgrRWU2TXc1R2RhK3poakxE?= =?utf-8?B?eXdGRW1TMUhsckxZeFI0WWlLWFBIazA2eE1zSC9ONnZDUjk5MVE5VVRjTzJv?= =?utf-8?B?WkNrTk9Fa3VlaUpsUEQ3T0ZYZjU1VWNzenRUNVlTM1RuS2xFaHFDZWk1Ym5j?= =?utf-8?B?WlQrRHp3cjJjR2pMWTZnTDh4RVY1N2RKbU5DYjc1RUx0T1dRRlhUejV4emZE?= =?utf-8?B?d2VGNFRZc1AzLzk4d3lDdHcwZENsNFUvZnd0dTBUZlNCYmpORzlHQ245Znhm?= =?utf-8?B?Z1ZINjc4alRLaXVKRGY4dFROcDZMNG1mY3FKRHlScUsyQ09obitxbGJpU0gy?= =?utf-8?B?RXNlR05GSEI1SEp6ZkoxakQxYkFXZ0dRTnk4M1NwbHcvMU94UzI2ZjhzaGFH?= =?utf-8?B?SDhuUmEvSmcyS2djckNIN0IzcVB5ckxNaW1IV2J1ZDgzZ1lGbFJOSldKd1dG?= =?utf-8?B?ZHFVK3kzR3lZWUhXbjBPMjlLeFIxN2UyRDRNaVVKMXVmcHlLM290Rlg4TUE1?= =?utf-8?B?S0lQTDRITXYzMStHb01mQSs1VFRER0hsSzdCMC8razgwenJEb1hPbU1WWHpM?= =?utf-8?B?ODdIckVKU3hWbVJHeXlKc1dyTTUyc2QzS0RodkFWTWhqWHNPZlR6Vi9hb3FR?= =?utf-8?B?Q0gxR1B2ZlJINmRKdDZFY01aV0hYa2p3ZGxyK0tOa2hNblhBTWEybkZ3Y0R5?= =?utf-8?B?V1hpc1F6eTd5a3psc2FGcVhoTHBrbjVRMXY3S05tTGdVem16ZjBNQ1BXeW80?= =?utf-8?B?ZFFhTmV1ekRmQW1KcmJ3dUM3VmJKM1AxMHJpYkxDZ0Y0TE8vQlI2cnJKbVVZ?= =?utf-8?B?ZEZRSVkxSVQ5SlBsVERMT2xjQ3YyWjUwUTdtWDJ2VmVpM285T3EzT2o2R2RZ?= =?utf-8?Q?K2CYx13trB5swWtGHVMyYrmB5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3597e09-c2f6-4ac3-b0c1-08db2151b13c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 10:24:55.3919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o2nKXxZCOtlK7QWOWSsSYUg+b+arNTp+1OsZKgb2wgPM95S7wnVRWq4AZcs6UsM5k/XfBU9H+qrf+xL89S8riQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7138 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: .insn isn't going to have a constraint of only a single immediate when, in particular, RIP-relative addressing is used. --- Of course this could be folded into the relevant subsequent patch, but I'm wondering in particular whether limiting the new behavior to .insn is actually necessary (if not, this wouldn't be a good fit to merge into that later patch). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -10065,13 +10065,13 @@ output_disp (fragS *insn_start_frag, off if (operand_type_check (i.types[n1], imm)) { /* Only one immediate is allowed for PC - relative address. */ - gas_assert (sz == 0); - sz = imm_size (n1); - i.op[n].disps->X_add_number -= sz; + relative address, except with .insn. */ + gas_assert (sz == 0 || dot_insn ()); + sz += imm_size (n1); } - /* We should find the immediate. */ + /* We should find at least one immediate. */ gas_assert (sz != 0); + i.op[n].disps->X_add_number -= sz; } p = frag_more (size);