public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Chung-Ju Wu <jasonwucj@gmail.com>
To: Nick Clifton <nickc@redhat.com>,
	binutils-patches <binutils@sourceware.org>
Subject: [PATCH] ld: Fix redundant space in ld.texi
Date: Mon, 13 Nov 2023 14:03:34 +0800	[thread overview]
Message-ID: <69164d61-2084-48d1-bb78-d2f8e381954a@gmail.com> (raw)

Hi Nick,

I just noticed that there may be a space typo in the commit
"f1837d9c3f2dc2a5c232f4eae4c4bd5a7f77baf8" for PR30865:
https://sourceware.org/bugzilla/show_bug.cgi?id=30865

The redundant space between "@samp" and "{0 0 22 23}" at line 5608
causes build fail on my environment with following error message:

binutils-gdb/ld/ld.texi:5608: @samp expected braces.
binutils-gdb/ld/ld.texi:5608: Misplaced {.
binutils-gdb/ld/ld.texi:5608: Misplaced }.
binutils-gdb/ld/ld.texi:5608: @code missing close brace.

Here is the patch to fix it.  Is that OK to commit?

---
  ld/ChangeLog | 4 ++++
  ld/ld.texi   | 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index fc2478ec197..316ef47e93b 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+2023-11-13  Chung-Ju Wu  <jasonwucj@gmail.com>
+
+       * ld.texi: Fix redundant space typo.
+
  2023-11-10  Nick Clifton  <nickc@redhat.com>

         * ldlex.h (enum option_values): Add OPTION_ERROR_EXECSTACK,
diff --git a/ld/ld.texi b/ld/ld.texi
index 32c09e24478..5a143b2b518 100644
--- a/ld/ld.texi
+++ b/ld/ld.texi
@@ -5605,7 +5605,7 @@ bytes when used to fill gaps.  Thus @samp{FILL(144)} will fill a
  region with repeats of the pattern @samp{0 0 0 144}.  The value is
  treated as a big-endian number, so for example
  @samp{FILL(22 * 256 + 23)} will fill the region with repeats of the
-pattern @samp {0 0 22 23}.  If the expression results in a value with
+pattern @samp{0 0 22 23}.  If the expression results in a value with
  more than 4 significant bytes only the least 4 bytes of the value will
  be used.

--


Regards,
jasonwucj


             reply	other threads:[~2023-11-13  6:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13  6:03 Chung-Ju Wu [this message]
2023-11-13 15:34 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69164d61-2084-48d1-bb78-d2f8e381954a@gmail.com \
    --to=jasonwucj@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).