From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=l9ew=E4=jacob.remcomp.fr=jacob@sourceware.org>
Received: from smtp.smtpout.orange.fr (smtp-13.smtpout.orange.fr [80.12.242.13])
	by sourceware.org (Postfix) with ESMTPS id 3E774385843A
	for <binutils@sourceware.org>; Tue, 12 Sep 2023 15:40:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E774385843A
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jacob.remcomp.fr
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jacob.remcomp.fr
Received: from smtpclient.apple ([90.22.252.13])
	by smtp.orange.fr with ESMTPS
	id g5VXqqBk6LPhkg5VXqowDh; Tue, 12 Sep 2023 17:40:56 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr;
	s=t20230301; t=1694533256;
	bh=5LJa2FGBKEqrqE8Lkqs17mPYU7rWvfkFTbwIXeKJiNA=;
	h=From:Subject:Date:To;
	b=IFMxWORgxSo2XaQWU9R/D9vN/m4MDheLitL2eCtwiZvrRSDut9BtVFGYjD9QX2+B2
	 j1KiIdwF9mZP+bZco5MTTECx3a9HgsA97RjoLTgume7c/SdD/uAozBIeikcREHObXz
	 NJk5XFZy/iTI1f2Fx52z0Wgzno8IOrQAvDe++A4u8MsX5IzIfThwqDSY/H6dnOyZb5
	 4T2FlSsjYLtlmkSY+fpuBbaGm9Jx0RKO6cSXyBgMkpB+xSzAhAt8M+VbSun0gecaLO
	 YABZfrxjflJ5cIF7mL3rfb9cU4Z4AAny2Ek0dXSpki3jszPmltvD0ecPpS0W+ipFr3
	 CRoL3+pdLiRRw==
X-ME-Helo: smtpclient.apple
X-ME-Date: Tue, 12 Sep 2023 17:40:56 +0200
X-ME-IP: 90.22.252.13
From: jacob navia <jacob@jacob.remcomp.fr>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_ACB3F7F4-8D4D-416C-AF0E-C870705E1BCB"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Missing NULL check
Message-Id: <69AA9E49-F26A-4DAC-B120-70940C3A59B1@jacob.remcomp.fr>
Date: Tue, 12 Sep 2023 17:40:45 +0200
To: binutils@sourceware.org
X-Mailer: Apple Mail (2.3731.700.6)
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>


--Apple-Mail=_ACB3F7F4-8D4D-416C-AF0E-C870705E1BCB
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

This is very similar to the last one:
FILE:  elf-attrs.c line 232
FUNCTION: elf_new_obj_attr
/* Allocate/find an object attribute.  */
static obj_attribute *
elf_new_obj_attr (bfd *abfd, int vendor, unsigned int tag)
{
  obj_attribute *attr;
  obj_attribute_list *list;
  obj_attribute_list *p;
  obj_attribute_list **lastp;


  if (tag < NUM_KNOWN_OBJ_ATTRIBUTES)
    {
      /* Known tags are preallocated.  */
      attr = &elf_known_obj_attributes (abfd)[vendor][tag];
    }
  else
    {
      /* Create a new tag.  */
      list = (obj_attribute_list *)
	bfd_alloc (abfd, sizeof (obj_attribute_list));
      memset (list, 0, sizeof (obj_attribute_list));
      list->tag = tag;
      /* Keep the tag list in order.  */
      lastp = &elf_other_obj_attributes (abfd)[vendor];
      for (p = *lastp; p; p = p->next)
	{
	  if (tag < p->tag)
	    break;
	  lastp = &p->next;
	}
      list->next = *lastp;
      *lastp = list;
      attr = &list->attr;
    }

  return attr;
}

bfd_alloc can return NULL. This is not checked
How to fix:
Add
if (list == NULL) return NULL;



--Apple-Mail=_ACB3F7F4-8D4D-416C-AF0E-C870705E1BCB--