From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 027EC3861861 for ; Thu, 15 Feb 2024 10:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 027EC3861861 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 027EC3861861 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707993174; cv=none; b=VPwiAoympbqsrrWv2OCOuP8znX+34P+f2+hod4U37uh9NuRa/KAQz4AY4Q9ZmUI9hZzZNFdjegigRnBhlsGC1L80HCrvjurnCPKxM7JSioJdXu7XeJCjvLFWB9UmHha/N+9JmqxshQ/cZ9NcRm/EqPGu9jMhBJTogPkG3OxUq7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707993174; c=relaxed/simple; bh=9+Sh5jDZvaKOiZxCD3jC+b1DS4OxCGcSeiFpTLXk0eA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vmNXx8Js8+q20ZthEJxRLr9ZvnIgZpOyx4frm/do6zCKcnAeHg9JRcK/YZCj/D/qeATwdCLcRIsXl9iw0ej+qGl7gpvkWSAW1Kfgq3fTL1NygIexkYXkzFu1T/W+jqyOqG7+ujmnwMY7Bdjei4r6ypDLSXkXRs/X0/4csndLCRo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707993171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rcjpiUk/Pcsy7oCR+vnEj3EELabAfHKhY98lXD+X5Wc=; b=fW2HbCsGe7QYDAYen5t/1gmYuH1pM+H381eXfsMc4+PkbZ6UHibilfYS7D4jr0OIE+wKmi KfjZJ75DhcPOK2amTVf4xaViyvNQsWckmXMF7aRO8eCf9QGt8hzSYMxWVGof+DpSQN+8sB ca9A71LInwd7f0W00LiSDsodd1LI07I= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-5y7s1vhDMDOXbBtDjEUjxw-1; Thu, 15 Feb 2024 05:32:50 -0500 X-MC-Unique: 5y7s1vhDMDOXbBtDjEUjxw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6800aa45af1so9642896d6.3 for ; Thu, 15 Feb 2024 02:32:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707993168; x=1708597968; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rcjpiUk/Pcsy7oCR+vnEj3EELabAfHKhY98lXD+X5Wc=; b=b3i+23FUzDPIY6LuSzo8jY6rd6qBdSOFdgB31A/7u8bQrXuxxxRo75FYkYBc4Y9TGg m17CshFCsLrFKmD+Q5U/OLK20ivIH+jKUOAsk+4b7WfDLNOh8uMcMvYhC6hCSbRx/Qr9 XF3nuf563IAaASfTG2i99mHKTh5B5ELUNfv0z12iOcYllPQGoYK8Et42nxmscKwYOMyJ W70Vgmol+VNiYIcQHUq9wGwiPjGDzw2LLPT5ZuCTMd5i1Xpi4iYPhQ5yPeZUyG5ZfDvu ccq2PFod3BBBA8Yvwo+T3FUl5jfoaJwpt+kLWjlnFepikGxXHWX/cOwBmKjS3iqqIHFs aSIg== X-Gm-Message-State: AOJu0YyYUa9/Ps4ZFY9sLbt5FSQCiaxb06/sM3YpaQ34Qz9jB8wyE/W1 mFN5h9z1HAi3Ct2aJ0eomzFXswylzkqehrouYduQXtfLP5lZFuFTkMhLe4TLLsSDJeioljPQhOA TAVkIJYujgCUuZP1gXIWj+EFBlNraExNANWtGVFDk1OpDydgIgO9wWhcd92ZtoGo= X-Received: by 2002:a0c:ae91:0:b0:68c:6f8c:6741 with SMTP id j17-20020a0cae91000000b0068c6f8c6741mr1241918qvd.11.1707993168275; Thu, 15 Feb 2024 02:32:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHUn3ZYKMPNnm6B2qo4Bn59yyJNSV9HehqSUJ65IyAlA+DKwlGOvRKWqOH6JKc2SYDjXrwyg== X-Received: by 2002:a0c:ae91:0:b0:68c:6f8c:6741 with SMTP id j17-20020a0cae91000000b0068c6f8c6741mr1241907qvd.11.1707993167878; Thu, 15 Feb 2024 02:32:47 -0800 (PST) Received: from [192.168.1.5] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id lv4-20020a056214578400b0068c6d56d4f7sm528278qvb.92.2024.02.15.02.32.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:32:47 -0800 (PST) Message-ID: <69cca961-10ed-4c44-ae0a-8b0849fa4ec9@redhat.com> Date: Thu, 15 Feb 2024 10:32:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 To: Will Hawkins Cc: binutils@sourceware.org References: <20240212174209.620310-1-hawkinsw@obs.cr> <20240212174209.620310-2-hawkinsw@obs.cr> <82116e8c-390b-4389-8d04-744839785f2c@redhat.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Will, >> Just to be clear: your sign off here does mean that you agree to the >> Developer Certificate of Origin (v1.1) right ? [I am being paranoid...:-] >> > > Yes, 100%! I appreciate you checking but I specifically included the > sign off as my agreement. If there is a better way to positively > signal that intention, please let me know! No, that is the right way. I was only checking, because as a new contributor (to the GNU Binutils at least) I wanted to be certain that you were aware of the significance of the sign-off. >> This frag struck me as strange since it appears that the first change is to >> replace a line with itself. Looking a bit closer I saw that you are removing >> some unnecessary spaces at the end of the line. Which is good and not a >> problem. It just looked odd when I was reviewing the patch. > > I was hesitant to include this piece in the PR because I know that > whitespace patches are always a touchy subject Really ? Personally I have no problem with whitespace cleanup patches. My only real worry is when they appear as part of a patch that is doing something else. Generally speaking it is always best to keep patches as simple as possible, so a patch that changes code, cleans up whitespace and corrects spelling mistakes all in one is going to be frowned upon (by me at least) whereas as three separate patches would be welcome. > Here is my offer (hinted at above): There are several parts of this > particular file that appear out of the ordinary: > > 1. Inconsistent tab/space usage > 2. The presence of magic values > 3. Spaces at the end of lines > > And so on. > > If I were to take a pass at "cleaning up" the code in this file, would > you be interested in having a PR? Yes. Sorry - I was confused when I first read this as "PR" to me normally means "Problem Report", as in a bug filed in the binutils bugzilla system. These are assigned PR numbers and can often be seen referred to in comments in the code and the changelogs. I assume however that you mean "Pull Request" here, which makes sense in context, except that the binutils project being old and stuffy we normally go by patch submissions rather than pull requests... One other thing I should also mention. Whenever you do submit a patch it always helps if you mention how it was tested. Noting that it was tested with a binutils build configured for bpf-elf and that there were no regressions in the gas, binutils or ld testsuites is reassuring and helps to make the job of reviewing the patch easier. This applies even to code cleanup patches, where of course no test regressions are expected, but you never know... > As I said, I really appreciate your > openness to my contribution and I love working with FOSS. In other > words, I would really enjoy contributing. That said, I don't want to > step in and intrude on someone else's territory. Just let me know! Oh no, please do step in. No-one has a "its all mine" territory. We do have contributors who have volunteered to act as maintainers for certain architectures and/or parts of the binutils, and they will often be the ones who review patch submissions in their areas. But everyone is welcome to submit patches to any and all parts of the binutils. Cheers Nick