From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11227 invoked by alias); 20 May 2014 22:49:04 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 11165 invoked by uid 89); 20 May 2014 22:49:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 May 2014 22:49:02 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id A276A90170D75; Tue, 20 May 2014 23:48:54 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Tue, 20 May 2014 23:48:58 +0100 Received: from LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9]) by LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9%17]) with mapi id 14.03.0174.001; Tue, 20 May 2014 23:48:58 +0100 From: Matthew Fortune To: Mike Stump , Alan Modra CC: Andrew Pinski , binutils , Richard Sandiford Subject: RE: as error output not -j64 safe Date: Tue, 20 May 2014 22:49:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B02353539325@LEMAIL01.le.imgtec.org> References: <819223B1-7BDF-46C0-80CE-EF49878BA3C8@comcast.net> <36FD025D-0FE1-4248-A154-E28F998F5B73@comcast.net> <20140516085119.GW5162@bubble.grove.modra.org> <6D39441BF12EF246A7ABCE6654B02353539192@LEMAIL01.le.imgtec.org> In-Reply-To: <6D39441BF12EF246A7ABCE6654B02353539192@LEMAIL01.le.imgtec.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00190.txt.bz2 > This patch has broken a lot of expected output in the gas testsuite. > Are individual ports expected to deal with the fallout or has this been > done already but awaiting commit? MIPS has 133 failures with this patch > applied. I didn't check the exact cause earlier. It is just extra whitespace introduced in the refactoring. Committed as obvious, (hoping that is the right way to treat this sort of fix). Regards, Matthew * messages.c (as_warn_internal): Remove extra whitespace from warning messages. --- gas/ChangeLog | 5 +++++ gas/messages.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 130b287..51974b5 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,10 @@ 2014-05-20 Matthew Fortune =20 + * messages.c (as_warn_internal): Remove extra whitespace from + warning messages. + +2014-05-20 Matthew Fortune + * config/tc-mips.c (FP64_ASES): Add ASE_MSA. (mips_after_parse_args): Do not select ASE_MSA without -mfp64. =20 diff --git a/gas/messages.c b/gas/messages.c index 05c7442..d592b36 100644 --- a/gas/messages.c +++ b/gas/messages.c @@ -151,12 +151,12 @@ as_warn_internal (char *file, unsigned int line, char= *buffer) if (file) { if (line !=3D 0) - fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning: "), buffer); + fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning:"), buffer); else - fprintf (stderr, "%s: %s %s\n", file, _("Warning: "), buffer); + fprintf (stderr, "%s: %s %s\n", file, _("Warning:"), buffer); } else - fprintf (stderr, "%s %s\n", _("Warning: "), buffer); + fprintf (stderr, "%s %s\n", _("Warning:"), buffer); #ifndef NO_LISTING listing_warning (buffer); #endif --=20 1.7.1 > > -----Original Message----- > > From: binutils-owner@sourceware.org [mailto:binutils- > owner@sourceware.org] > > On Behalf Of Mike Stump > > Sent: 20 May 2014 21:28 > > To: Alan Modra > > Cc: Andrew Pinski; binutils > > Subject: Re: as error output not -j64 safe > > > > On May 16, 2014, at 1:51 AM, Alan Modra wrote: > > > OK. > > > > Thanks. I noticed you tricksy people switched to git, welcome to 2005. > > > > > Please also fix as_warn_internal similarly to the above. > > > > Done. > > > > > There are quite a few more cases of the same problem in this file, if > you > > > care to look.. > > > > Gosh, I want to solve these with fmemopen, but, that is not as portable > as > > the existing code... In any event, I'm not set up to do as much testing > as > > I'd like for move invasive changes... > > > > Here is what I checked in: > > > > 2014-05-20 Mike Stump > > > > * messages.c (as_warn_internal): Ensure we don't interleave output > > within a single line when make -j is used. > > (as_bad_internal): Likewise.