public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* New NOCROSSREFS_TO tests
@ 2016-04-21  3:16 Alan Modra
  2016-04-21  6:05 ` Matthew Fortune
  0 siblings, 1 reply; 2+ messages in thread
From: Alan Modra @ 2016-04-21  3:16 UTC (permalink / raw)
  To: binutils

Fixes failures on hppa-linux and alpha-linux due to not merging
.data.* and .sdata into .data.  cross3.t modified too since it is the
template for the NOCROSSREFS_TO scripts.

	* testsuite/ld-scripts/cross3.t: Add commonly used data
	and text section names to output section statements.
	* testsuite/ld-scripts/cross4.t: Likewise.
	* testsuite/ld-scripts/cross5.t: Likewise.
	* testsuite/ld-scripts/cross6.t: Likewise.
	* testsuite/ld-scripts/cross7.t: Likewise.

diff --git a/ld/testsuite/ld-scripts/cross3.t b/ld/testsuite/ld-scripts/cross3.t
index 5e32bb2..e48b947 100644
--- a/ld/testsuite/ld-scripts/cross3.t
+++ b/ld/testsuite/ld-scripts/cross3.t
@@ -2,9 +2,9 @@ NOCROSSREFS(.nocrossrefs .text)
 
 SECTIONS
 {
-  .text : { *(.text) }
+  .text : { *(.text) *(.text.*) }
   .nocrossrefs : { *(.nocrossrefs) }
-  .data : { *(.data) *(.opd) }
+  .data : { *(.data) *(.data.*) *(.sdata) *(.opd) }
   .bss : { *(.bss) *(COMMON) }
   /DISCARD/ : { *(*) }
 }
diff --git a/ld/testsuite/ld-scripts/cross4.t b/ld/testsuite/ld-scripts/cross4.t
index 7f91b81..4e5d28a 100644
--- a/ld/testsuite/ld-scripts/cross4.t
+++ b/ld/testsuite/ld-scripts/cross4.t
@@ -2,9 +2,9 @@ NOCROSSREFS_TO(.data .nocrossrefs)
 
 SECTIONS
 {
-  .text : { *(.text) }
+  .text : { *(.text) *(.text.*) }
   .nocrossrefs : { *(.nocrossrefs) }
-  .data : { *(.data) *(.opd) }
+  .data : { *(.data) *(.data.*) *(.sdata) *(.opd) }
   .bss : { *(.bss) *(COMMON) }
   /DISCARD/ : { *(*) }
 }
diff --git a/ld/testsuite/ld-scripts/cross5.t b/ld/testsuite/ld-scripts/cross5.t
index 43657f1..a581b92 100644
--- a/ld/testsuite/ld-scripts/cross5.t
+++ b/ld/testsuite/ld-scripts/cross5.t
@@ -2,9 +2,9 @@ NOCROSSREFS_TO(.nocrossrefs .data)
 
 SECTIONS
 {
-  .text : { *(.text) }
+  .text : { *(.text) *(.text.*) }
   .nocrossrefs : { *(.nocrossrefs) }
-  .data : { *(.data) *(.opd) }
+  .data : { *(.data) *(.data.*) *(.sdata) *(.opd) }
   .bss : { *(.bss) *(COMMON) }
   /DISCARD/ : { *(*) }
 }
diff --git a/ld/testsuite/ld-scripts/cross6.t b/ld/testsuite/ld-scripts/cross6.t
index 4664221..0f23ca0 100644
--- a/ld/testsuite/ld-scripts/cross6.t
+++ b/ld/testsuite/ld-scripts/cross6.t
@@ -2,8 +2,8 @@ NOCROSSREFS_TO(.text .data)
 
 SECTIONS
 {
-  .text : { *(.text) }
-  .data : { *(.data) *(.opd) }
+  .text : { *(.text) *(.text.*) }
+  .data : { *(.data) *(.data.*) *(.sdata) *(.opd) }
   .bss : { *(.bss) *(COMMON) }
   /DISCARD/ : { *(*) }
 }
diff --git a/ld/testsuite/ld-scripts/cross7.t b/ld/testsuite/ld-scripts/cross7.t
index dad2103..29173fc 100644
--- a/ld/testsuite/ld-scripts/cross7.t
+++ b/ld/testsuite/ld-scripts/cross7.t
@@ -2,8 +2,8 @@ NOCROSSREFS_TO(.data .text)
 
 SECTIONS
 {
-  .text : { *(.text) }
-  .data : { *(.data) *(.opd) }
+  .text : { *(.text) *(.text.*) }
+  .data : { *(.data) *(.data.*) *(.sdata) *(.opd) }
   .bss : { *(.bss) *(COMMON) }
   /DISCARD/ : { *(*) }
 }

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: New NOCROSSREFS_TO tests
  2016-04-21  3:16 New NOCROSSREFS_TO tests Alan Modra
@ 2016-04-21  6:05 ` Matthew Fortune
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Fortune @ 2016-04-21  6:05 UTC (permalink / raw)
  To: Alan Modra, binutils

Alan Modra <amodra@gmail.com> writes:
> Fixes failures on hppa-linux and alpha-linux due to not merging
> .data.* and .sdata into .data.  cross3.t modified too since it is the
> template for the NOCROSSREFS_TO scripts.

Thanks Alan. I had a concern about this and forgot to raise it. The
tests that are expected to produce no warnings are dependent on the
correct sections being merged which could depend on compiler options.
It will be all too easy to spuriously pass but hopefully the tests
that check for failure will pick up any non-standard section uses.

Matthew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-21  6:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21  3:16 New NOCROSSREFS_TO tests Alan Modra
2016-04-21  6:05 ` Matthew Fortune

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).