From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2054.outbound.protection.outlook.com [40.107.105.54]) by sourceware.org (Postfix) with ESMTPS id 6CBCD38582B0 for ; Thu, 24 Nov 2022 10:19:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CBCD38582B0 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DD7W89efzCrw30pR1A6teVx7JnqtGV/QR2/F6gPMY/IXyoBSGO7NHg9OahJ26+U5GqqWF03nsWLJIMrpOyqVXUqeQTTgZQr4kMU8ZODe75rQMru/xuGNREQ3SKO+euSguidf2abH+dp1H5dXSlhkCCLToYciBNmXYNoFEl/OKY53W7ADgchO67vJlwKH3BPA0EjjmZ1kQQB24FZU3G4s9tC6XStKg1O1dRLwrS7/Ql6YxKcLYaxuerbBtlbbAY5bu80RypL+I/ZSn28O5dFID7KZ1WwuizAITYXT1ONOfmkrZeZwOqr+B+BOSKrXJJCUVEOPqjPITLD9zADV3VS+5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pAMbEAXv1p6ZeGtFwi8WoZrtt4AM+9c6UyxbL+e+cnc=; b=UPfMtz6Q6OsPTzg3RGqvv+hXe5AFBt5X8HP40v65JJKdbVMLZKGFmeE3u6y1Zfjdv1jeO0WPLjIMO0oAphQyHP7bShZajC3hW+HLRiP0PwfZ7pKscZpaJM49jm+hQzzIFrXBiDMjCenoOxzPrharBF6uWqXLkXZYQKNZn3NLCFvNn8obgeHSNPK8Q4vzraR3SAbSkMMCK457gyjCSr17pV2wI47TcT0Elf2AQVUycfJ7nhcmEX9iYbS4+ovKEv2XWgbZV11v6ENWTlDjVmIPpPxs8UWT0ecyfEEszWclYiMqRda8FDBkZ7Q/VyoUMLrDOeuCiuj8thQ8HOpXufNv3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pAMbEAXv1p6ZeGtFwi8WoZrtt4AM+9c6UyxbL+e+cnc=; b=ixJTqabdR/LWfL9UxQAt8jIGTqSey8Gq1dojx9utWIKDvIUmxYMFbQBLxUrTcS+qcFSC3IjtI5zFnVjkGOaIYg3SAM2ciPw/NEpnk7i015S7JyCW9bKbA06Ec3mTDeOyGUCHOWYITx/9rcphLiLhZlRKlRyJZ+HWC0s9s7ibIFu32U3LTXQPj/ypcCs/+/a32ZCrSppJKokAd0dDEPXxw1f3p4nzGLeXIUJfIY6Ty5QXuyyam0+uOrZu5ZIpgAo+38QUswrkehVNk81i9NAMItIReMwsOag5nbRD46kDhDOkIUw73JgUY2719TrTpG4gb7geLFs7L0PrG7JNMFqPhA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7533.eurprd04.prod.outlook.com (2603:10a6:102:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 10:19:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 10:19:06 +0000 Message-ID: <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> Date: Thu, 24 Nov 2022 11:19:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" References: <20221122181927.251937-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20221122181927.251937-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b63d718-499c-4e8f-49d5-08dace0551b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6mWC0wHPqKeE9oaS87h5chsNN9DUErmu0QtXxI3Jx+2bwMUllnWavqgkCedhsL5l44HZARhYyNYra2vGHg2jE6FrwoPEqjZ+E9n8Qx40RLDjwBN8Skta/KMjtGo/eAFJN+DveOLMpJZkcqTCJgJPvIhDiBJ5nRvGwxEyf2SZKfpbhUAMYFC+gQU39WcgCxK7ieDYIkzqaqUHMBhl9Da/pIJJbzTGi1/mq967ZJMPtTDheLg0mgwZbkXJAIUn7O9+PgdFXhYywFUp8NTq2rjtOJZTdUdp6BLapadB1/XQNzU6hwzP3F5iagEOyw+bXwfHBud3yPUpvWUifKHj/6PUVdYBPIxb9jksIZq3Kq6JNrt0W7K4fUGKLEUOxg7vtoA8HscLEEXE1vMOlFSEz/45TPo0to5kvpgQn+w4D9/Cjhj23/u/A9UCnwKfJ23wVD9o+UIk+C6it9A5x+hZAdAIpWQ9pwjkVlivMQM4whgDcAkhUxLGhYfzZZtIdM/jK7xaaYjSlFCvc5LyD1LUoMwNMu9/bYdOHwMKAr063RXEq2JgJmZxuDInasy3rj+wG9Vji9LP1yDPFceD5VbLXZwkHgiqYKmbAziTOrjT+E9nz5U0CP6po5wnf0OI3bbFWC6UyYzXCVZk/1oNZS/LjmDSHy1TlRl8rF+w8F7MUqdkcsvjBW/A4/LqhzBWRNSm0EHMXxqmhbAyjVj11GUHVNE0pZzIq5CPJvDYFg4UY2PRnk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(366004)(346002)(396003)(451199015)(8936002)(5660300002)(2906002)(83380400001)(66946007)(66556008)(53546011)(66476007)(26005)(86362001)(316002)(6916009)(6512007)(41300700001)(2616005)(31696002)(186003)(6506007)(8676002)(4326008)(36756003)(38100700002)(6486002)(478600001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWRqa2ZXNjl4SkYyNTZURXFFMmRPbktTUjZkRXdxZzQxMWlCaFA0L213V2E5?= =?utf-8?B?K2Y2UzRicXJTVjh1NHBtU1R0Z3RGeTR3M3gyOGx2SHp3MS9BUTQrTGJZV0RD?= =?utf-8?B?OTN5ZHFjYVJGMjVTaVEvaUROOHlOcFNMZzFSUERjcGRhRnZlOVcxd3pQY0NG?= =?utf-8?B?dVF4TjhZNjQ0OTBZUXB0NmpHK3dYYlpORDJ6aVRlbzBzVmJkMmZzWWZobTdN?= =?utf-8?B?ODFuV2dZWEFoT1ZBcEFEbTVZcDFMbjJyVU1rRVJkb29vaDdBOERsSXcvaEdw?= =?utf-8?B?V2dFQ2k5VSswc2hNMVVHSkMzM3FvazlwMWxGUkoxV3JEc2dxS3Bsb1lrRTlz?= =?utf-8?B?Q2lkNW5hNk92N04xTHdjMytvSlM0bmpsTm45Znd6dUdHQUVsQUZ0RHJPVEVa?= =?utf-8?B?ZERNSDZVUUgyVVJVajU3d2hOT0V5ekp2VThIS3BiSFFiY0huNC9kUlhPbWlp?= =?utf-8?B?VU9DU2ttK3RmbTN1K2JKWGJuQ3NIcEQ3WFJXdVNjUzAvMlA4VFZWTE9PWDl5?= =?utf-8?B?djFMbUY3dW5UeHF4Ukx2dVVwNzM0RkllbHc0aHRCWlNHVTF0bnV1aWl4NlRt?= =?utf-8?B?Z05pYmVHS3VQUXNaOVJ0dU1pQll6UWJJRmZpdWF2TjJxaVdteW8vUElVZW1O?= =?utf-8?B?QUU4SkMvOWZLWlpyZFdVRlpiU01EcjdmbHYwUFZRRGhTeWdwR3VIUnA1UG5F?= =?utf-8?B?YUVoOVBKdXdkZ0p6cGR1WDNBMmt4UGdQN2lyZ05BQVBEeHhycTV2NlM2WkxG?= =?utf-8?B?SVVkSGVLV2hrajQ4eldZV2dGZ2FxRC8wUmcxZjBWcSticjduTzFnbjA1ZWpF?= =?utf-8?B?ZXUwYXR6bEFKTnIyWktPR0ZPcDFFSFo1U1c0K0RCZTBGNEl2eVVNQWZzeC9w?= =?utf-8?B?NS9BUUhBTHh4TzFIdVozMkVCRHI1YkhBc3ZFRjc4SFEwdjRteTVFcXVhakVU?= =?utf-8?B?UXAzM3p0eDR1UEltSWRzUDM5Y2dDOUZmbW9sVzJ4KzlUUHNEd1Q1UXdqellF?= =?utf-8?B?Y0VBZmw3dU9DUHJibWZuZGgwa1RGekVTL0hJVWRxWHhzQWpJRXlTY3lVZ2Vu?= =?utf-8?B?eUtHdWROckNMdzZlK1BNTTIwR2FSQnU4SnAzUFl5Qml0Y3kwQmMwWTNOK1hS?= =?utf-8?B?NURGZGlvMGhaNGxiTksrUDl6SzN6a0xGME5OVnFvY2JRUGd3Um44K3RKcFZ6?= =?utf-8?B?ZWp6TVNjRzA5K1I5MG5EaXFuTHVuOWtLTEsrY2ovdDliNVhabDdRY0dUQmFq?= =?utf-8?B?NXcreG5qamtUc1pXcVlET0RRR3JNNnJ1cW9TSnJOTnFwYm1Yb2tqd3JiMFlS?= =?utf-8?B?ZnNPK1k0RG9RNkRWTnN3Q1JrY0xSSnBQVEtIVXV4eHNVdkJVQUd5T1RVSGtn?= =?utf-8?B?Ym5pQVBCWGg2RmJyTlNOSHJvc3lWVFRDSHNSU3RtSGQ2UUtaaHA2c2lDdWNG?= =?utf-8?B?WDMyZ3QzODNNYTlmYXRXTHBQYXozaDBRTkRkUEt5b2FlcWg5MzA4MlZJSUxm?= =?utf-8?B?cGhNUk4yTXdXMTNOeUl2dkd2azJxVUFjdVlKaVlUV200SE1FOGUvclZ6YmxW?= =?utf-8?B?bXlaYjhwSldSeVFuVys0bllDeHFiV1N5cENsSzVaWVU2dDFXVUVMMVZQVnBB?= =?utf-8?B?L1Q2L3VoTTROQlNKSHBNcHRMRUpkbC9GKzU4Q2VTTHZOWVZkZ1QydU1ZREpN?= =?utf-8?B?TlM1Z1RzbG5aS3l6K1kxMmU5ekhMNnNBQVNuNFNhZUJDYkkvRnh5YTdGbkt3?= =?utf-8?B?T1luWHpIWGxQWDVuMW1HdlRSN3ZXekpsMkZEWDgzR1hVcUliNDkrTGtwbkNx?= =?utf-8?B?Smh6UHpOTkJ0RDZYNDRVQjhsYXg4eHlIbmVBSkJwamk0cy83eHh4cEt2KzN2?= =?utf-8?B?aGxEQVp5Q2k0eUdRZ3I0NGQ3R3JGU0VlMExvU0hscnB5ZVdzVlo0Qjk2TGNl?= =?utf-8?B?VTZiU1laVWFiYlRzNGRiR1Vyb2dTM3FtcG92UlZMbDJnenRucEwyaFdqdjZU?= =?utf-8?B?cWc2aDdWd2tJL0t0S241QjFwU20xeER3bHd1V01jVlhIaERTR1BaaXRxSTNm?= =?utf-8?B?N2xEcXBIZHNab1JXNkQrczVHNTdhMnRqWW55OXFzdkUwVmEvQWlWbWpNMTNG?= =?utf-8?Q?PKCimiFrz1OvoIW4q95AVoD2z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b63d718-499c-4e8f-49d5-08dace0551b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 10:19:06.8277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mmxBQOoGe1rSl+uQsSJgUcMlUXIOjlyocJ1GWjQC6morzTGTIr6BB1O7+0ySJVUAGU+DmntdHe4uIlCWFzKsDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7533 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.11.2022 19:19, H.J. Lu wrote: > --- a/gas/Makefile.am > +++ b/gas/Makefile.am > @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh > $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ > | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ > > +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ > + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ > + $(srcdir)/../opcodes/i386-reg.tbl \ > + $(srcdir)/../opcodes/i386-opc.h > + cd ../opcodes; make gen-i386-tbl I've made a patch to gas/Makefile.am as you have requested in reply to my series. I will want to put that through some more testing, so I will submit a v3 of that only a little later (and of course only unless you submit a v2 of your patch earlier that I would also end up being okay with). In the course of doing so I noticed a few more issues with your change: For one I don't think you can put @MAINT@ on a continued line, as the line continuation might then be hidden when @MAINT@ expands to #. The list of dependencies wants expressing via a variable, which would then be used immediately after @MAINT@ without any line continuation following. And then your rule / dependency won't be enough on a "maintainer-clean" tree, i.e. when the generated headers aren't there at all, and when config/.deps/tc-i386.Po is still empty. In that case nothing would trigger their generation; an explicit dependency of config/tc-i386.o on these headers needs adding here. Finally you're missing a dependency of the generated headers on i386-gen.c. Jan