From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140075.outbound.protection.outlook.com [40.107.14.75]) by sourceware.org (Postfix) with ESMTPS id EB1523857B8E for ; Mon, 21 Nov 2022 07:32:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB1523857B8E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MG675B6yb8TqLByMAEq3vAAo+6eqKTNyR2WZGRz6Q3PEeJCG8DMffryO1p0u4pr97nZRJbXfwCauMPZbT2Vu6pHa71QufhslWa1QdycoCEQV/zkKam8v2ClIJmDMOy/0kMlk2ukkwcmv7wODRcZBa+Rj2BQP7bOf6G6PYhVGGxmLiOP4DW2Vg0s/WJXwhbKbg18SbZB6wLpVa+46RDMKenzbGN1YfywpnaSquHdmfMmK8+v8Z4BAmYOEyMHUwjAudzPxJZhK+Y+wHJXsLysv8C0dnbbQLORzUDGqjqm85hcodTj2Wc4qE4vB+A0iCX7IzIvp7dZWEBlWbFaD0iyNIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWVv0I4YagdvSclHOGGzX8b/u1Jy1UfbtV2EyOvYSo8=; b=dywoNWbgLG6nmribyka1OFMk9AeY+qLjBZL/BqdkkaG6j6WWDYtyZ5J+WGvbsy1yFLEqzrk65YTvCqL//BFJz5u5dE4xEkWQoHXugRa/gel9VDXFzMNF/onFeSmKt/U6rYRzoSaGr6uMzKUqOR1G+ecEGIPes6RhXToP4IHc8FcfdBVWAc7hAeLfLtlnMd1+htZBOf6UsQuFQTN9aMNXjsiSg6Rs/1ISKX/abImnNGKiDQgrPHNJN92iHlwUQxEV2j3eazsTqVhcp+OS5rvOqy4yQGv2SqZGHlnIPo8OGcOnilwbHpOmIN2PEs2ckxutu+Dd2YCsMocobzYuujoWJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWVv0I4YagdvSclHOGGzX8b/u1Jy1UfbtV2EyOvYSo8=; b=rAfoItlq/T3zKpTh08srjZwy65oSdQQq5QSwEJ8KxxB5pmMezxhP4oC0gvqDYUkFFk1JiMarkZhSsoUd29r5zTqG0C7Q4KoxiyQWFU5tqITI2ZqqYP84sQ6J6fn7THDqjHqeH0KDtsT3/yGF6OopvXc0QpAP2yOkJJyWmOtUd8MYncp/9tqRUWaXoZpgnnAGCqulhIx609CFGchEklaLxLcnnWCstCf51uErLJNFIFvSKkW10YQOziLzT9sVcvYTjCfRxSqPQi/tpNT789B6BzTwS68AVswv4uU5kHFjefVBETBuCOFRu7+ykHyHDs+/BzV/GlHk49im9MbKdeDa1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7495.eurprd04.prod.outlook.com (2603:10a6:20b:295::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 07:32:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 07:32:29 +0000 Message-ID: <6a9c59f1-ff0b-45b9-c4cc-d795b93a5c9f@suse.com> Date: Mon, 21 Nov 2022 08:32:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] RISC-V: Make .insn tests stricter Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt References: <2e469b6dd7d8b93ffd3cac333dd58d172a8f28d6.1668841829.git.research_trasio@irq.a4lg.com> From: Jan Beulich In-Reply-To: <2e469b6dd7d8b93ffd3cac333dd58d172a8f28d6.1668841829.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7495:EE_ X-MS-Office365-Filtering-Correlation-Id: ae98e304-e8e6-471a-f56b-08dacb928b75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v0FwbAEemLz8w1DgDazOciVthOt+QiEqdMC6dBE108rBMsxisSRPUz+UEFFku7JcXE1rcc84i3+0B2PRLFzCeI4PvLi6Xt6KB0LKhB/ObpRmImgx75uNPT5Wg2M7jj1WymgGbViX4zdbMcEKvaC+9sGCXwZrAIVaAlC+0qCWnH6vALSMx+4ii6cgTpMFGpVt5NGNBZWE7vlI/p+UMZ7zTWKgBAMflI+4NdbVnY+gr8lal4c3u+V1Po2QT9Bhbm6n9XmnLcZhF8ohuFyp03DPhDmlnuHBMlRaraNUPGM0l+n+DL9sayqB+q4D5HDKiuRJPMSPkAb9AFL4zGN6+6SzrOMpnTwR2mvo723QQQtu3b8YcwloJHzdWm0WfxfJxw9s2K3COLyzgV2qRsEP5uxXf94mdSgoe61K2ellj8nBN8/exOfbhWY3c9EASmSQe3gDyJMDbkctLtzcRmQYB9FzcQylfRyW1U4AuAnh3H2JxhUgOEOvgIoDyU3JLmKeo/w49kVdOjjETtmuaJ6lyr2zvzunsNa/+P9czWnqx7deBQpp2fUBKLuTvl3dgZLEXW6iJ2UoTDKk4pbIaCaSgDr2nLTACUTstK56BzjFURsn/4SJzyjzWIHOxqgPSEf4IPrmhKW4auyUIOJMz56bB+x+IhVEaaNHQtnCSXThKsrNj6wBu+oKhSuBeYW9A5NjLocqjlFFN1ZHnbIJJzh580EqUmIUtdP5Yp/hFyH1sKCD7ih7JboKKWq2l3NGRidWJZTWinELfmOYwnBtWyHqSGXLYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(346002)(136003)(39860400002)(451199015)(86362001)(36756003)(31696002)(66946007)(2616005)(41300700001)(66556008)(8676002)(66476007)(5660300002)(8936002)(186003)(6666004)(478600001)(6486002)(26005)(6512007)(316002)(54906003)(38100700002)(53546011)(6506007)(6916009)(4326008)(2906002)(31686004)(142923001)(43740500002)(45980500001)(376954003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXI0LzFxRFB0c2tTanNKMnZDTzlMTEYzbm1RdVdPUG16T3VCbXg0MCtNTDNp?= =?utf-8?B?V2lwOGFwWDZVTGhuclBqaWUvTVhOb0M4NFF4MWc3dEFDQWI4QmlzemxCQ0dO?= =?utf-8?B?YnFCdXpQRVZGSGJIdkJnd3B4K3F2TGVDSmZ1YW52VjVlMGVlc1F3WUtXYyt4?= =?utf-8?B?TkNkUHFEMko0S0tmMWdKZk9aT1dKTHJIM25vSmNtdk1oVVdwRm1PQlJIT0c2?= =?utf-8?B?R1NMLzBHckFTT3Vmcmk2aC8xa0VsTGxZMG82cHZUZW5aK2pSM21TL1NwTVFp?= =?utf-8?B?RldpNEpUQ1pKNWRWR05lb3dUdDVmWm5KN0tWLzFQT1M5NzN1b3AyNklWQVkz?= =?utf-8?B?VlBRSENMU2JvT0xvcXVTa2taZEZMSXpuMHppWWd0Q2JCVzgyVldaVVk0ZVZv?= =?utf-8?B?WUNNN3ZCblZsejlCenpLVlFJSlh3Z0JHWnMrTWJ0WTBDdmZKanRXOGV3aVlK?= =?utf-8?B?UG5hbEtpNFNROTloV240VU8yUGtneHoyU1BSdVhVYUZlSGEyTGVzSElGbHhF?= =?utf-8?B?RFRPaCtVY0k3bEp1QkZoVksrZC8xZ2ZCYkZKbWZNYUF2eC9RY2pKdWFtYlpt?= =?utf-8?B?STA0N0lEa1h6T2ttcGVqYTFzd1ppRFJVR0VwRUpDbzZPT2dEYWZXZkZsYVUr?= =?utf-8?B?UEVsclloRlM1eUVyL0dhWG8zT09DUnU5QjRjT2hhaFk2UDVZanZhRXNTMXZy?= =?utf-8?B?S0tmTUkvczdaeVpwdUdLRFYvSDMvaFUxU1RiRkVIU3lvUXF6YitQMUc0TzNq?= =?utf-8?B?Z2hxOS9hRXhGcVJJNnRybjRSaXJPdk54ODVnUnFTc0c2T2kxUldVc09HU29R?= =?utf-8?B?SFdkRkgyRzM3NFZyRGlzd3dNeDJQc3RZclBuUS9wbVJyYmRtelU5OVJ0QzhT?= =?utf-8?B?QUNELzJ3T25mNVVwNkUxWXlGWGkzcWJMTlZqMkhwdkQ0c1lzR0c0b1pEQ2FH?= =?utf-8?B?ajB5VDFBY0FkZjJ0Tm1EdkxaL3ltMzFVNzdYYlo3M3pLckc0a2VqSW9Dbm1X?= =?utf-8?B?bWRhV1pXUlNrUlBEUGFacjRoR2hkaFh2UktMdHpBQUo0M3VyOW40d1hZYzVK?= =?utf-8?B?V0xYbmliUzZrbGVtQ1BjMzZsSE1BQno4TFVEL2p1QjN2NE4xaGRIai9NMFM3?= =?utf-8?B?ZU1UaEFDUGlhQ3IyMkxQK1RRQ1JFNWhZNFVnMnZMTTdXOUpQL0REcWRvQTVy?= =?utf-8?B?eTVqYUlDVG1nQ1RKcjRUVXgxVVFLai9CRDljbnRmVTN3MFNMOWs5K3JzbzNh?= =?utf-8?B?OGx3WHkybDdwUWZFRzZicmEvNXg5VFVDZ1dUY0dHcVZMUDVIN2xkOHM2TytF?= =?utf-8?B?ZGlLYjRUT0FiSThDcVgvb3I2RXVaV3JNSW1LeTVBYlc2VkRSVHBvSDNYdzdn?= =?utf-8?B?THd5LzAxWnJnMFEvc3RKRS9rWXpIUW90c2QxRXY1M1RwT3kyd2RHRStuNlBn?= =?utf-8?B?N1NRUnNzTmJYcDVEVFNYcndQYlZtTUVMdHl1TTFWZjd3MmdwdHM0cno1OTg3?= =?utf-8?B?SnlBNGdGRGduRHlVczJUQzlmb0hoc25nb0JRQVcwaFppQk5mK09tN2ZUWkxq?= =?utf-8?B?ZW5vd1BveUlSRkM2UElmSVp4bXFDUXdMc0dyT3lSa20xY1JvWDhGbW9RUnVS?= =?utf-8?B?T3IrMUtHUGQvT1RaVjdyejVvcWF1b3RMZGJoWEpyZjN4bnI1TkRYZUxkMEJ2?= =?utf-8?B?eUg3T01XRWROMndIMTI4MEVnV2JOSlp4R3JWd2szVGJJOU9yY1I1RGUzOVlT?= =?utf-8?B?L0t4SGFFYW5FTU50cFU1TTViZU9mak00dDhBUVZlMzBTc0pPSnFhY1RuTVF1?= =?utf-8?B?U3NqUlRqYXJuVDhyMTVIR011ZjVGT2wyem1hWWk3L3ZwemsxNURkQzhpd2tH?= =?utf-8?B?M2ZOdDJFMG1uTkxDU0c2VE5peHVGV1ppcUx2azU5WW1UTHJwNFh4MCs2eG1k?= =?utf-8?B?bGFRbjJnUlVqbUpuY1FzTjhJeE1lSjMwRjRpbDh6WXdMTXdGOVZLZFpKWFZJ?= =?utf-8?B?TjFBRzZ1Z2U3ZlJmNUF4Y25sYmQ5NDZwWDAwOU5pZTlsVEp5S1U2ZURqcXk4?= =?utf-8?B?VHc5VnNPWTFvV0dBQnFKUEMyaDVPaWRJa1hPQlZuZkRzSWRNUHFpbU9zb3hD?= =?utf-8?Q?7QKc8b+N1yqgEPHz5+oCFR8vj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae98e304-e8e6-471a-f56b-08dacb928b75 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 07:32:29.3023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ib8Dwvsx9L++18zH3bEPUuqqxnoDZFHM2hUEhbEXEx8Cnlc177KRUcn4ln4j920ckS6EScib/mnfich9bPiTOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7495 X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.11.2022 08:10, Tsukasa OI wrote: > To make sure that all instruction bits are dumped through ".byte", this > commit makes matching patterns stricter (to cover all instruction bits). Hmm, it was deliberate to omit the .byte part of the disassembly, very specifically because of the inconsistency of using only in some cases. Personally I would agree with such tightening of the expectations only if the disassembler was first improved. But of course it's the maintainers judgement ... Jan > --- a/gas/testsuite/gas/riscv/insn-na.d > +++ b/gas/testsuite/gas/riscv/insn-na.d > @@ -61,15 +61,15 @@ Disassembly of section .text: > [^:]+:[ ]+022180d7[ ]+vadd\.vv[ ]+v1,v2,v3 > [^:]+:[ ]+0001[ ]+c\.addi[ ]+zero,0 > [^:]+:[ ]+00000013[ ]+addi[ ]+zero,zero,0 > -[^:]+:[ ]+001f 0000 0000[ ].* > -[^:]+:[ ]+0000003f 00000000[ ].* > -[^:]+:[ ]+007f 0000 0000 0000 0000[ ]+[._a-z].* > -[^:]+:[ ]+0000107f 00000000 00000000[ ]+[._a-z].* > -[^:]+:[ ]+607f 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000[ ]+[._a-z].* > +[^:]+:[ ]+001f 0000 0000[ ]+\.byte[ ]+0x1f, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+0000003f 00000000[ ]+\.8byte[ ]+0x3f > +[^:]+:[ ]+007f 0000 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+0000107f 00000000 00000000[ ]+\.byte[ ]+0x7f, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+607f 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x60, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > [^:]+:[ ]+0001[ ]+c\.addi[ ]+zero,0 > [^:]+:[ ]+00000013[ ]+addi[ ]+zero,zero,0 > -[^:]+:[ ]+001f 0000 0000[ ].* > -[^:]+:[ ]+0000003f 00000000[ ].* > -[^:]+:[ ]+007f 0000 0000 0000 0000[ ]+[._a-z].* > -[^:]+:[ ]+0000107f 00000000 00000000[ ]+[._a-z].* > -[^:]+:[ ]+607f 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000[ ]+[._a-z].* > +[^:]+:[ ]+001f 0000 0000[ ]+\.byte[ ]+0x1f, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+0000003f 00000000[ ]+\.8byte[ ]+0x3f > +[^:]+:[ ]+007f 0000 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+0000107f 00000000 00000000[ ]+\.byte[ ]+0x7f, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+607f 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x60, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > diff --git a/gas/testsuite/gas/riscv/insn.d b/gas/testsuite/gas/riscv/insn.d > index 2e5d35b39702..cf84f177af39 100644 > --- a/gas/testsuite/gas/riscv/insn.d > +++ b/gas/testsuite/gas/riscv/insn.d > @@ -83,12 +83,12 @@ Disassembly of section .text: > [^:]+:[ ]+0000 0000 0000 ? > [^:]+:[ ]+0001[ ]+nop > [^:]+:[ ]+00000013[ ]+nop > -[^:]+:[ ]+001f 0000 0000[ ].* > -[^:]+:[ ]+0000003f 00000000[ ].* > -[^:]+:[ ]+007f 0000 0000 0000[ ]+[._a-z].* > +[^:]+:[ ]+001f 0000 0000[ ]+\.byte[ ]+0x1f, 0x00, 0x00, 0x00, 0x00, 0x00 > +[^:]+:[ ]+0000003f 00000000[ ]+\.8byte[ ]+0x3f > +[^:]+:[ ]+007f 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > [^:]+:[ ]+0000 ? > -[^:]+:[ ]+0000107f 00000000[ ]+[._a-z].* > +[^:]+:[ ]+0000107f 00000000[ ]+\.byte[ ]+0x7f, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > [^:]+:[ ]+00000000 ? > -[^:]+:[ ]+607f 0000 0000 0000[ ]+[._a-z].* > +[^:]+:[ ]+607f 0000 0000 0000[ ]+\.byte[ ]+0x7f, 0x60, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > [^:]+:[ ]+0000 0000 0000 0000 ? > [^:]+:[ ]+0000 0000 0000 ?