From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) by sourceware.org (Postfix) with ESMTPS id BAD6A3858D3C for ; Tue, 21 Feb 2023 11:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAD6A3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8AWgzI53ZC/5V2zz91z9WpKpaIvNrmfx2vl3/gIFpcQbwAw5vZ34d7VBlFQNtoVYTUdwzL4xlETM9wG7DutRUf46L1HgnAdQ5S8W57P5lf4fHYmf+pq9keAyam9lA2ief8No+OFyzceK1HEpsObnPtF2sNG/b+T3aWp305J79t/KWZ8SG2ylIglIyo3wVcNDguo3eSC18MkCLwoUVGWOgX+x9u2muw2cf7Cm2QUrmEHJ3iK6vRAyZIPI5ZDU/LfWx18CL63aPQSuP+7IhDbVYoty2A6BV46WdEXDQJ36vT+qhx2wU0qc323dm3JoipqOJKk2ZyHaGWOyyky6hc0+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DQHs2T5cmnRRV/xgreRH5/PhPqb84+Muy4K9hyuhtHo=; b=moxd2F+fG8vQIgjNZio8PYF9BSc8SrFdvCUJ6jPy8XO/5Lcm29c8v/VUcX9qlsUgvdANmyQMzKqF1eIOoMh6eteBrkcLUwnfIVmk4/qcrWxO4OjVxGSWECQic7Ss9TevJivIEmUGX5fUfOaUN0UbdU+DBkwPEE6OfOhhew7aAE5wdMdQAU5ZjMokOZ6KxczLVmIzOEMJszEO9JpYqHIaM8tMRyIwoQvEWWCnUrpcyNFi5n+LfmO+5T2bCqL8jPol6wk4K+PORUgAGEbLT/6X9p1I3Cx2yPdI6jwrg0X1K3nRTr5BqUyEEESionz7WowCW9BWEGm0z0tXtJtYvQYCjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DQHs2T5cmnRRV/xgreRH5/PhPqb84+Muy4K9hyuhtHo=; b=F7Q4CQIoy3kMKLIY8cJdJef48GcWTELuNcLS+dkVgb7YJoXny/zHo0JdRO3RME7fp/vLOauP/Cg7SmtzU1keUF6M+lA3i1YLnom2i20BXSyI+h2y+mYz6WBud/X7p3hL4NL270+HrTRT6m4Tc4ny2HCFObkIGjqXSYrGJVeA2bVoEdWb94fZAByEOceFyumGuiNVntipSkzyIOvAXUEUHvi0R/yyHK1HqmJFZg0Z1SoaHfmb4iXwLBGrrN8hzGOOiiEEvK7F/4Jt5paaQk26nl8cXD9lfm3IMfXPoKvhgi0I5Znbo/5RSV4D57byFoDDATCLGNVAoaa4DQVW8vE+fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8208.eurprd04.prod.outlook.com (2603:10a6:102:1c7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 11:03:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:03:27 +0000 Message-ID: <6ab057e8-43aa-93b4-511c-348b3b2e23e3@suse.com> Date: Tue, 21 Feb 2023 12:03:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] ld: Sort section contributions in PDB files Content-Language: en-US To: Nick Clifton Cc: binutils@sourceware.org, Mark Harmstone , Alan Modra References: <20230220141328.20441-1-mark@harmstone.com> <7027c7ac-0e65-0bbb-22d3-167b929247f9@redhat.com> From: Jan Beulich In-Reply-To: <7027c7ac-0e65-0bbb-22d3-167b929247f9@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8208:EE_ X-MS-Office365-Filtering-Correlation-Id: bf670a87-03a8-4fef-73f5-08db13fb4261 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 86mPVfF5DOL2zW+2Z015t2kxBZ7MMYLrHwuineVWVz2n3wrxn4G28TaE5dRoszQKYmj+0inNH/1G/LV0CtcK3ZMHaT2BpuHqGRq51GuFGIaOCy/Yd4lR3Z5n69TxarltEmUlOIZ7NNmoHlX57P2mVPXcKhOHp7RHZEspmOnzckn8szmgUiaPUD6BqGq9QhpY/Lnn31DvwhqFe2GR+6T7zMd9wNYCp/g0/MCtQUGboV4Mq3I7CnqaX7j1s2EHug+Z4Izk8JxPiLNxPFaoPg1WJmuyWblwfghTbQDLl65aOZKFzcDpIpptGge92quC1jJtHkIXW1gc7qZmDC1JjFyBO5kgqpgzSRMvWFU7k8IRyjulFlxg2QC85F5al4svOlqSIN8+C/LZycjNXis4njv4X5/0ByKuLBbJ9XtkBRvkg+vf+/BrWHPY47S11sxTwlNBVk+BWRbx+bLFHHD5U/PGzCB/iybsD0pqkapX6YICNgg6CGA/jw9mIQOnrUDPVkVnsYTYwKJNLc1qfAVuFokB9VS4KqkTv/EZjD0LVcK2r/+sY+XeINOUb4CIoru4vIvedT7HRPGZ0H4NR6rsefSzpmVmVMKFbAETAH2vg3QH+E4+Fv1QlkqirFIqfxfi0mJ5CYIqOEw6B4lSNKC7XsSnrBDYmWVGJZgilAS2jtJEIPq9Sr7qxK8zNO/THkeQFkZZR7RutaWcJls9wHurZPNhVHLvJgeWrltArfEMaszM66U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199018)(53546011)(2616005)(38100700002)(6506007)(36756003)(2906002)(478600001)(86362001)(54906003)(31696002)(31686004)(66476007)(8676002)(6916009)(186003)(4326008)(26005)(6512007)(5660300002)(8936002)(6486002)(41300700001)(66946007)(66556008)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3QrWTFqZkRjUG1NQXFnYjB5V1VJN3pvUVJBVlNONUZDMXdLNERDV3pyZHI4?= =?utf-8?B?dmF1K0FSTU1qUHB4dXZad0EvTzRXamNhK1RucVRINmFQbVZlbEJaSHhkVHpK?= =?utf-8?B?QmpGczVCY05tazAzb1p3eEk2c0dDYkJsSnl0RWlqWDBxRVJmN2QxWmFuQWlY?= =?utf-8?B?RlIrUTNOS0s5QlJlQ1N1dFQ1VUF5alNhOWFiZnEvNFhET2VXUmswdWovUFBI?= =?utf-8?B?eExuMW5vaUxJNjFJQ1NRb1FhcU9LU0V5djdGQUZFZExEY0lVRnEvK0MvNWUr?= =?utf-8?B?aUFWM1crRTc3VjI2RDQxU1FHbHl1YXlxOWpMTTdHb2JwRVRoMksyRUpuQU10?= =?utf-8?B?SHdXVHBWMmZDaGI2dlpPRE5KUlMrZ25nSjh1djRjcnhHN2NGNnBjazZPZnlQ?= =?utf-8?B?L3QydndaR0VQQTlnbmorNE1adFA5TU1CVXBwRFJadjAyeXZVcmcxM0U4eTgr?= =?utf-8?B?c2lQUjNTbUtUSGpRWHB2QzA1a2p5VUlKN0hVdldoN05yaTY1elEzV25LYmxP?= =?utf-8?B?K1lMQTJTS2xrV0dmYTJtMEw1VEYxOXdsZG5LeXpLWXFseUtEOTNyeWJHOG5Y?= =?utf-8?B?Mk9IdDg2U1dYWGxpMVJpOTJyamNSTXF5U1VpN3RaYk5aVmp6M0xGY1pKOGlv?= =?utf-8?B?VC9ycnV5cWs2YmZLS0pucVYvNk4vZUYrd0hzNGZ0YlU1Zmp0K240TEtmQWJo?= =?utf-8?B?OE1PemZiZzAvdmh2VHZjY3ZHOS9wbkZvczVPYjFNQXdGZEtJZGFpNWJ3QWNz?= =?utf-8?B?bXpRVEFGdHZWOGpoWnR1UzdmSmp2QXhwMHVOM3EwVHZvcVg3RzQvR01QM0k3?= =?utf-8?B?bnpDbzNXa1FGZlF6M0t1Y0xuRFhMSmc5YXpEanF6eXp3Si9SeTRGMnJuN1dk?= =?utf-8?B?dUx2cEFUWnBnZGVMMVFwNy9xeDlJRFdOcE1WYkt0N2FVYnllMjRwMHdmUDFm?= =?utf-8?B?cXpSKzNGM3FvNm41UnRuQlB6WTgyaFhReWdFRCtUSHdEdVJxbDVFbXNlUFB4?= =?utf-8?B?Rk9RVldvdW5SSXExRGtaUGtpTmNQVlc4cDM4dlUvWGRQS2UrNlNkMG44dTJD?= =?utf-8?B?RlFPUklBZGVLWW1wWjdHeWlJU0lsNTRuZll1L1JXU2ZYeFdacnBPakphOS9I?= =?utf-8?B?QnVhYXhjdTMvTWFvNWVxSmV0T00zNGtPOXZCUzc4QVppUmJvNmJlak15MFc2?= =?utf-8?B?Z1l2ajV2bFZoVUhZdThGV1Z2RGRjbHZaNUV5V0R0a2lCV3QwNjBJNHFRWEIr?= =?utf-8?B?cmY2cGxEdU5WczZ1VTNiT29nZVhuOU5JMmVoelR4UlJpU0k5NFdtdUhMa3px?= =?utf-8?B?Z2Zib0prMng5SEUySURnOHdHNlg3M1VaektjajZhd29EWG1DZVBDV1dLR3J4?= =?utf-8?B?dTVKOFZKTzZicEpsZ1dwSXk0bzlaZUdab2pFQWpIKzljVXNlMk9SQlYydVlu?= =?utf-8?B?T2ViRXdRa1VRczhCc25XdExnRWxpVG9TdHJmbmdKUCtmWHhnZHRVMm1hU2Er?= =?utf-8?B?b1BjTk9rYXpGK2crZmZ4UkpXZ3FYbElVYnNZYnZJNG1YendZYVN3SGhmejRy?= =?utf-8?B?VTRielROM2tOWVROcmJHeU5tcjV0ZjJVbFFYSzVqZ3ZMdUdLTFJXdUgrMTBB?= =?utf-8?B?bHBSZkpqcGFzd0ZRb0x2Q0hZVU1yMFNhUGRBanJqenhVOGV4MFJ1RkhHRWxh?= =?utf-8?B?T1pqZXlpVmhTS1dUZjVFYjcrM3NvS1BjSjRqeE1ObFIzdjM5aHVGMytyeU5j?= =?utf-8?B?ZnhiK3dmelRmRkdiNmMrNXRwSTNZbVlSeE1yekIwNXN0M3N4bXh5S0NYbTNX?= =?utf-8?B?QkRGZlVSZk92ZTN0dHlaOEZiNEVSZ3RzUGVSM2JFZURtVi9CakNvQ28yTCs5?= =?utf-8?B?V0xzNFBxUjY4NjI5QXFMRi9BZndKT01Jd0srNjNCWU5OSTFNOUlBakRPQUFk?= =?utf-8?B?eWp5Wm5HbC9FWE4wRDU5bU50dVF6Wi9OZitNZlN0VGdISTBNb2hJY3diUWVu?= =?utf-8?B?SVk0NHhWMnBvTitQOHVPam80T3U2NjRxc0pGR21TVzc1LzIzTXdYWmUyMkZR?= =?utf-8?B?VmZyNDFnYzFVZGpSRGVsUmR2L2l1R0N5VE9oaTU5YjdWajFiQ3BLVFRnajRI?= =?utf-8?Q?/fi8jcV48DUFNZMw8GH2gJa3+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf670a87-03a8-4fef-73f5-08db13fb4261 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:03:27.6490 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MU5BF8hai16hfe9UeHo2w39r/xo04XntE0kueneZfoVxWX6Z/PHZP2IUoskGQmGXa6zwB2toZ3RBLtZemUZXIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8208 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21.02.2023 11:49, Nick Clifton wrote: > On a related note - I would consider this line to be problematic: > > sc_in = xmalloc (num_sc * sizeof (struct in_sc)); > > The code here implies that "sc_in" is a pointer to the "struct in_sc" type. > If at some future date the code is changed and the type of "sc_in" is changed > then the above line will still work, but the wrong amount of space will be > allocated. Oh, indeed, another pattern I would normally feel tempted to comment on, just that I've overlooked it this time. > So I would suggest changing it to either: > > sc_in = xmalloc (num_sc * sizeof (* sc_in)); Yes. > Or: > > sc_in = xmalloc (num_sc * sizeof * sc_in); /* I like this version, but nobody else does ... :-) */ Well ... * is commutative as a binary operator, so how about re-writing it to sc_in = xmalloc (num_sc * sc_in * sizeof); ;-) ? > Or: > > sc_in = XNEWVEC (typeof (sc_in), num_sc); I guess this one's the form that's best in line with what's used elsewhere in binutils. Jan