From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2079.outbound.protection.outlook.com [40.107.15.79]) by sourceware.org (Postfix) with ESMTPS id 0E6983856976 for ; Thu, 13 Jul 2023 10:25:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E6983856976 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/gqWpR68EWgcX/ez0xUtu2gfLBV0BOtwOTyIASaIdqS7/rbqGNbX3+fpxxlaMgQAoi7JDpZGsNsu3uIBr78auChjo9LGnWofD0l4+iYXg7tX2vApqtpo8H1JSjEwlBaTqk2DzCH9RXjizR41YfSqAk7pqf+85RDZuv7yhCwu6err17B+tSXfKZ2zOq9Oo9sb0gRQEKJX50LMjyVV6VdzdJ0IUzMW2iMEctQ/3BIm2XOC8bz8d2H9q8Kf5kMklF2potS4rujLQ9CpCbxWCD5zxPqNDJFeWSnkDB0VHSvK2q6rlREYlEK2iUb7lxuv/z7yUcByfwUXJIHr7Iep7Thtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1me/zcbT9+WW434CqAtKiaByDCB8zFXFdMiNd3D5+Is=; b=XD4oazCPXDco3OF6R8EkCA+GTBV0AmtGCccHLCQbnuk4Yett/Wi4pyKN4JUbKD7Z5j0lYz/ufofNfVR/MkXCJMrPr1oBn2HhCzdtvELxPfZ3KHvts4pasd6YIfUZj0DphWFmPmIqz//ZRq6nmGR449QsO4MpoQnzq//E2qssOGYzqoxEMVRDsDFnEom3GoryVdzq8mt0phuqyvcrgxiYKz+pC0jNqMkKeq/QX/5p0WV/van8FXZnjX+ZQMNP1zHW2YdjC5icYdj7FEduvZXvCw5QYYu8Abpxin0htPRWjGtmIeGVSW9++OUAz42cjzgCROFmSEX+okZcLzYtMmJSzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1me/zcbT9+WW434CqAtKiaByDCB8zFXFdMiNd3D5+Is=; b=5K9NpIrXzA6E/vVs7etS2mVHJ6qFaK2HbrvWMRW//fvbwoloYYNlNcXpsnZsdBc6u/bS2bmt5kDYrxWcH1uMfVHhGKRCRfUbF3UY2FJ6MXsvPLYt7uU0+1qu/yOFoa6jqT9qRrtLhvA6lw7r2j/xQkfKYsuXJTZC9DJ3/cBenKd9exkn+pMw+3mBIyuQ6lreatNhTsnAJgsbzmDE3bTEhmD7wWVErsddz/vVuLG7l/szR5uVQ4HtI3QrTvhXeG437Y57mmtDdyjaOtG5uukjyD+c9oScNJ8l51GtFpHQPcHppaNZW5IBc2iVX3On7N0tTxVGQNL1aWhsep7dTal9hA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by AM9PR04MB8082.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 10:25:27 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Thu, 13 Jul 2023 10:25:27 +0000 Message-ID: <6b7d088a-36fe-8560-ba6a-e84b7463c03f@suse.com> Date: Thu, 13 Jul 2023 12:25:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/5] Support Intel SM4 Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, amodra@gmail.com, binutils@sourceware.org References: <20230713063303.205862-1-haochen.jiang@intel.com> <20230713063303.205862-5-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20230713063303.205862-5-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0178.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::19) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|AM9PR04MB8082:EE_ X-MS-Office365-Filtering-Correlation-Id: c103e246-e1b9-4d54-64e8-08db838b7a2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zj4cdnHgX9oR2+Tu4KetiBSBAFzp7dvHRawWo2dpO9P6jRtGxayOA6Yi5b/0V/8OGyTDV3a71za1mzrkpn/GEp6tbxuxJdz35yaBvNlgOce+lE/DPIvp3oTrWW2FcAH0gQnK1K/Ff0qPvxQBT/xYUr8fhlkNPcZiHhG47nhEguACf0/Lc2ZcZHEZRQmKSmlDt1HyAUmshzY0+7paL8lYL2rk7E4HX30q0ht6bR5RdkoQUhwt18yqc1eypdYMqe/SPV1pgvykKdOw903v448+kCtO0Gaz64eyR8JZLtfdx6xMQrZulmTwm7Kk7Lz4mGwDLjMPmOBQQU6OZcZoLNvnRfhS3FysFb0vpfUv+yk+tzt1g0xjvzUejxZTAWjPV/25PbPqW9aXUnrQrjMp4YAwM4RZoBPEurUjzX3DJIurqSBhGAcl/oZbjuSH9raPU3W2ELz298HkQD2MGYp2bor9tPwKAf3E9A1br1gxohLtjssZ5lt5oNJZYz0dwG1/ot97SbwKXnShoWgLvOVneQPfTNuN+Rrkm5dtYYtLjyBqTE8907BB01oQc7NH+OSi4oEyVnfp3IE+AetPqm3Pl8tr1ny9zfZcIIBsCCVI5QL5Vxen1iuIch0cH8K/fX8XZNhKXVxm0/csacnnBk8fNjM0Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199021)(316002)(6916009)(4326008)(66946007)(66556008)(66476007)(6486002)(186003)(478600001)(31686004)(6512007)(41300700001)(8676002)(8936002)(53546011)(31696002)(6506007)(26005)(5660300002)(83380400001)(86362001)(36756003)(2906002)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1drY3B6WVRTdnRmQzNQR3lrQ1hlL05tVzNsaW01eERra1dsN0c1L1NXMkhu?= =?utf-8?B?aXNHdjNmaEtydlBZOVp1cWo5TXlGQ2ZKVXZ3cGZkNGlNUnlpMW9jbXVld293?= =?utf-8?B?WmJXcENaNFVXTnRQaG1VZldQUE5EN1hJQUFkMFN0aHU2RzBueWhqc1J5S0lB?= =?utf-8?B?U0wyL0xFUElDR3hwRytoUUNGekw0a3RCRTJ5WTVtTE1yNzJRNjJkMFZYclp0?= =?utf-8?B?cmIrRldIeVczeG0zWWxxaldEZVA5bURiZkgxd3hzNDFCaWxFMWh5cVRsS0pE?= =?utf-8?B?TDdhMUx0YnV0RmpZdkt5dkVDZEJZYjI5UE1hUWFTQkN1djhuYStqT2hxdWEr?= =?utf-8?B?Z2hGSXhHS3Y0aXhZS01IYVQwOVZ6cGh2ZElON1EwR1ExU1QvQkZ1MnhEZEpu?= =?utf-8?B?cVlHQTdQQWhaWWsvQVNCemdNRnNabUhQdW1XdEhPOVNhRlJ2NUdWUi8vQUVY?= =?utf-8?B?cWtKc2tKVTdIeER0ei9rdEY3TGtzdDFsZmRNQ25Qa09LcmpsQWZoQng4OHBz?= =?utf-8?B?dThISExHck1CS280MVloam1mTVljOVlOaGpuV1lrblMvY1VaMUR5VXV3akE2?= =?utf-8?B?VjlPeXRkSnhKQWFQNGR3TU5hUXM4NjdzRG1mbTdXNFlnZUxQd1cyV0cyMGdC?= =?utf-8?B?WDF1d2NxQUxpMGN5emlsUUllN3hTMTJxYTJIK3kxZ2czWjNzd1AvWkd6S1pz?= =?utf-8?B?SkZVWUpJQUNhaVl2UzNhNHczb3lGZkxObDRPT2x0YThlbnpzY2JFREVOMXNp?= =?utf-8?B?a1g4WkdyMnZpSkhtNzdoeVZKQ3lmMTlTVWZUL0dLK0piWVJ3d2ZuYWhBeWRa?= =?utf-8?B?NUdBdFNlM2ZPSzZTOHBqZzlLNzhKWXZWekdxYlR5OGpmdE44UjRBU1gvSkFl?= =?utf-8?B?eXRiRlU5Ri85VGlybE5CNFoxd2tDUE8ySmNBdFJWK0phdnh1NHJWQWJuMlpp?= =?utf-8?B?em1uNDREbGRYdjAvS04wVzNHRXNKSUJOTzhlTHhYOTRyOGNUTzNUWjlQdkRN?= =?utf-8?B?dG5Eb0dRR2JsOHo4ZHhrSEFpT0MvWXhoZ3V4a0taSkVINCsvNXdnNVpjM2lv?= =?utf-8?B?L09qczlFUTc1aVNCUUNsbHVnc0NueHZHVkswSG00Vjhhclo0czNKUzNXTnhD?= =?utf-8?B?dG1pNk9uWTJVbHM2ZzhlNGpVc3NjZGVXZ0NqMWlONTFTdXorSWtmeHEzTHpq?= =?utf-8?B?TDBlcWxsYWFFNm5Db2U1ai96VmRneWZkU1VEMFhjM0lzdEJjRDlxT1VhR1Aw?= =?utf-8?B?RjByOFBoOFBuNmRWS0g3WTlKSHRGYTROdjk0dEV3SDZETm9uNlE1TDduQm04?= =?utf-8?B?c3c1cCtNSzkrWm5DSkVVeTdQdm43MnJEZ1RRSTlVS3pDSGhwTXZWV2RWL0RR?= =?utf-8?B?MXU3a3NDTHQzZDFobjh1d1B4bk82aDdSci9wS3k2UTRjNFJSa21uMGwzOFA0?= =?utf-8?B?VHVWcDhMc2ZpekloS3IraHNZRDVwOHB3SllxQ08wNlN2V3Y0L09tMXBSYWpO?= =?utf-8?B?L2hkOCtMQzNUeVZ4Mkc1RzRpVExaMjNTSlZObDN1ZThydXFxNzY1eWRMOVJD?= =?utf-8?B?dGw2aTFvSjUzRThnSVFkU2QvQUlaZERqb0doR1JJZ1lhQXY5dUExd1V1OXJi?= =?utf-8?B?VXdscnNsaTVKOHZ3ajBFRzVuL0JJYjZNcllrUDcvdjhKQmxVc2lNeDFFL2VQ?= =?utf-8?B?NmoyeUF1b0hqU2tib3NQb3hDQ1hMeXg5WXhmYWRQeG5WampuUmJyc1F4MU5K?= =?utf-8?B?Vi9rd0xoaUVzbDY1ZUR3TEczVVlvNks3K25PVzIxZGdzRmNMcHNRSUhtQldK?= =?utf-8?B?TlNsMDBOTnJYdVZ6YWZrWnMxSkl3UG8xblJ3a1RmVVYvN1NNOVU4M1EwRVVr?= =?utf-8?B?c2FIUkNPSHNNL0Y4TE93N2pjemlWN3pRZjM4d2pXTUxpNUloRC9JUC9UZitT?= =?utf-8?B?cVVMb1FRdHliSjNUd0hBOC83cStCK3JkNlluSlFaSUE5TkhUR1lsaEozUkpQ?= =?utf-8?B?OTJJTE9VbHVmU0lyNXhHTGUzT1pKbjlNb1NWTTIwbDVXbkJWVGZ6VFc2eEFK?= =?utf-8?B?eDc4K3lmNEY5YlB1NUE4RHBJSWszSTZ4blhDWDE4cHF2YkZoSU03L3hCdW9z?= =?utf-8?Q?UySh4ar/3u5GsqIc9F1f36mho?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c103e246-e1b9-4d54-64e8-08db838b7a2f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 10:25:27.7683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PxgseZxWWnx2Hhh+IvVO7lgecrFiN/odmfYvK7MuOtsXYgpkqyX8Z6W2inIxER52UeVMZrc/V8m20lcQtvKfaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8082 X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13.07.2023 08:33, Haochen Jiang wrote: > --- a/opcodes/i386-dis.c > +++ b/opcodes/i386-dis.c > @@ -1070,7 +1070,7 @@ enum > PREFIX_VEX_0F38CB, > PREFIX_VEX_0F38CC, > PREFIX_VEX_0F38CD, > - PREFIX_VEX_0F38DA_W_0_L_0, > + PREFIX_VEX_0F38DA_W_0, > PREFIX_VEX_0F38F5_L_0, > PREFIX_VEX_0F38F6_L_0, > PREFIX_VEX_0F38F7_L_0, > @@ -1316,7 +1316,8 @@ enum > VEX_LEN_0F38CB_P_3_W_0, > VEX_LEN_0F38CC_P_3_W_0, > VEX_LEN_0F38CD_P_3_W_0, > - VEX_LEN_0F38DA_W_0, > + VEX_LEN_0F38DA_W_0_P_0, > + VEX_LEN_0F38DA_W_0_P_2, > VEX_LEN_0F38DB, > VEX_LEN_0F38F2, > VEX_LEN_0F38F3, > @@ -3969,11 +3970,12 @@ static const struct dis386 prefix_table[][4] = { > { VEX_W_TABLE (VEX_W_0F38CD_P_3) }, > }, > > - /* PREFIX_VEX_0F38DA_W_0_L_0 */ > + /* PREFIX_VEX_0F38DA_W_0 */ > { > - { "vsm3msg1", { XM, Vex, EXxmm }, 0 }, > - { Bad_Opcode }, > - { "vsm3msg2", { XM, Vex, EXxmm }, 0 }, > + { VEX_LEN_TABLE (VEX_LEN_0F38DA_W_0_P_0) }, > + { "vsm4key4", { XM, Vex, EXx }, 0 }, > + { VEX_LEN_TABLE (VEX_LEN_0F38DA_W_0_P_2) }, > + { "vsm4rnds4", { XM, Vex, EXx }, 0 }, > }, > > /* PREFIX_VEX_0F38F5_L_0 */ > @@ -7010,9 +7012,14 @@ static const struct dis386 vex_len_table[][2] = { > { "vsha512msg2", { XM, Uymm }, 0 }, > }, > > - /* VEX_LEN_0F38DA_W_0 */ > + /* VEX_LEN_0F38DA_W_0_P_0 */ > + { > + { "vsm3msg1", { XM, Vex, EXxmm }, 0 }, > + }, > + > + /* VEX_LEN_0F38DA_W_0_P_2 */ > { > - { PREFIX_TABLE (PREFIX_VEX_0F38DA_W_0_L_0) }, > + { "vsm3msg2", { XM, Vex, EXxmm }, 0 }, > }, > > /* VEX_LEN_0F38DB */ > @@ -7716,7 +7723,7 @@ static const struct dis386 vex_w_table[][2] = { > }, > { > /* VEX_W_0F38DA */ > - { VEX_LEN_TABLE (VEX_LEN_0F38DA_W_0) }, > + { PREFIX_TABLE (PREFIX_VEX_0F38DA_W_0) }, > }, > { > /* VEX_W_0F3A00_L_1 */ I think it would be nice if this patch didn't need to re-do what the immediately preceding patch does. Can that earlier patch be adjusted to the final intended decode order? Some of the comments given for earlier patches also apply here, ftaod. Jan