From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9049E3858D3C for ; Wed, 22 Mar 2023 13:30:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9049E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679491849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=olTXT3SOIrtMxfAdqodrUcotwcM7vMN1JKaxN2+y0MU=; b=BIFawmA/vl9Kfzh5oAS97jgYRtn7JWbzT1xy5ca3PsLVu2E5uuodhoFCr82BmlO1TTGoFv Pmrp9nwJIhuRZEh825yFvI9zqQkWDQ++gqK6NL9eAsAk46mxvkzbOS9PMnXLD9vhQz2Av9 J5MkiWT6/YGDKD2GgbYy9HWYFI++sxs= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-GMHbWNIfOOuZi93mDrk60g-1; Wed, 22 Mar 2023 09:30:48 -0400 X-MC-Unique: GMHbWNIfOOuZi93mDrk60g-1 Received: by mail-qv1-f69.google.com with SMTP id j15-20020a0cc34f000000b005c824064b10so4975094qvi.17 for ; Wed, 22 Mar 2023 06:30:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679491847; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=olTXT3SOIrtMxfAdqodrUcotwcM7vMN1JKaxN2+y0MU=; b=lP3rxzvqA0Y7d49Cdp7jXDMagcjFX/UdpqmiCSXebHyuECRlI0tXpVE0k6ViBwDX8j qmwsrFRzS78VQGf8HPl/9iRJwU191ti6t6ol/4GpJpk/jSH6O66path6mc+Lo23lwt0A sd077IMeq55ubBJYpJsVxEgGVraxaupq6YPBdNhhWy94LeNi+hLTeZvLjSytuMgAaDgD QHbi3Mbd/raQ3GijEdEZHZEwrHxgoHc4UkZMaWcu1ttb10yZsLyv0T9wTxm09Xw4La92 WtSJucLu30GFrP5ck5UpKH9YfqhQwCtzZvl6P+k3dHsvVY53KnAxGtmAqKeH3k7S8d6O xn8A== X-Gm-Message-State: AO0yUKVN7hk+ShqCBIZpyl4lpJEBTsww9Rd3qjrmpcBRO9rOAmFJ6lDA dtsCNBw+V2hb1jFI1v1nlq2LOo+fz6Z7VsUvrQH0cfnMQMeEg5NiDj31qD4sZrLJbf9U1IEQvgN UsXQK6JFjdARWyfXkpA== X-Received: by 2002:a05:622a:284:b0:3b6:36e1:ed42 with SMTP id z4-20020a05622a028400b003b636e1ed42mr5580026qtw.9.1679491847464; Wed, 22 Mar 2023 06:30:47 -0700 (PDT) X-Google-Smtp-Source: AK7set9x+aoMjAb9aEihnfB4G1ArRjAVUkhYhwcHlrgqXGmDQHmLnkzU9u5GFuR/u50bAbsbPKWEJg== X-Received: by 2002:a05:622a:284:b0:3b6:36e1:ed42 with SMTP id z4-20020a05622a028400b003b636e1ed42mr5579988qtw.9.1679491847185; Wed, 22 Mar 2023 06:30:47 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id u12-20020ac8750c000000b003e38f8d564fsm126439qtq.66.2023.03.22.06.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 06:30:46 -0700 (PDT) Message-ID: <6babc0c1-8d6c-2944-565f-cbcda7c6140d@redhat.com> Date: Wed, 22 Mar 2023 13:30:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/3] bfd: aarch64: Fix stubs that may break BTI PR30076 To: Szabolcs Nagy , binutils@sourceware.org References: <20230321142848.672474-1-szabolcs.nagy@arm.com> From: Nick Clifton In-Reply-To: <20230321142848.672474-1-szabolcs.nagy@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Szabolcs, > Insert two stubs in a BTI enabled binary when fixing long calls: The > first is near the call site and uses an indirect jump like before, > but it targets the second stub that is near the call target site and > uses a direct jump. > > This is needed when a single stub breaks BTI compatibility. > > The stub layout is kept fixed between sizing and building the stubs, > so the location of the second stub is known at build time, this may > introduce padding between stubs when those are relaxed. Stub layout > with BTI disabled is unchanged. > --- > bfd/elfnn-aarch64.c | 175 ++++++++++++++++++++++-- > ld/testsuite/ld-aarch64/aarch64-elf.exp | 3 + > ld/testsuite/ld-aarch64/bti-far-1.d | 83 +++++++++++ > ld/testsuite/ld-aarch64/bti-far-2.d | 62 +++++++++ > ld/testsuite/ld-aarch64/bti-far.ld | 15 ++ > ld/testsuite/ld-aarch64/bti-far.s | 29 ++++ > 6 files changed, 352 insertions(+), 15 deletions(-) > create mode 100644 ld/testsuite/ld-aarch64/bti-far-1.d > create mode 100644 ld/testsuite/ld-aarch64/bti-far-2.d > create mode 100644 ld/testsuite/ld-aarch64/bti-far.ld > create mode 100644 ld/testsuite/ld-aarch64/bti-far.s Patch approved - please apply. Cheers Nick